ManagesProjects::project() - Code Metrics - Inspection of "Fix response on empty project list" - testmonitor/donedone-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ed1c60...0ee5eb )

by steef

created 2019-12-20 14:14 UTC

ManagesProjects::project() A

↳ Parent: ManagesProjects

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	3
cts	3
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	2
crap	1

<?php

namespace TestMonitor\DoneDone\Actions;

use TestMonitor\DoneDone\Resources\Project;
use TestMonitor\DoneDone\Transforms\TransformsProjects;

trait ManagesProjects
{
    use TransformsProjects;

    /**
     * Get a list of of projects.
     *
     * @param int $accountId
     * @return Project[]
     */
    public function projects(int $accountId): array
    {
        $result = $this->get("{$accountId}/internal-projects");
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        if ($result === '[]') {
            return [];
        }

        return array_map(function ($project) {
            return $this->fromDoneDoneProject($project);
        }, $result);
    }

    /**
     * Get a single project.
     *
     * @param int $accountId
     * @param int $id
     *
     * @return Project
     */
    public function project(int $accountId, int $id): Project
    {
        $result = $this->get("{$accountId}/internal-projects/{$id}");
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $this->fromDoneDoneProject($result);
    }
}


1		<?php
2
3		namespace TestMonitor\DoneDone\Actions;
4
5		use TestMonitor\DoneDone\Resources\Project;
6		use TestMonitor\DoneDone\Transforms\TransformsProjects;
7
8		trait ManagesProjects
9		{
10		use TransformsProjects;
11
12		/**
13		* Get a list of of projects.
14		*
15		* @param int $accountId
16		* @return Project[]
17		*/
18	7	public function projects(int $accountId): array
19		{
20	7	$result = $this->get("{$accountId}/internal-projects");
		0 ignored issues – show Bug introduced 2019-12-04 16:53 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
21
22	1	if ($result === '[]') {
23		return [];
24		}
25
26		return array_map(function ($project) {
27	1	return $this->fromDoneDoneProject($project);
28	1	}, $result);
29		}
30
31		/**
32		* Get a single project.
33		*
34		* @param int $accountId
35		* @param int $id
36		*
37		* @return Project
38		*/
39	1	public function project(int $accountId, int $id): Project
40		{
41	1	$result = $this->get("{$accountId}/internal-projects/{$id}");
		0 ignored issues – show Bug introduced 2019-12-04 16:53 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
42
43	1	return $this->fromDoneDoneProject($result);
44		}
45		}
46

testmonitor / donedone-client

Push — master ( ed1c60...0ee5eb )

ManagesProjects::project() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like