TestMonitor\DevOps\Actions\ManagesWebhooks

Complexity

Total Complexity

3

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	webhooks()	0	10	1
A	createWebhook()	0	10	1
A	deleteWebhook()	0	5	1

<?php

namespace TestMonitor\DevOps\Actions;

use TestMonitor\DevOps\Resources\Webhook;
use TestMonitor\DevOps\Transforms\TransformsWebhooks;

trait ManagesWebhooks
{
    use TransformsWebhooks;

    /**
     * Get a list of webhooks.
     *
     * @param string $eventType
     *
     * @throws \TestMonitor\DevOps\Exceptions\InvalidDataException
     *
     * @return \TestMonitor\DevOps\Resources\Webhook[]
     */
    public function webhooks($eventType = '')
    {
        $response = $this->get('_apis/hooks/subscriptions', [

It seems like get() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            'query' => array_filter([
                'eventType' => $eventType,
                'consumerId' => 'webHooks',
            ]),
        ]);

        return $this->fromDevOpsWebhooks($response['value']);
    }

    /**
     * Create a new webhook.
     *
     * @param \TestMonitor\DevOps\Resources\Webhook $webhook
     *
     * @throws \TestMonitor\DevOps\Exceptions\InvalidDataException
     *
     * @return \TestMonitor\DevOps\Resources\Webhook
     */
    public function createWebhook(Webhook $webhook): Webhook
    {
        $response = $this->post(

It seems like post() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            '_apis/hooks/subscriptions',
            [
                'json' => $this->toDevOpsWebhook($webhook),
            ]
        );

        return $this->fromDevOpsWebhook($response);
    }

    /**
     * Delete a webhook.
     *
     * @param int $id
     *
     * @throws \TestMonitor\DevOps\Exceptions\InvalidDataException
     *
     * @return bool
     */
    public function deleteWebhook($id): bool
    {
        $response = $this->delete("_apis/hooks/subscriptions/{$id}");

The method delete() does not exist on TestMonitor\DevOps\Actions\ManagesWebhooks. Did you maybe mean deleteWebhook()?

        return empty($response);
    }
}