ManagesWorkItems::createWorkItem() - Code Metrics - Inspection of "Added work items test" - testmonitor/devops-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d38bb3...5cc041 )

by Thijs

created 2019-12-01 12:39 UTC

ManagesWorkItems::createWorkItem() A

↳ Parent: ManagesWorkItems

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	6
cts	6
cp	1
rs	9.8666
c	0
b	0
f	0
cc	1
nc	1
nop	2
crap	1

<?php

namespace TestMonitor\DevOps\Actions;

use TestMonitor\DevOps\Resources\WorkItem;
use TestMonitor\DevOps\Transforms\TransformsWorkItems;

trait ManagesWorkItems
{
    use TransformsWorkItems;

    /**
     * Get a single work item.
     *
     * @param string $projectId
     * @param string $id
     *
     *@return \TestMonitor\DevOps\Resources\WorkItem
     */
    public function workitem(string $id, string $projectId): WorkItem
    {
        $response = $this->get("{$projectId}/_apis/wit/workitems/{$id}");
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $this->fromDevOpsWorkItem($response);
    }

    /**
     * Create a new work item.
     *
     * @param \TestMonitor\DevOps\Resources\WorkItem $workItem
     * @param string $projectId
     *
     * @return WorkItem
     */
    public function createWorkItem(WorkItem $workItem, string $projectId): WorkItem
    {
        $response = $this->post(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            "{$projectId}/_apis/wit/workitems/\${$workItem->workItemType}",
            [
                'headers' => ['Content-Type' => 'application/json-patch+json'],
                'json' => $this->toDevOpsWorkItem($workItem),
            ]
        );

        return $this->fromDevOpsWorkItem($response);
    }
}


1		<?php
2
3		namespace TestMonitor\DevOps\Actions;
4
5		use TestMonitor\DevOps\Resources\WorkItem;
6		use TestMonitor\DevOps\Transforms\TransformsWorkItems;
7
8		trait ManagesWorkItems
9		{
10		use TransformsWorkItems;
11
12		/**
13		* Get a single work item.
14		*
15		* @param string $projectId
16		* @param string $id
17		*
18		*@return \TestMonitor\DevOps\Resources\WorkItem
19		*/
20	4	public function workitem(string $id, string $projectId): WorkItem
21		{
22	4	$response = $this->get("{$projectId}/_apis/wit/workitems/{$id}");
		0 ignored issues – show Bug introduced 2019-11-30 12:38 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
23
24	1	return $this->fromDevOpsWorkItem($response);
25		}
26
27		/**
28		* Create a new work item.
29		*
30		* @param \TestMonitor\DevOps\Resources\WorkItem $workItem
31		* @param string $projectId
32		*
33		* @return WorkItem
34		*/
35	2	public function createWorkItem(WorkItem $workItem, string $projectId): WorkItem
36		{
37	2	$response = $this->post(
		0 ignored issues – show Bug introduced 2019-11-30 12:38 UTC by Report Bug Copy Issue Report It seems like `post()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
38	2	"{$projectId}/_apis/wit/workitems/\${$workItem->workItemType}",
39		[
40	2	'headers' => ['Content-Type' => 'application/json-patch+json'],
41	2	'json' => $this->toDevOpsWorkItem($workItem),
42		]
43		);
44
45	1	return $this->fromDevOpsWorkItem($response);
46		}
47		}
48

testmonitor / devops-client

Push — master ( d38bb3...5cc041 )

ManagesWorkItems::createWorkItem() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like