ManagesContacts::updateContact() - Code Metrics - Inspection of "Additional Contact methods" - testmonitor/activecampaign - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#17)

by Pablo

created 2019-08-13 13:33 UTC

ManagesContacts::updateContact() A

↳ Parent: ManagesContacts

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	5

<?php

namespace TestMonitor\ActiveCampaign\Actions;

use TestMonitor\ActiveCampaign\Resources\Tag;
use TestMonitor\ActiveCampaign\Resources\Contact;
use TestMonitor\ActiveCampaign\Resources\Automation;
use TestMonitor\ActiveCampaign\Resources\ContactTag;
use TestMonitor\ActiveCampaign\Resources\ContactAutomation;

trait ManagesContacts
{
    /**
     * Get all contacts.
     *
     * @return array
     */
    public function contacts()
    {
        return $this->transformCollection(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->get('contacts'),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            Contact::class,
            'contacts'
        );
    }

    /**
     * Find contact by email.
     *
     * @param string $email
     *
     * @return Contact|null
     */
    public function findContact($email)
    {
        $contacts = $this->transformCollection(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->get('contacts', ['query' => ['email' => $email]]),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            Contact::class,
            'contacts'
        );

        return array_shift($contacts);
    }

    /**
     * Find contact by ID.
     *
     * @param int $id
     *
     * @return Contact|null
     */
    public function findContactById($id)
    {
        $contacts = $this->transformCollection(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->get('contacts', ['query' => ['id' => $id]]),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            Contact::class,
            'contacts'
        );

        return array_shift($contacts);
    }

    /**
     * Create new contact.
     *
     * @param string $email
     * @param string $firstName
     * @param string $lastName
     * @param int|null $orgid
     *
     * @return Contact|null
     */
    public function createContact($email, $firstName, $lastName, $orgid = null)
    {
        $contacts = $this->transformCollection(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->post('contacts', ['json' => ['contact' => compact('email', 'firstName', 'lastName', 'orgid')]]),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            Contact::class
        );

        return array_shift($contacts);
    }

    /**
     * Find or create a contact.
     *
     * @param string $email
     * @param string $firstName
     * @param string $lastName
     * @param int|null $orgid
     *
     * @return Contact
     */
    public function findOrCreateContact($email, $firstName, $lastName, $orgid = null)
    {
        $contact = $this->findContact($email);

        if ($contact instanceof Contact) {
            return $contact;
        }

        return $this->createContact($email, $firstName, $lastName, $orgid);
    }

    /**
     * Updates a contact.
     *
     * @param Contact|int|string $id
     * @param string|null        $email
     * @param string|null        $firstName
     * @param string|null        $lastName
     * @param null               $orgid
     *
     * @return Contact|null
     */
    public function updateContact($id, $email, $firstName, $lastName, $orgid = null)
    {
        $id = $this->getContactId($id);

        $this->put('contacts/'.$id, ['json' => ['contact' => compact('email', 'firstName', 'lastName', 'orgid')]]);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $this->findContactById($id);
    }

    /**
     * Deletes a contact.
     *
     * @param Contact|int|string $contact
     */
    public function deleteContact($contact)
    {
        $this->delete('contacts/'.$this->getContactId($contact));

    }

    /**
     * Get all automations of a contact.
     *
     * @param \TestMonitor\ActiveCampaign\Resources\Contact $contact
     *
     * @return array
     */
    public function contactAutomations(Contact $contact)
    {
        return $this->transformCollection(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->get("contacts/{$contact->id}/contactAutomations"),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ContactAutomation::class,
            'contactAutomations'
        );
    }

    /**
     * Get all tags of a contact.
     *
     * @param \TestMonitor\ActiveCampaign\Resources\Contact $contact
     *
     * @return array
     */
    public function contactTags(Contact $contact)
    {
        return $this->transformCollection(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->get("contacts/{$contact->id}/contactTags"),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ContactTag::class,
            'contactTags'
        );
    }

    /**
     * Removing a automation from a contact.
     *
     * @param \TestMonitor\ActiveCampaign\Resources\Contact $contact
     * @param \TestMonitor\ActiveCampaign\Resources\Automation $automation
     */
    public function removeAutomationFromContact(Contact $contact, Automation $automation)

    {
        $contactAutomations = $this->contactAutomations($contact);

        $contactAutomation = current(array_filter($contactAutomations, function ($contactAutomation) use ($automation) {
            return $contactAutomation->automation == $automation->id;
        }));

        if (empty($contactAutomation)) {
            return;
        }

        $this->delete("contactAutomations/{$contactAutomation->id}");

    }

    /**
     * Removing all automations from a contact.
     *
     * @param \TestMonitor\ActiveCampaign\Resources\Contact $contact
     */
    public function removeAllAutomationsFromContact(Contact $contact)
    {
        $contactAutomations = $this->contactAutomations($contact);

        foreach ($contactAutomations as $contactAutomation) {
            $this->delete("contactAutomations/{$contactAutomation->id}");

        }
    }

    /**
     * Removing a tag from a contact.
     *
     * @param \TestMonitor\ActiveCampaign\Resources\Contact $contact
     * @param \TestMonitor\ActiveCampaign\Resources\Tag $tag
     */
    public function removeTagFromContact(Contact $contact, Tag $tag)

    {
        $contactTags = $this->contactTags($contact);

        $contactTag = current(array_filter($contactTags, function ($contactTag) use ($tag) {
            return $contactTag->tag == $tag->id;
        }));

        if (empty($contactTag)) {
            return;
        }

        $this->delete("contactTags/{$contactTag->id}");

    }

    /**
     * Determines the contact ID.
     *
     * @param Contact|int|string $contact
     */
    protected function getContactId($contact)
    {
        if ($contact instanceof Contact) {
            return $contact->id;
        } elseif (is_numeric($contact)) {
            return (int) $contact;
        } else {
            $contact = $this->findContact($contact);

            return $contact->id;
        }
    }
}


1		<?php
2
3		namespace TestMonitor\ActiveCampaign\Actions;
4
5		use TestMonitor\ActiveCampaign\Resources\Tag;
6		use TestMonitor\ActiveCampaign\Resources\Contact;
7		use TestMonitor\ActiveCampaign\Resources\Automation;
8		use TestMonitor\ActiveCampaign\Resources\ContactTag;
9		use TestMonitor\ActiveCampaign\Resources\ContactAutomation;
10
11		trait ManagesContacts
12		{
13		/**
14		* Get all contacts.
15		*
16		* @return array
17		*/
18		public function contacts()
19		{
20		return $this->transformCollection(
		0 ignored issues – show Bug introduced 2019-07-15 14:12 UTC by Report Bug Copy Issue Report It seems like `transformCollection()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
21		$this->get('contacts'),
		0 ignored issues – show Bug introduced 2019-07-15 14:12 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
22		Contact::class,
23		'contacts'
24		);
25		}
26
27		/**
28		* Find contact by email.
29		*
30		* @param string $email
31		*
32		* @return Contact\|null
33		*/
34		public function findContact($email)
35		{
36		$contacts = $this->transformCollection(
		0 ignored issues – show Bug introduced 2019-07-15 14:12 UTC by Report Bug Copy Issue Report It seems like `transformCollection()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
37		$this->get('contacts', ['query' => ['email' => $email]]),
		0 ignored issues – show Bug introduced 2019-07-15 14:12 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
38		Contact::class,
39		'contacts'
40		);
41
42		return array_shift($contacts);
43		}
44
45		/**
46		* Find contact by ID.
47		*
48		* @param int $id
49		*
50		* @return Contact\|null
51		*/
52		public function findContactById($id)
53		{
54		$contacts = $this->transformCollection(
		0 ignored issues – show Bug introduced 2019-07-15 14:12 UTC by Report Bug Copy Issue Report It seems like `transformCollection()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
55		$this->get('contacts', ['query' => ['id' => $id]]),
		0 ignored issues – show Bug introduced 2019-08-12 11:56 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
56		Contact::class,
57		'contacts'
58		);
59
60		return array_shift($contacts);
61		}
62
63		/**
64		* Create new contact.
65		*
66		* @param string $email
67		* @param string $firstName
68		* @param string $lastName
69		* @param int\|null $orgid
70		*
71		* @return Contact\|null
72		*/
73		public function createContact($email, $firstName, $lastName, $orgid = null)
74		{
75		$contacts = $this->transformCollection(
		0 ignored issues – show Bug introduced 2019-08-12 11:56 UTC by Report Bug Copy Issue Report It seems like `transformCollection()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
76		$this->post('contacts', ['json' => ['contact' => compact('email', 'firstName', 'lastName', 'orgid')]]),
		0 ignored issues – show Bug introduced 2019-07-15 14:12 UTC by Report Bug Copy Issue Report It seems like `post()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
77		Contact::class
78		);
79
80		return array_shift($contacts);
81		}
82
83		/**
84		* Find or create a contact.
85		*
86		* @param string $email
87		* @param string $firstName
88		* @param string $lastName
89		* @param int\|null $orgid
90		*
91		* @return Contact
92		*/
93		public function findOrCreateContact($email, $firstName, $lastName, $orgid = null)
94		{
95		$contact = $this->findContact($email);
96
97		if ($contact instanceof Contact) {
98		return $contact;
99		}
100
101		return $this->createContact($email, $firstName, $lastName, $orgid);
102		}
103
104		/**
105		* Updates a contact.
106		*
107		* @param Contact\|int\|string $id
108		* @param string\|null $email
109		* @param string\|null $firstName
110		* @param string\|null $lastName
111		* @param null $orgid
112		*
113		* @return Contact\|null
114		*/
115		public function updateContact($id, $email, $firstName, $lastName, $orgid = null)
116		{
117		$id = $this->getContactId($id);
118
119		$this->put('contacts/'.$id, ['json' => ['contact' => compact('email', 'firstName', 'lastName', 'orgid')]]);
		0 ignored issues – show Bug introduced 2019-08-12 12:16 UTC by Report Bug Copy Issue Report It seems like `put()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
120
121		return $this->findContactById($id);
122		}
123
124		/**
125		* Deletes a contact.
126		*
127		* @param Contact\|int\|string $contact
128		*/
129		public function deleteContact($contact)
130		{
131		$this->delete('contacts/'.$this->getContactId($contact));
		0 ignored issues – show Bug introduced 2019-08-13 13:28 UTC by Report Bug Copy Issue Report The method `delete()` does not exist on `TestMonitor\ActiveCampaign\Actions\ManagesContacts`. Did you maybe mean `deleteContact()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
132		}
133
134		/**
135		* Get all automations of a contact.
136		*
137		* @param \TestMonitor\ActiveCampaign\Resources\Contact $contact
138		*
139		* @return array
140		*/
141		public function contactAutomations(Contact $contact)
142		{
143		return $this->transformCollection(
		0 ignored issues – show Bug introduced 2019-07-15 14:12 UTC by Report Bug Copy Issue Report It seems like `transformCollection()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
144		$this->get("contacts/{$contact->id}/contactAutomations"),
		0 ignored issues – show Bug introduced 2019-07-15 14:12 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
145		ContactAutomation::class,
146		'contactAutomations'
147		);
148		}
149
150		/**
151		* Get all tags of a contact.
152		*
153		* @param \TestMonitor\ActiveCampaign\Resources\Contact $contact
154		*
155		* @return array
156		*/
157		public function contactTags(Contact $contact)
158		{
159		return $this->transformCollection(
		0 ignored issues – show Bug introduced 2019-07-15 14:12 UTC by Report Bug Copy Issue Report It seems like `transformCollection()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
160		$this->get("contacts/{$contact->id}/contactTags"),
		0 ignored issues – show Bug introduced 2019-07-15 14:12 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
161		ContactTag::class,
162		'contactTags'
163		);
164		}
165
166		/**
167		* Removing a automation from a contact.
168		*
169		* @param \TestMonitor\ActiveCampaign\Resources\Contact $contact
170		* @param \TestMonitor\ActiveCampaign\Resources\Automation $automation
171		*/
172	View Code Duplication	public function removeAutomationFromContact(Contact $contact, Automation $automation)
		0 ignored issues – show Duplication introduced 2019-07-15 14:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
173		{
174		$contactAutomations = $this->contactAutomations($contact);
175
176		$contactAutomation = current(array_filter($contactAutomations, function ($contactAutomation) use ($automation) {
177		return $contactAutomation->automation == $automation->id;
178		}));
179
180		if (empty($contactAutomation)) {
181		return;
182		}
183
184		$this->delete("contactAutomations/{$contactAutomation->id}");
		0 ignored issues – show Bug introduced 2019-08-13 13:28 UTC by Report Bug Copy Issue Report The method `delete()` does not exist on `TestMonitor\ActiveCampaign\Actions\ManagesContacts`. Did you maybe mean `deleteContact()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
185		}
186
187		/**
188		* Removing all automations from a contact.
189		*
190		* @param \TestMonitor\ActiveCampaign\Resources\Contact $contact
191		*/
192		public function removeAllAutomationsFromContact(Contact $contact)
193		{
194		$contactAutomations = $this->contactAutomations($contact);
195
196		foreach ($contactAutomations as $contactAutomation) {
197		$this->delete("contactAutomations/{$contactAutomation->id}");
		0 ignored issues – show Bug introduced 2019-08-13 13:28 UTC by Report Bug Copy Issue Report The method `delete()` does not exist on `TestMonitor\ActiveCampaign\Actions\ManagesContacts`. Did you maybe mean `deleteContact()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
198		}
199		}
200
201		/**
202		* Removing a tag from a contact.
203		*
204		* @param \TestMonitor\ActiveCampaign\Resources\Contact $contact
205		* @param \TestMonitor\ActiveCampaign\Resources\Tag $tag
206		*/
207	View Code Duplication	public function removeTagFromContact(Contact $contact, Tag $tag)
		0 ignored issues – show Duplication introduced 2019-07-15 14:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
208		{
209		$contactTags = $this->contactTags($contact);
210
211		$contactTag = current(array_filter($contactTags, function ($contactTag) use ($tag) {
212		return $contactTag->tag == $tag->id;
213		}));
214
215		if (empty($contactTag)) {
216		return;
217		}
218
219		$this->delete("contactTags/{$contactTag->id}");
		0 ignored issues – show Bug introduced 2019-08-13 13:28 UTC by Report Bug Copy Issue Report The method `delete()` does not exist on `TestMonitor\ActiveCampaign\Actions\ManagesContacts`. Did you maybe mean `deleteContact()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
220		}
221
222		/**
223		* Determines the contact ID.
224		*
225		* @param Contact\|int\|string $contact
226		*/
227		protected function getContactId($contact)
228		{
229		if ($contact instanceof Contact) {
230		return $contact->id;
231		} elseif (is_numeric($contact)) {
232		return (int) $contact;
233		} else {
234		$contact = $this->findContact($contact);
235
236		return $contact->id;
237		}
238		}
239		}
240

testmonitor / activecampaign

Pull Request — master (#17)

ManagesContacts::updateContact() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like