tesark / msg91-php

src/Sender/Traits/OtpBuildTrait.php

<?php
namespace Sender\Traits;

use Sender\Validation;
use Sender\MobileNumber;
use Sender\Otp\OtpBuildClass;
use Sender\Otp\OtpDefineClass;
use Sender\ExceptionClass\ParameterException;

/**
 * This trait for OTP FUNCTIONS
 *
 * @package    Msg91 SMS&OTP package
 * @author     VenkatS <venkatsamuthiram5@gmail.com>
 * @link       https://github.com/tesark/msg91-php
 * @license    MIT
 */

trait OtpBuildTrait
{
    /**
     * Check Authkey and mobile
     * @param string $parameter
     *
     * @throws ParameterException missing parameters or return empty
     * @return bool
     */
    public function isParameterPresent($parameter)
    {
        if ($this->isKeyExists($parameter, $this->sendData)) {

The property sendData does not exist on Sender\Traits\OtpBuildTrait. Did you maybe forget to declare it?

It seems like isKeyExists() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            if ($parameter === 'authkey') {
                return $this->hasAuthKey($parameter);

It seems like hasAuthKey() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            } else {
                return $this->hasMobile($parameter);

It seems like hasMobile() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            }
        } else {
            $message = "Parameter ".$parameter." missing";
            throw ParameterException::missinglogic($message);
        }
    }
    /**
     * Check Authkey
     *
     * @return bool
     */
    public function checkAuthKey()
    {
        return $this->isParameterPresent('authkey');
    }
    /**
     * Check mobile
     *
     * @return bool
     */
    public function checkMobile()
    {
        return $this->isParameterPresent('mobile');
    }
}