terrylinooo / shieldon

src/Firewall/Security/Xss.php

Indentation +39 added lines, -39 removed lines

@@ -35,9 +35,9 @@ 
 use function time;
 use function version_compare;
 
- /**
-  * Cross-Site Scripting protection.
-  */
+    /**
+     * Cross-Site Scripting protection.
+     */
 class Xss
 {
     /**
@@ -284,7 +284,7 @@ 
         unset($original);
 
         // Remove evil attributes such as style, onclick and xmlns
-		$str = $this->removeEvilAttributes($str, $isImage);
+        $str = $this->removeEvilAttributes($str, $isImage);
 
         /*
          * Sanitize naughty HTML elements
@@ -448,62 +448,62 @@ 
 	 * @param boolean $is_image TRUE if this is an image
 	 * @return string The string with the evil attributes removed
 	 */
-	protected function removeEvilAttributes($str, $is_image)
-	{
-		// All javascript event handlers (e.g. onload, onclick, onmouseover), style, and xmlns
-		$evilAttributes = array('on\w*', 'style', 'xmlns', 'formaction', 'form', 'xlink:href');
+    protected function removeEvilAttributes($str, $is_image)
+    {
+        // All javascript event handlers (e.g. onload, onclick, onmouseover), style, and xmlns
+        $evilAttributes = array('on\w*', 'style', 'xmlns', 'formaction', 'form', 'xlink:href');
 
-		if ($is_image) {
-			/*
+        if ($is_image) {
+            /*
 			 * Adobe Photoshop puts XML metadata into JFIF images,
 			 * including namespacing, so we have to allow this for images.
 			 */
-			unset($evilAttributes[array_search('xmlns', $evilAttributes)]);
-		}
+            unset($evilAttributes[array_search('xmlns', $evilAttributes)]);
+        }
 
-		do {
-			$count = 0;
-			$attribs = array();
+        do {
+            $count = 0;
+            $attribs = array();
 
-			// find occurrences of illegal attribute strings with quotes (042 and 047 are octal quotes)
-			preg_match_all(
+            // find occurrences of illegal attribute strings with quotes (042 and 047 are octal quotes)
+            preg_match_all(
                 '/(?<!\w)(' . implode('|', $evilAttributes) . ')\s*=\s*(\042|\047)([^\\2]*?)(\\2)/is',
                 $str,
                 $matches,
                 PREG_SET_ORDER
             );
 
-			foreach ($matches as $attr) {
-				$attribs[] = preg_quote($attr[0], '/');
-			}
+            foreach ($matches as $attr) {
+                $attribs[] = preg_quote($attr[0], '/');
+            }
 
-			// find occurrences of illegal attribute strings without quotes
-			preg_match_all(
+            // find occurrences of illegal attribute strings without quotes
+            preg_match_all(
                 '/(?<!\w)(' . implode('|', $evilAttributes) . ')\s*=\s*([^\s>]*)/is',
                 $str,
                 $matches,
                 PREG_SET_ORDER
             );
 
-			foreach ($matches as $attr) {
-				$attribs[] = preg_quote($attr[0], '/');
-			}
+            foreach ($matches as $attr) {
+                $attribs[] = preg_quote($attr[0], '/');
+            }
 
-			// replace illegal attribute strings that are inside an html tag
-			if (count($attribs) > 0) {
-				$str = preg_replace(
+            // replace illegal attribute strings that are inside an html tag
+            if (count($attribs) > 0) {
+                $str = preg_replace(
                     '/(<?)(\/?[^><]+?)([^A-Za-z<>\-])(.*?)(' . implode('|', $attribs) . ')(.*?)([\s><]?)([><]*)/i',
                     '$1$2 $4$6$7$8',
                     $str,
                     -1,
                     $count
                 );
-			}
+            }
 
-		} while ($count);
+        } while ($count);
 
-		return $str;
-	}
+        return $str;
+    }
 
     /**
      * Random Hash for protecting URLs
@@ -856,16 +856,16 @@ 
      * @return bool
      */
     protected function isPHP($version): bool
-	{
+    {
         static $_isPHP;
 
-		$version = (string) $version;
+        $version = (string) $version;
 
-		if (!isset($_isPHP[$version])) {
-			$_isPHP[$version] = version_compare(PHP_VERSION, $version, '>=');
-		}
+        if (!isset($_isPHP[$version])) {
+            $_isPHP[$version] = version_compare(PHP_VERSION, $version, '>=');
+        }
 
-		return $_isPHP[$version];
-	}
+        return $_isPHP[$version];
+    }
 }
 

Spacing +31 added lines, -31 removed lines

@@ -89,13 +89,13 @@ 
 
         $this->deniedRegexList = [
             'javascript\s*:',
-            '\bon\w+=\S+(?=.*>)',       // Inline JavaScript.
+            '\bon\w+=\S+(?=.*>)', // Inline JavaScript.
             '(document|(document\.)?window)\.(location|on\w*)',
             'expression\s*(\(|&\#40;)', // CSS and IE
-            'vbscript\s*:',             // IE, surprise!
-            'wscript\s*:',              // IE
-            'jscript\s*:',              // IE
-            'vbs\s*:',                  // IE
+            'vbscript\s*:', // IE, surprise!
+            'wscript\s*:', // IE
+            'jscript\s*:', // IE
+            'vbs\s*:', // IE
             'Redirect\s+30\d:',
             "([\"'])?data\s*:[^\\1]*?base64[^\\1]*?,[^\\1]*?\\1?",
         ];
@@ -222,9 +222,9 @@ 
          */
         $words = [
             'javascript', 'expression', 'vbscript', 'jscript', 'wscript',
-            'vbs',        'script',     'base64',   'applet',  'alert', 
-            'document',   'write',      'cookie',   'window',  'confirm',
-            'prompt',     'eval',
+            'vbs', 'script', 'base64', 'applet', 'alert', 
+            'document', 'write', 'cookie', 'window', 'confirm',
+            'prompt', 'eval',
         ];
 
         foreach ($words as $word) {
@@ -279,7 +279,7 @@ 
                 );
             }
 
-        } while($original !== $str);
+        } while ($original !== $str);
 
         unset($original);
 
@@ -581,17 +581,17 @@ 
             "'", '"', '&', '$', '#',
             '{', '}', '[', ']', '=',
             ';', '?', '%20', '%22',
-            '%3c',		// <
-            '%253c',	// <
-            '%3e',		// >
-            '%0e',		// >
-            '%28',		// (
-            '%29',		// )
-            '%2528',	// (
-            '%26',		// &
-            '%24',		// $
-            '%3f',		// ?
-            '%3b',		// ;
+            '%3c', // <
+            '%253c', // <
+            '%3e', // >
+            '%0e', // >
+            '%28', // (
+            '%29', // )
+            '%2528', // (
+            '%26', // &
+            '%24', // $
+            '%3f', // ?
+            '%3b', // ;
             '%3d'		// =
         ];
 
@@ -637,19 +637,19 @@ 
     protected function sanitizeNaughtyHtml(array $matches): string
     {
         static $naughtyTags = [
-            'alert',    'prompt', 'confirm',    'applet',  'audio',
-            'basefont', 'base',   'behavior',   'bgsound', 'blink', 
-            'body',     'embed',  'expression', 'form',    'frameset', 
-            'frame',    'head',   'html',       'ilayer',  'iframe', 
-            'input',    'button', 'select',     'isindex', 'layer', 
-            'link',     'meta',   'keygen',     'object',  'plaintext',
-            'style',    'script', 'textarea',   'title',   'math',
-            'video',    'svg',    'xml',        'xss',
+            'alert', 'prompt', 'confirm', 'applet', 'audio',
+            'basefont', 'base', 'behavior', 'bgsound', 'blink', 
+            'body', 'embed', 'expression', 'form', 'frameset', 
+            'frame', 'head', 'html', 'ilayer', 'iframe', 
+            'input', 'button', 'select', 'isindex', 'layer', 
+            'link', 'meta', 'keygen', 'object', 'plaintext',
+            'style', 'script', 'textarea', 'title', 'math',
+            'video', 'svg', 'xml', 'xss',
         ];
 
         static $evilAttributes = [
-            'on\w+', 'style',      'xmlns',     'seekSegmentTime', 
-            'form',  'xlink:href', 'FSCommand', 'formaction',
+            'on\w+', 'style', 'xmlns', 'seekSegmentTime', 
+            'form', 'xlink:href', 'FSCommand', 'formaction',
         ];
 
         // First, escape unclosed tags
@@ -706,7 +706,7 @@ 
 
             $attributes = empty($attributes)
                 ? ''
-                : ' '.implode(' ', $attributes);
+                : ' ' . implode(' ', $attributes);
             return '<' . $matches['slash'] . $matches['tagName'] . $attributes . '>';
         }
 

src/Firewall/Log/ActionLogger.php

Spacing +5 added lines, -5 removed lines

@@ -100,10 +100,10 @@ 
             $record['session_id'] = substr($record['session_id'], 0, 4);
         }
 
-        $data[0] = $record['ip']          ?? 'null';
-        $data[1] = $record['session_id']  ?? 'null';
+        $data[0] = $record['ip'] ?? 'null';
+        $data[1] = $record['session_id'] ?? 'null';
         $data[2] = $record['action_code'] ?? 'null';
-        $data[3] = $record['timesamp']    ?? 'null';
+        $data[3] = $record['timesamp'] ?? 'null';
 
         file_put_contents($this->filePath, implode(',', $data) . "\n", FILE_APPEND | LOCK_EX);
     }
@@ -247,7 +247,7 @@ 
             $it = new RecursiveDirectoryIterator($this->directory, RecursiveDirectoryIterator::SKIP_DOTS);
             $files = new RecursiveIteratorIterator($it, RecursiveIteratorIterator::CHILD_FIRST);
 
-            foreach($files as $file) {
+            foreach ($files as $file) {
                 if ($file->isDir()) {
                     // @codeCoverageIgnoreStart
                     rmdir($file->getRealPath());
@@ -277,7 +277,7 @@ 
             $it = new RecursiveDirectoryIterator($this->directory, RecursiveDirectoryIterator::SKIP_DOTS);
             $files = new RecursiveIteratorIterator($it, RecursiveIteratorIterator::CHILD_FIRST);
 
-            foreach($files as $file) {
+            foreach ($files as $file) {
                 if ($file->isFile()) {
                     $key = $file->getBasename('.log');
                     $size = $file->getSize();

src/Firewall/Log/ActionLogParser.php

Spacing +29 added lines, -29 removed lines

@@ -208,7 +208,7 @@ 
             default:
 
                 // We also accept querying N days data from logs. For example: `past_365_days`.
-                if (preg_match('/past_([0-9]+)_days/', $this->type, $matches) ) {
+                if (preg_match('/past_([0-9]+)_days/', $this->type, $matches)) {
 
                     $dayCount = $matches[1];
                     $startDate = date('Ymd', strtotime('-' . $dayCount . ' days'));
@@ -233,7 +233,7 @@ 
         // Fetch data from log files.
         $logs = $this->logger->get($startDate, $endDate);
 
-        foreach($logs as $log) {
+        foreach ($logs as $log) {
 
             $logTimesamp = (int) $log['timesamp'];
             $logIp = $log['ip'];
@@ -331,21 +331,21 @@ 
             return [];
         }
 
-        $results['captcha_chart_string']  = '';     // string
-        $results['pageview_chart_string'] = '';     // string
-        $results['captcha_success_count'] = 0;      // integer
-        $results['captcha_failure_count'] = 0;      // integer
-        $results['captcha_count'] = 0;              // integer
-        $results['pageview_count'] = 0;             // integer
-        $results['captcha_percentageage'] = 0;      // integer
+        $results['captcha_chart_string']  = ''; // string
+        $results['pageview_chart_string'] = ''; // string
+        $results['captcha_success_count'] = 0; // integer
+        $results['captcha_failure_count'] = 0; // integer
+        $results['captcha_count'] = 0; // integer
+        $results['pageview_count'] = 0; // integer
+        $results['captcha_percentageage'] = 0; // integer
         $results['captcha_failure_percentage'] = 0; // integer
         $results['captcha_success_percentage'] = 0; // integer
 
-        $results['action_ban_count'] = 0;           // integer
-        $results['action_temp_ban_count'] = 0;      // integer
-        $results['action_unban_count'] = 0;         // integer
-        $results['blacklist_count'] = 0;            // integer
-        $results['session_limit_count'] = 0;        // integer
+        $results['action_ban_count'] = 0; // integer
+        $results['action_temp_ban_count'] = 0; // integer
+        $results['action_unban_count'] = 0; // integer
+        $results['blacklist_count'] = 0; // integer
+        $results['session_limit_count'] = 0; // integer
 
         $ipdData = $this->getIpData();
 
@@ -386,22 +386,22 @@ 
     {
         $periodData = $this->getPeriodData();
 
-        $results['captcha_chart_string']  = '';     // string
-        $results['pageview_chart_string'] = '';     // string
-        $results['label_chart_string'] = '';        // string
-        $results['captcha_success_count'] = 0;      // integer
-        $results['captcha_failure_count'] = 0;      // integer
-        $results['captcha_count'] = 0;              // integer
-        $results['pageview_count'] = 0;             // integer
-        $results['captcha_percentageage'] = 0;      // integer
+        $results['captcha_chart_string']  = ''; // string
+        $results['pageview_chart_string'] = ''; // string
+        $results['label_chart_string'] = ''; // string
+        $results['captcha_success_count'] = 0; // integer
+        $results['captcha_failure_count'] = 0; // integer
+        $results['captcha_count'] = 0; // integer
+        $results['pageview_count'] = 0; // integer
+        $results['captcha_percentageage'] = 0; // integer
         $results['captcha_failure_percentage'] = 0; // integer
         $results['captcha_success_percentage'] = 0; // integer
 
-        $results['action_ban_count'] = 0;           // integer
-        $results['action_temp_ban_count'] = 0;      // integer
-        $results['action_unban_count'] = 0;         // integer
-        $results['blacklist_count'] = 0;            // integer
-        $results['session_limit_count'] = 0;        // integer
+        $results['action_ban_count'] = 0; // integer
+        $results['action_temp_ban_count'] = 0; // integer
+        $results['action_unban_count'] = 0; // integer
+        $results['blacklist_count'] = 0; // integer
+        $results['session_limit_count'] = 0; // integer
 
         if (!empty($periodData)) {
 
@@ -431,7 +431,7 @@ 
             }
 
             $results['captcha_chart_string'] = implode(',', $chartCaptcha);
-            $results['pageview_chart_string']= implode(',', $chartPageview);
+            $results['pageview_chart_string'] = implode(',', $chartPageview);
             $results['captcha_success_chart_string'] = implode(',', $chartCaptchaSuccess);
             $results['captcha_failure_chart_string'] = implode(',', $chartCaptchaFailure);
             $results['label_chart_string'] = "'" . implode("','", $labels) . "'";
@@ -461,7 +461,7 @@ 
         $ip = $log['ip'];
         $sessionId = $log['session_id'];
 
-        $this->ipDetail[$t][$ip]['session_id'][$sessionId ] = 1;
+        $this->ipDetail[$t][$ip]['session_id'][$sessionId] = 1;
 
         if ($logActionCode === self::LOG_TEMPORARILY_BAN) {
             $this->periodDetail[$t][$k]['action_temp_ban_count']++;

src/Firewall/Helpers.php

Spacing +1 added lines, -1 removed lines

@@ -167,7 +167,7 @@
         $masked = implode('.', $tmp);
 
     } else {
-        $masked =  str_repeat('*', strlen($str) - 6) . substr(str, -6);
+        $masked = str_repeat('*', strlen($str) - 6) . substr(str, -6);
     }
 
     return $masked;

src/Firewall/Panel/User.php

Spacing +1 added lines, -1 removed lines

@@ -56,7 +56,7 @@
 
             if (
                 // Default password, unencrypted.
-                $admin['user']  === $postParams['s_user'] && 
+                $admin['user'] === $postParams['s_user'] && 
                 'shieldon_pass' === $postParams['s_pass'] &&
                 'shieldon_pass' === $admin['pass']
             ) {

src/Firewall/Panel/Home.php

Spacing +4 added lines, -4 removed lines

@@ -171,11 +171,11 @@
         */
 
         $data['components'] = [
-            'Ip'         => (!empty($this->kernel->component['Ip']))         ? true : false,
+            'Ip'         => (!empty($this->kernel->component['Ip'])) ? true : false,
             'TrustedBot' => (!empty($this->kernel->component['TrustedBot'])) ? true : false,
-            'Header'     => (!empty($this->kernel->component['Header']))     ? true : false,
-            'Rdns'       => (!empty($this->kernel->component['Rdns']))       ? true : false,
-            'UserAgent'  => (!empty($this->kernel->component['UserAgent']))  ? true : false,
+            'Header'     => (!empty($this->kernel->component['Header'])) ? true : false,
+            'Rdns'       => (!empty($this->kernel->component['Rdns'])) ? true : false,
+            'UserAgent'  => (!empty($this->kernel->component['UserAgent'])) ? true : false,
         ];
 
         $reflection = new ReflectionObject($this->kernel);

src/Firewall/Panel/BaseController.php

Spacing +10 added lines, -10 removed lines

@@ -174,7 +174,7 @@ 
             define('SHIELDON_VIEW', true);
         }
 
-        $viewFilePath =  __DIR__ . '/../../../templates/' . $page . '.php';
+        $viewFilePath = __DIR__ . '/../../../templates/' . $page . '.php';
     
         if (!empty($data)) {
             extract($data);
@@ -365,7 +365,7 @@ 
                     } else {
                         if (is_numeric($postData)) {
                             $this->setConfig(str_replace('__', '.', $postKey), (int) $postData);
-                        } else  {
+                        } else {
                             $this->setConfig(str_replace('__', '.', $postKey), $postData);
                         }
                     }
@@ -395,7 +395,7 @@ 
                             (string) $db['user'],
                             (string) $db['pass']
                         );
-                    } catch(PDOException $e) {
+                    } catch (PDOException $e) {
                         $isDataDriverFailed = true;
                         $this->pushMessage('error', 
                             __(
@@ -440,7 +440,7 @@ 
                 if (class_exists('PDO')) {
                     try {
                         $pdo = new PDO('sqlite:' . $sqliteFilePath);
-                    } catch(PDOException $e) {
+                    } catch (PDOException $e) {
                         $isDataDriverFailed = true;
                         $this->pushMessage('error', $e->getMessage());
                     }
@@ -475,9 +475,9 @@ 
                         $redis = new Redis();
                         $redis->connect(
                             (string) $this->getConfig('drivers.redis.host'), 
-                            (int)    $this->getConfig('drivers.redis.port')
+                            (int) $this->getConfig('drivers.redis.port')
                         );
-                    } catch(RedisException $e) {
+                    } catch (RedisException $e) {
                         $isDataDriverFailed = true;
                         $this->pushMessage('error', $e->getMessage());
                     }
@@ -573,10 +573,10 @@ 
                 // Create default log files.
                 if (is_writable($iptablesWatchingFolder)) {
                     fopen($iptablesWatchingFolder . '/iptables_queue.log', 'w+');
-                    fopen($iptablesWatchingFolder . '/ipv4_status.log',    'w+');
-                    fopen($iptablesWatchingFolder . '/ipv6_status.log',    'w+');
-                    fopen($iptablesWatchingFolder . '/ipv4_command.log',   'w+');
-                    fopen($iptablesWatchingFolder . '/ipv6_command.log',   'w+');
+                    fopen($iptablesWatchingFolder . '/ipv4_status.log', 'w+');
+                    fopen($iptablesWatchingFolder . '/ipv6_status.log', 'w+');
+                    fopen($iptablesWatchingFolder . '/ipv4_command.log', 'w+');
+                    fopen($iptablesWatchingFolder . '/ipv6_command.log', 'w+');
                 }
             }
     

src/Firewall/Panel/Report.php

Spacing +6 added lines, -6 removed lines

@@ -42,11 +42,11 @@ 
     public function operation(): ResponseInterface
     {
         $data['components'] = [
-            'Ip'         => (!empty($this->kernel->component['Ip']))         ? true : false,
+            'Ip'         => (!empty($this->kernel->component['Ip'])) ? true : false,
             'TrustedBot' => (!empty($this->kernel->component['TrustedBot'])) ? true : false,
-            'Header'     => (!empty($this->kernel->component['Header']))     ? true : false,
-            'Rdns'       => (!empty($this->kernel->component['Rdns']))       ? true : false,
-            'UserAgent'  => (!empty($this->kernel->component['UserAgent']))  ? true : false,
+            'Header'     => (!empty($this->kernel->component['Header'])) ? true : false,
+            'Rdns'       => (!empty($this->kernel->component['Rdns'])) ? true : false,
+            'UserAgent'  => (!empty($this->kernel->component['UserAgent'])) ? true : false,
         ];
 
         $reflection = new ReflectionObject($this->kernel);
@@ -218,7 +218,7 @@ 
                 $data['period_data'] = $ipDetailsCachedData['period_data'];
                 $lastCachedTime = date('Y-m-d H:i:s', $ipDetailsCachedData['time']);
     
-                if ('today' === $type ) {
+                if ('today' === $type) {
                     $ipDetailsCachedData = $logCacheHandler->get('past_seven_hours');
                     $data['past_seven_hours'] = $ipDetailsCachedData['period_data'];
                 }
@@ -232,7 +232,7 @@ 
 
                 $logCacheHandler->save($type, $data);
     
-                if ('today' === $type ) {
+                if ('today' === $type) {
                     $this->parser->prepare('past_seven_hours');
                     $data['past_seven_hours'] = $this->parser->getParsedPeriodData();
 

templates/panel/action_log_last_month.php

Spacing +5 added lines, -5 removed lines

@@ -14,7 +14,7 @@ 
 ?>
 
 <div class="so-dashboard">
-    <?php if (! empty($period_data)) : ?>
+    <?php if (!empty($period_data)) : ?>
     <div class="so-flex">
         <div class="so-board">
             <div class="board-field left">
@@ -85,8 +85,8 @@ 
                 </tr>
             </thead>
             <tbody>
-                <?php if (! empty($ip_details)) : ?>
-                <?php foreach($ip_details as $ip => $ipInfo) : ?>
+                <?php if (!empty($ip_details)) : ?>
+                <?php foreach ($ip_details as $ip => $ipInfo) : ?>
                 <tr>
                     <td>
                         <?php if ($this->mode === 'demo') : ?>
@@ -108,7 +108,7 @@ 
         </table>
     </div>
     <div class="so-timezone">
-        <?php if (! empty($last_cached_time)) : ?>
+        <?php if (!empty($last_cached_time)) : ?>
             <?php _e('panel', 'log_label_cache_time', 'Report generated time'); ?>: <strong class="text-info"><?php echo $last_cached_time; ?></strong>
             &nbsp;&nbsp;&nbsp;&nbsp; 
         <?php endif; ?>
@@ -118,7 +118,7 @@ 
 
 <?php
 
-    if (! empty($period_data)) {
+    if (!empty($period_data)) {
         $data['period_data'] = $period_data;
         $this->_include('panel/js/chart', $data);
     }

Braces +5 added lines, -2 removed lines

@@ -60,9 +60,12 @@
                 </div>
             </div>
         </div>
-    <?php else : ?>
+    <?php else {
+    : ?>
         <div class="alert alert-danger">
-            <?php _e('panel', 'log_msg_no_logger', 'Sorry, you have to implement ActionLogger to use this function.'); ?>
+            <?php _e('panel', 'log_msg_no_logger', 'Sorry, you have to implement ActionLogger to use this function.');
+}
+?>
             
         </div>
     <?php endif; ?>