View GitHub Repository shieldon

Schedule Inspection
Subscribe
Passed
Push — 2.x ( 9f06f6...92ec38 )
by Terry
01:59
created
Status
Category
Toggle Patches
src/Firewall/Helpers.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -167,7 +167,7 @@
 
 block discarded – undo
167 167 
         $masked = implode('.', $tmp);
168 168
169 169 
     } else {
170 
-        $masked =  str_repeat('*', strlen($str) - 6) . substr(str, -6);
170 
+        $masked = str_repeat('*', strlen($str) - 6) . substr(str, -6);
171 171 
     }
172 172
173 173 
     return $masked;
Please login to merge, or discard this patch.
src/Firewall/Panel/User.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -56,7 +56,7 @@
 
 block discarded – undo
56 56
57 57 
             if (
58 58 
                 // Default password, unencrypted.
59 
-                $admin['user']  === $postParams['s_user'] &&
59 
+                $admin['user'] === $postParams['s_user'] &&
60 60 
                 'shieldon_pass' === $postParams['s_pass'] &&
61 61 
                 'shieldon_pass' === $admin['pass']
62 62 
             ) {
Please login to merge, or discard this patch.
src/Firewall/Panel/Home.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -171,11 +171,11 @@
 
 block discarded – undo
171 171 
         */
172 172
173 173 
         $data['components'] = [
174 
-            'Ip'         => (!empty($this->kernel->component['Ip']))         ? true : false,
174 
+            'Ip'         => (!empty($this->kernel->component['Ip'])) ? true : false,
175 175 
             'TrustedBot' => (!empty($this->kernel->component['TrustedBot'])) ? true : false,
176 
-            'Header'     => (!empty($this->kernel->component['Header']))     ? true : false,
177 
-            'Rdns'       => (!empty($this->kernel->component['Rdns']))       ? true : false,
178 
-            'UserAgent'  => (!empty($this->kernel->component['UserAgent']))  ? true : false,
176 
+            'Header'     => (!empty($this->kernel->component['Header'])) ? true : false,
177 
+            'Rdns'       => (!empty($this->kernel->component['Rdns'])) ? true : false,
178 
+            'UserAgent'  => (!empty($this->kernel->component['UserAgent'])) ? true : false,
179 179 
         ];
180 180
181 181 
         $reflection = new ReflectionObject($this->kernel);
Please login to merge, or discard this patch.
src/Firewall/Panel/BaseController.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch 
@@ -174,7 +174,7 @@  discard block
 
 block discarded – undo
174 174 
             define('SHIELDON_VIEW', true);
175 175 
         }
176 176
177 
-        $viewFilePath =  __DIR__ . '/../../../templates/' . $page . '.php';
177 
+        $viewFilePath = __DIR__ . '/../../../templates/' . $page . '.php';
178 178
179 179 
         if (!empty($data)) {
180 180 
             extract($data);
 
@@ -365,7 +365,7 @@  discard block
 
 block discarded – undo
365 365 
                     } else {
366 366 
                         if (is_numeric($postData)) {
367 367 
                             $this->setConfig(str_replace('__', '.', $postKey), (int) $postData);
368 
-                        } else  {
368 
+                        } else {
369 369 
                             $this->setConfig(str_replace('__', '.', $postKey), $postData);
370 370 
                         }
371 371 
                     }
 
@@ -395,7 +395,7 @@  discard block
 
 block discarded – undo
395 395 
                             (string) $db['user'],
396 396 
                             (string) $db['pass']
397 397 
                         );
398 
-                    } catch(PDOException $e) {
398 
+                    } catch (PDOException $e) {
399 399 
                         $isDataDriverFailed = true;
400 400 
                         $this->pushMessage('error',
401 401 
                             __(
 
@@ -440,7 +440,7 @@  discard block
 
 block discarded – undo
440 440 
                 if (class_exists('PDO')) {
441 441 
                     try {
442 442 
                         $pdo = new PDO('sqlite:' . $sqliteFilePath);
443 
-                    } catch(PDOException $e) {
443 
+                    } catch (PDOException $e) {
444 444 
                         $isDataDriverFailed = true;
445 445 
                         $this->pushMessage('error', $e->getMessage());
446 446 
                     }
 
@@ -475,9 +475,9 @@  discard block
 
 block discarded – undo
475 475 
                         $redis = new Redis();
476 476 
                         $redis->connect(
477 477 
                             (string) $this->getConfig('drivers.redis.host'),
478 
-                            (int)    $this->getConfig('drivers.redis.port')
478 
+                            (int) $this->getConfig('drivers.redis.port')
479 479 
                         );
480 
-                    } catch(RedisException $e) {
480 
+                    } catch (RedisException $e) {
481 481 
                         $isDataDriverFailed = true;
482 482 
                         $this->pushMessage('error', $e->getMessage());
483 483 
                     }
 
@@ -573,10 +573,10 @@  discard block
 
 block discarded – undo
573 573 
                 // Create default log files.
574 574 
                 if (is_writable($iptablesWatchingFolder)) {
575 575 
                     fopen($iptablesWatchingFolder . '/iptables_queue.log', 'w+');
576 
-                    fopen($iptablesWatchingFolder . '/ipv4_status.log',    'w+');
577 
-                    fopen($iptablesWatchingFolder . '/ipv6_status.log',    'w+');
578 
-                    fopen($iptablesWatchingFolder . '/ipv4_command.log',   'w+');
579 
-                    fopen($iptablesWatchingFolder . '/ipv6_command.log',   'w+');
576 
+                    fopen($iptablesWatchingFolder . '/ipv4_status.log', 'w+');
577 
+                    fopen($iptablesWatchingFolder . '/ipv6_status.log', 'w+');
578 
+                    fopen($iptablesWatchingFolder . '/ipv4_command.log', 'w+');
579 
+                    fopen($iptablesWatchingFolder . '/ipv6_command.log', 'w+');
580 580 
                 }
581 581 
             }
582 582
Please login to merge, or discard this patch.
src/Firewall/Panel/Report.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch 
@@ -42,11 +42,11 @@  discard block
 
 block discarded – undo
42 42 
     public function operation(): ResponseInterface
43 43 
     {
44 44 
         $data['components'] = [
45 
-            'Ip'         => (!empty($this->kernel->component['Ip']))         ? true : false,
45 
+            'Ip'         => (!empty($this->kernel->component['Ip'])) ? true : false,
46 46 
             'TrustedBot' => (!empty($this->kernel->component['TrustedBot'])) ? true : false,
47 
-            'Header'     => (!empty($this->kernel->component['Header']))     ? true : false,
48 
-            'Rdns'       => (!empty($this->kernel->component['Rdns']))       ? true : false,
49 
-            'UserAgent'  => (!empty($this->kernel->component['UserAgent']))  ? true : false,
47 
+            'Header'     => (!empty($this->kernel->component['Header'])) ? true : false,
48 
+            'Rdns'       => (!empty($this->kernel->component['Rdns'])) ? true : false,
49 
+            'UserAgent'  => (!empty($this->kernel->component['UserAgent'])) ? true : false,
50 50 
         ];
51 51
52 52 
         $reflection = new ReflectionObject($this->kernel);
 
@@ -218,7 +218,7 @@  discard block
 
 block discarded – undo
218 218 
                 $data['period_data'] = $ipDetailsCachedData['period_data'];
219 219 
                 $lastCachedTime = date('Y-m-d H:i:s', $ipDetailsCachedData['time']);
220 220
221 
-                if ('today' === $type ) {
221 
+                if ('today' === $type) {
222 222 
                     $ipDetailsCachedData = $logCacheHandler->get('past_seven_hours');
223 223 
                     $data['past_seven_hours'] = $ipDetailsCachedData['period_data'];
224 224 
                 }
 
@@ -232,7 +232,7 @@  discard block
 
 block discarded – undo
232 232
233 233 
                 $logCacheHandler->save($type, $data);
234 234
235 
-                if ('today' === $type ) {
235 
+                if ('today' === $type) {
236 236 
                     $this->parser->prepare('past_seven_hours');
237 237 
                     $data['past_seven_hours'] = $this->parser->getParsedPeriodData();
238 238
Please login to merge, or discard this patch.
templates/panel/action_log_last_month.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch 
@@ -14,7 +14,7 @@  discard block
 
 block discarded – undo
14 14 
 ?>
15 15
16 16 
 <div class="so-dashboard">
17 
-    <?php if (! empty($period_data)) : ?>
17 
+    <?php if (!empty($period_data)) : ?>
18 18 
     <div class="so-flex">
19 19 
         <div class="so-board">
20 20 
             <div class="board-field left">
 
@@ -85,8 +85,8 @@  discard block
 
 block discarded – undo
85 85 
                 </tr>
86 86 
             </thead>
87 87 
             <tbody>
88 
-                <?php if (! empty($ip_details)) : ?>
89 
-                <?php foreach($ip_details as $ip => $ipInfo) : ?>
88 
+                <?php if (!empty($ip_details)) : ?>
89 
+                <?php foreach ($ip_details as $ip => $ipInfo) : ?>
90 90 
                 <tr>
91 91 
                     <td>
92 92 
                         <?php if ($this->mode === 'demo') : ?>
 
@@ -108,7 +108,7 @@  discard block
 
 block discarded – undo
108 108 
         </table>
109 109 
     </div>
110 110 
     <div class="so-timezone">
111 
-        <?php if (! empty($last_cached_time)) : ?>
111 
+        <?php if (!empty($last_cached_time)) : ?>
112 112 
             <?php _e('panel', 'log_label_cache_time', 'Report generated time'); ?>: <strong class="text-info"><?php echo $last_cached_time; ?></strong>
113 113 
             &nbsp;&nbsp;&nbsp;&nbsp;
114 114 
         <?php endif; ?>
 
@@ -118,7 +118,7 @@  discard block
 
 block discarded – undo
118 118
119 119 
 <?php
120 120
121 
-    if (! empty($period_data)) {
121 
+    if (!empty($period_data)) {
122 122 
         $data['period_data'] = $period_data;
123 123 
         $this->_include('panel/js/chart', $data);
124 124 
     }
Please login to merge, or discard this patch.
templates/panel/action_log_this_month.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch 
@@ -14,7 +14,7 @@  discard block
 
 block discarded – undo
14 14 
 ?>
15 15
16 16 
 <div class="so-dashboard">
17 
-    <?php if (! empty($period_data)) : ?>
17 
+    <?php if (!empty($period_data)) : ?>
18 18 
     <div class="so-flex">
19 19 
         <div class="so-board">
20 20 
             <div class="board-field left">
 
@@ -85,8 +85,8 @@  discard block
 
 block discarded – undo
85 85 
                 </tr>
86 86 
             </thead>
87 87 
             <tbody>
88 
-                <?php if (! empty($ip_details)) : ?>
89 
-                <?php foreach($ip_details as $ip => $ipInfo) : ?>
88 
+                <?php if (!empty($ip_details)) : ?>
89 
+                <?php foreach ($ip_details as $ip => $ipInfo) : ?>
90 90 
                 <tr>
91 91 
                     <td>
92 92 
                         <?php if ($this->mode === 'demo') : ?>
 
@@ -108,7 +108,7 @@  discard block
 
 block discarded – undo
108 108 
         </table>
109 109 
     </div>
110 110 
     <div class="so-timezone">
111 
-        <?php if (! empty($last_cached_time)) : ?>
111 
+        <?php if (!empty($last_cached_time)) : ?>
112 112 
             <?php _e('panel', 'log_label_cache_time', 'Report generated time'); ?>: <strong class="text-info"><?php echo $last_cached_time; ?></strong>
113 113 
             &nbsp;&nbsp;&nbsp;&nbsp;
114 114 
         <?php endif; ?>
 
@@ -118,7 +118,7 @@  discard block
 
 block discarded – undo
118 118
119 119 
 <?php
120 120
121 
-    if (! empty($period_data)) {
121 
+    if (!empty($period_data)) {
122 122 
         $data['period_data'] = $period_data;
123 123 
         $this->_include('panel/js/chart', $data);
124 124 
     }
Please login to merge, or discard this patch.
templates/panel/template.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -97,7 +97,7 @@  discard block
 
 block discarded – undo
97 97 
 if (
98 98 
     isset($_SERVER['HTTP_HOST']) &&
99 99 
     strpos($_SERVER['HTTP_HOST'], 'project.lo') !== false
100 
-)  {
100 
+) {
101 101 
     // `shieldon-doc.lo` is the virtual domain that Terry is using to design CSS for Firewall Panel UI.
102 102 
     $staticSrc = 'http://shieldon-doc.lo/static';
103 103 
 }
 
@@ -331,7 +331,7 @@  discard block
 
 block discarded – undo
331 331 
             </div>
332 332 
         </div>
333 333
334 
-        <?php if (! empty($this->messages)) : ?>
334 
+        <?php if (!empty($this->messages)) : ?>
335 335 
         <div id="message-modal" class="modal fade" tabindex="-1" role="dialog">
336 336 
             <div class="modal-dialog modal-dialog-centered modal-lightbox" role="document">
337 337 
                 <div class="modal-content">
Please login to merge, or discard this patch.
templates/panel/action_log_yesterday.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch 
@@ -14,7 +14,7 @@  discard block
 
 block discarded – undo
14 14 
 ?>
15 15
16 16 
 <div class="so-dashboard">
17 
-    <?php if (! empty($period_data)) : ?>
17 
+    <?php if (!empty($period_data)) : ?>
18 18 
     <div class="so-flex">
19 19 
         <div class="so-board">
20 20 
             <div class="board-field left">
 
@@ -85,8 +85,8 @@  discard block
 
 block discarded – undo
85 85 
                 </tr>
86 86 
             </thead>
87 87 
             <tbody>
88 
-                <?php if (! empty($ip_details)) : ?>
89 
-                <?php foreach($ip_details as $ip => $ipInfo) : ?>
88 
+                <?php if (!empty($ip_details)) : ?>
89 
+                <?php foreach ($ip_details as $ip => $ipInfo) : ?>
90 90 
                 <tr>
91 91 
                     <td>
92 92 
                         <?php if ($this->mode === 'demo') : ?>
 
@@ -108,7 +108,7 @@  discard block
 
 block discarded – undo
108 108 
         </table>
109 109 
     </div>
110 110 
     <div class="so-timezone">
111 
-        <?php if (! empty($last_cached_time)) : ?>
111 
+        <?php if (!empty($last_cached_time)) : ?>
112 112 
             <?php _e('panel', 'log_label_cache_time', 'Report generated time'); ?>: <strong class="text-info"><?php echo $last_cached_time; ?></strong>
113 113 
             &nbsp;&nbsp;&nbsp;&nbsp;
114 114 
         <?php endif; ?>
 
@@ -118,7 +118,7 @@  discard block
 
 block discarded – undo
118 118
119 119 
 <?php
120 120
121 
-    if (! empty($period_data)) {
121 
+    if (!empty($period_data)) {
122 122 
         $data['period_data'] = $period_data;
123 123 
         $this->_include('panel/js/chart', $data);
124 124 
     }
Please login to merge, or discard this patch.