Inspection of "Improve code quality." - terrylinooo/shieldon - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — 2.x ( 30af3d...0e59db )

by Terry

created 2020-08-04 07:33 UTC

Status

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -30,10 +30,10 @@
 block discarded – undo
      */
     public static function get(array $setting): MessengerInterface
     {
-        $apiKey     = $setting['config']['api_key']     ?? '';
+        $apiKey     = $setting['config']['api_key'] ?? '';
         $domain     = $setting['config']['domain_name'] ?? '';
-        $sender     = $setting['config']['sender']      ?? '';
-        $recipients = $setting['config']['recipients']  ?? [];
+        $sender     = $setting['config']['sender'] ?? '';
+        $recipients = $setting['config']['recipients'] ?? [];
 
         $instance = new Mailgun($apiKey, $domain);
         $instance->setSubject(__('core', 'messenger_text_mail_subject'));

Please login to merge, or discard this patch.

src/Firewall/Firewall/Messenger/ItemRocketChat.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -29,10 +29,10 @@
 block discarded – undo
      */
     public static function get(array $setting): MessengerInterface
     {
-        $serverUrl   = $setting['config']['server_url']   ?? '';
-        $userId      = $setting['config']['user_id']      ?? '';
+        $serverUrl   = $setting['config']['server_url'] ?? '';
+        $userId      = $setting['config']['user_id'] ?? '';
         $accessToken = $setting['config']['access_token'] ?? '';
-        $channel     = $setting['config']['channel']      ?? '';
+        $channel     = $setting['config']['channel'] ?? '';
 
         return new RocketChat($accessToken, $userId, $serverUrl, $channel);
     }

Please login to merge, or discard this patch.

src/Firewall/Kernel.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -614,9 +614,9 @@
 block discarded – undo
         $this->initComponents();
 
         $processMethods = [
-            'isRuleExist',   // Stage 1 - Looking for rule table.
-            'isTrustedBot',  // Stage 2 - Detect popular search engine.
-            'isFakeRobot',   // Stage 3 - Reject fake search engine crawlers.
+            'isRuleExist', // Stage 1 - Looking for rule table.
+            'isTrustedBot', // Stage 2 - Detect popular search engine.
+            'isFakeRobot', // Stage 3 - Reject fake search engine crawlers.
             'isIpComponent', // Stage 4 - IP manager.
             'isComponents'   // Stage 5 - Check other components.
         ];

Please login to merge, or discard this patch.

templates/panel/action_log_past_seven_days.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -18,7 +18,7 @@  discard block
 block discarded – undo
 ?>
 
 <div class="so-dashboard">
-    <?php if (! empty($period_data)) : ?>
+    <?php if (!empty($period_data)) : ?>
     <div class="so-flex">
         <div class="so-board">
             <div class="board-field left">
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
                 </tr>
             </thead>
             <tbody>
-                <?php if (! empty($ip_details)) : ?>
+                <?php if (!empty($ip_details)) : ?>
                 <?php foreach ($ip_details as $ip => $ipInfo) : ?>
                 <tr>
                     <td>
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
         </table>
     </div>
     <div class="so-timezone">
-        <?php if (! empty($last_cached_time)) : ?>
+        <?php if (!empty($last_cached_time)) : ?>
             <?php _e('panel', 'log_label_cache_time', 'Report generated time'); ?>: <strong class="text-info"><?php echo $last_cached_time; ?></strong>
             &nbsp;&nbsp;&nbsp;&nbsp; 
         <?php endif; ?>
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
 
 <?php
 
-    if (! empty($period_data)) {
+    if (!empty($period_data)) {
         $data['period_data'] = $period_data;
         $this->loadViewPart('panel/js/chart', $data);
     }

Please login to merge, or discard this patch.

templates/panel/action_log_today.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -18,7 +18,7 @@  discard block
 block discarded – undo
 ?>
 
 <div class="so-dashboard">
-    <?php if (! empty($period_data)) : ?>
+    <?php if (!empty($period_data)) : ?>
     <div class="so-flex">
         <div class="so-board">
             <div class="board-field left">
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
                 </tr>
             </thead>
             <tbody>
-                <?php if (! empty($ip_details)) : ?>
+                <?php if (!empty($ip_details)) : ?>
                 <?php foreach ($ip_details as $ip => $ipInfo) : ?>
                 <tr>
                     <td>
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
         </table>
     </div>
     <div class="so-timezone">
-        <?php if (! empty($last_cached_time)) : ?>
+        <?php if (!empty($last_cached_time)) : ?>
             <?php _e('panel', 'log_label_cache_time', 'Report generated time'); ?>: <strong class="text-info"><?php echo $last_cached_time; ?></strong>
             &nbsp;&nbsp;&nbsp;&nbsp; 
         <?php endif; ?>
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
 
 <?php
 
-    if (! empty($period_data)) {
+    if (!empty($period_data)) {
         $data['period_data'] = $period_data;
         $data['past_seven_hours'] = $past_seven_hours;
         $this->loadViewPart('panel/js/chart', $data);

Please login to merge, or discard this patch.

templates/panel/action_log_this_month.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -18,7 +18,7 @@  discard block
 block discarded – undo
 ?>
 
 <div class="so-dashboard">
-    <?php if (! empty($period_data)) : ?>
+    <?php if (!empty($period_data)) : ?>
     <div class="so-flex">
         <div class="so-board">
             <div class="board-field left">
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
                 </tr>
             </thead>
             <tbody>
-                <?php if (! empty($ip_details)) : ?>
+                <?php if (!empty($ip_details)) : ?>
                 <?php foreach ($ip_details as $ip => $ipInfo) : ?>
                 <tr>
                     <td>
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
         </table>
     </div>
     <div class="so-timezone">
-        <?php if (! empty($last_cached_time)) : ?>
+        <?php if (!empty($last_cached_time)) : ?>
             <?php _e('panel', 'log_label_cache_time', 'Report generated time'); ?>: <strong class="text-info"><?php echo $last_cached_time; ?></strong>
             &nbsp;&nbsp;&nbsp;&nbsp; 
         <?php endif; ?>
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
 
 <?php
 
-    if (! empty($period_data)) {
+    if (!empty($period_data)) {
         $data['period_data'] = $period_data;
         $this->loadViewPart('panel/js/chart', $data);
     }

Please login to merge, or discard this patch.

templates/panel/action_log_last_month.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -18,7 +18,7 @@  discard block
 block discarded – undo
 ?>
 
 <div class="so-dashboard">
-    <?php if (! empty($period_data)) : ?>
+    <?php if (!empty($period_data)) : ?>
     <div class="so-flex">
         <div class="so-board">
             <div class="board-field left">
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
                 </tr>
             </thead>
             <tbody>
-                <?php if (! empty($ip_details)) : ?>
+                <?php if (!empty($ip_details)) : ?>
                 <?php foreach ($ip_details as $ip => $ipInfo) : ?>
                 <tr>
                     <td>
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
         </table>
     </div>
     <div class="so-timezone">
-        <?php if (! empty($last_cached_time)) : ?>
+        <?php if (!empty($last_cached_time)) : ?>
             <?php _e('panel', 'log_label_cache_time', 'Report generated time'); ?>: <strong class="text-info"><?php echo $last_cached_time; ?></strong>
             &nbsp;&nbsp;&nbsp;&nbsp; 
         <?php endif; ?>
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
 
 <?php
 
-    if (! empty($period_data)) {
+    if (!empty($period_data)) {
         $data['period_data'] = $period_data;
         $this->loadViewPart('panel/js/chart', $data);
     }

Please login to merge, or discard this patch.

templates/panel/action_log_yesterday.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -18,7 +18,7 @@  discard block
 block discarded – undo
 ?>
 
 <div class="so-dashboard">
-    <?php if (! empty($period_data)) : ?>
+    <?php if (!empty($period_data)) : ?>
     <div class="so-flex">
         <div class="so-board">
             <div class="board-field left">
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
                 </tr>
             </thead>
             <tbody>
-                <?php if (! empty($ip_details)) : ?>
+                <?php if (!empty($ip_details)) : ?>
                 <?php foreach ($ip_details as $ip => $ipInfo) : ?>
                 <tr>
                     <td>
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
         </table>
     </div>
     <div class="so-timezone">
-        <?php if (! empty($last_cached_time)) : ?>
+        <?php if (!empty($last_cached_time)) : ?>
             <?php _e('panel', 'log_label_cache_time', 'Report generated time'); ?>: <strong class="text-info"><?php echo $last_cached_time; ?></strong>
             &nbsp;&nbsp;&nbsp;&nbsp; 
         <?php endif; ?>
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
 
 <?php
 
-    if (! empty($period_data)) {
+    if (!empty($period_data)) {
         $data['period_data'] = $period_data;
         $this->loadViewPart('panel/js/chart', $data);
     }

Please login to merge, or discard this patch.

src/Firewall/Firewall/Captcha/CaptchaFactory.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -79,7 +79,7 @@
 block discarded – undo
         $str = implode(
             '',
             array_map(
-                function ($word) {
+                function($word) {
                     return ucwords($word); 
                 },
                 $str

Please login to merge, or discard this patch.

		@@ -614,9 +614,9 @@
		block discarded – undo
614	614	$this->initComponents();
615	615
616	616	$processMethods = [
617		- 'isRuleExist', // Stage 1 - Looking for rule table.
618		- 'isTrustedBot', // Stage 2 - Detect popular search engine.
619		- 'isFakeRobot', // Stage 3 - Reject fake search engine crawlers.
	617	+ 'isRuleExist', // Stage 1 - Looking for rule table.
	618	+ 'isTrustedBot', // Stage 2 - Detect popular search engine.
	619	+ 'isFakeRobot', // Stage 3 - Reject fake search engine crawlers.
620	620	'isIpComponent', // Stage 4 - IP manager.
621	621	'isComponents' // Stage 5 - Check other components.
622	622	];

		@@ -30,10 +30,10 @@
		block discarded – undo
30	30	*/
31	31	public static function get(array $setting): MessengerInterface
32	32	{
33		- $apiKey = $setting['config']['api_key'] ?? '';
	33	+ $apiKey = $setting['config']['api_key'] ?? '';
34	34	$domain = $setting['config']['domain_name'] ?? '';
35		- $sender = $setting['config']['sender'] ?? '';
36		- $recipients = $setting['config']['recipients'] ?? [];
	35	+ $sender = $setting['config']['sender'] ?? '';
	36	+ $recipients = $setting['config']['recipients'] ?? [];
37	37
38	38	$instance = new Mailgun($apiKey, $domain);
39	39	$instance->setSubject(__('core', 'messenger_text_mail_subject'));

		@@ -29,10 +29,10 @@
		block discarded – undo
29	29	*/
30	30	public static function get(array $setting): MessengerInterface
31	31	{
32		- $serverUrl = $setting['config']['server_url'] ?? '';
33		- $userId = $setting['config']['user_id'] ?? '';
	32	+ $serverUrl = $setting['config']['server_url'] ?? '';
	33	+ $userId = $setting['config']['user_id'] ?? '';
34	34	$accessToken = $setting['config']['access_token'] ?? '';
35		- $channel = $setting['config']['channel'] ?? '';
	35	+ $channel = $setting['config']['channel'] ?? '';
36	36
37	37	return new RocketChat($accessToken, $userId, $serverUrl, $channel);
38	38	}

		@@ -18,7 +18,7 @@ discard block
		block discarded – undo
18	18	?>
19	19
20	20	<div class="so-dashboard">
21		- <?php if (! empty($period_data)) : ?>
	21	+ <?php if (!empty($period_data)) : ?>
22	22	<div class="so-flex">
23	23	<div class="so-board">
24	24	<div class="board-field left">
		@@ -89,7 +89,7 @@ discard block
		block discarded – undo
89	89	</tr>
90	90	</thead>
91	91	<tbody>
92		- <?php if (! empty($ip_details)) : ?>
	92	+ <?php if (!empty($ip_details)) : ?>
93	93	<?php foreach ($ip_details as $ip => $ipInfo) : ?>
94	94	<tr>
95	95	<td>
		@@ -112,7 +112,7 @@ discard block
		block discarded – undo
112	112	</table>
113	113	</div>
114	114	<div class="so-timezone">
115		- <?php if (! empty($last_cached_time)) : ?>
	115	+ <?php if (!empty($last_cached_time)) : ?>
116	116	<?php _e('panel', 'log_label_cache_time', 'Report generated time'); ?>: <strong class="text-info"><?php echo $last_cached_time; ?></strong>
117	117
118	118	<?php endif; ?>
		@@ -122,7 +122,7 @@ discard block
		block discarded – undo
122	122
123	123	<?php
124	124
125		- if (! empty($period_data)) {
	125	+ if (!empty($period_data)) {
126	126	$data['period_data'] = $period_data;
127	127	$this->loadViewPart('panel/js/chart', $data);
128	128	}

		@@ -79,7 +79,7 @@
		block discarded – undo
79	79	$str = implode(
80	80	'',
81	81	array_map(
82		- function ($word) {
	82	+ function($word) {
83	83	return ucwords($word);
84	84	},
85	85	$str

terrylinooo / shieldon

Push — 2.x ( 30af3d...0e59db )

Status

Category

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch