Passed
Push — 2.x ( 077994...b17bf1 )
by Terry
01:51
created
src/Firewall/Middleware/UserAgent.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -40,19 +40,19 @@  discard block
 block discarded – undo
40 40
     protected $deniedList = [
41 41
 
42 42
         // Backlink crawlers
43
-        'Ahrefs',     // http://ahrefs.com/robot/
44
-        'roger',      // rogerbot (SEOMOZ)
45
-        'moz.com',    // SEOMOZ crawlers
46
-        'MJ12bot',    // Majestic crawlers
47
-        'findlinks',  // http://wortschatz.uni-leipzig.de/findlinks
48
-        'Semrush',    // http://www.semrush.com/bot.html
43
+        'Ahrefs', // http://ahrefs.com/robot/
44
+        'roger', // rogerbot (SEOMOZ)
45
+        'moz.com', // SEOMOZ crawlers
46
+        'MJ12bot', // Majestic crawlers
47
+        'findlinks', // http://wortschatz.uni-leipzig.de/findlinks
48
+        'Semrush', // http://www.semrush.com/bot.html
49 49
 
50 50
         // Web information crawlers
51
-        'domain',     // Domain name information crawlers.
52
-        'copyright',  // Copyright information crawlers.
51
+        'domain', // Domain name information crawlers.
52
+        'copyright', // Copyright information crawlers.
53 53
 
54 54
         // Others
55
-        'archive',    // Wayback machine
55
+        'archive', // Wayback machine
56 56
     ];
57 57
 
58 58
     /**
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
     public function __construct(array $deniedList = [])
66 66
     {
67 67
         if (!empty($deniedList)) {
68
-            $this->deniedList =$deniedList;
68
+            $this->deniedList = $deniedList;
69 69
         }
70 70
     }
71 71
 
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
         }
87 87
 
88 88
         if (!empty($this->deniedList)) {
89
-            if (preg_match('/(' . implode('|', $this->deniedList). ')/i', $userAgent)) {
89
+            if (preg_match('/(' . implode('|', $this->deniedList) . ')/i', $userAgent)) {
90 90
                 return (new Response)->withStatus(self::HTTP_STATUS_CODE);
91 91
             }
92 92
         }
Please login to merge, or discard this patch.
src/Firewall/Middleware/Header.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
     public function __construct(array $fieldList = [])
52 52
     {
53 53
         if (!empty($fieldList)) {
54
-            $this->fieldList =$fieldList;
54
+            $this->fieldList = $fieldList;
55 55
         }
56 56
     }
57 57
 
Please login to merge, or discard this patch.
src/Firewall/Firewall.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
                     $this->kernel->add(new Driver\RedisDriver($redis));
270 270
 
271 271
                 // @codeCoverageIgnoreStart
272
-                } catch(RedisException $e) {
272
+                } catch (RedisException $e) {
273 273
                     $this->status = false;
274 274
 
275 275
                     echo $e->getMessage();
@@ -312,7 +312,7 @@  discard block
 block discarded – undo
312 312
                     $this->kernel->add(new Driver\SqliteDriver($pdoInstance));
313 313
     
314 314
                 // @codeCoverageIgnoreStart
315
-                } catch(PDOException $e) {
315
+                } catch (PDOException $e) {
316 316
                     $this->status = false;
317 317
 
318 318
                     echo $e->getMessage();
@@ -331,7 +331,7 @@  discard block
 block discarded – undo
331 331
                     // Create a PDO instance.
332 332
                     $pdoInstance = new PDO(
333 333
                         'mysql:host=' 
334
-                            . $mysqlSetting['host']   . ';dbname=' 
334
+                            . $mysqlSetting['host'] . ';dbname=' 
335 335
                             . $mysqlSetting['dbname'] . ';charset=' 
336 336
                             . $mysqlSetting['charset']
337 337
                         , (string) $mysqlSetting['user']
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
342 342
                     $this->kernel->add(new Driver\MysqlDriver($pdoInstance));
343 343
 
344 344
                 // @codeCoverageIgnoreStart
345
-                } catch(PDOException $e) {
345
+                } catch (PDOException $e) {
346 346
                     echo $e->getMessage();
347 347
                 }
348 348
                 // @codeCoverageIgnoreEnd
@@ -804,7 +804,7 @@  discard block
 block discarded – undo
804 804
     protected function setIptablesWatchingFolder(): void
805 805
     {
806 806
         $iptablesSetting = $this->getOption('config', 'iptables');
807
-        $this->kernel->setProperty('iptables_watching_folder',  $iptablesSetting['watching_folder']);
807
+        $this->kernel->setProperty('iptables_watching_folder', $iptablesSetting['watching_folder']);
808 808
     }
809 809
 
810 810
     /**
@@ -841,7 +841,7 @@  discard block
 block discarded – undo
841 841
 
842 842
             $lastResetTime = $cronjobSetting['config']['last_update'];
843 843
 
844
-            if (!empty($lastResetTime) ) {
844
+            if (!empty($lastResetTime)) {
845 845
                 $lastResetTime = strtotime($lastResetTime);
846 846
             } else {
847 847
                 // @codeCoverageIgnoreStart
@@ -984,7 +984,7 @@  discard block
 block discarded – undo
984 984
         if (!empty($ipList)) {
985 985
             foreach ($ipList as $ip) {
986 986
 
987
-                if (0 === strpos($this->kernel->getCurrentUrl(), $ip['url']) ) {
987
+                if (0 === strpos($this->kernel->getCurrentUrl(), $ip['url'])) {
988 988
     
989 989
                     if ('allow' === $ip['rule']) {
990 990
                         $allowedList[] = $ip['ip'];
Please login to merge, or discard this patch.
src/Firewall/IpTrait.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -53,8 +53,8 @@
 block discarded – undo
53 53
 
54 54
             // Check if your IP is from localhost, perhaps your are in development environment?
55 55
             if (
56
-                (substr($this->ip, 0 , 8) === '192.168.') ||
57
-                (substr($this->ip, 0 , 6) === '127.0.')
56
+                (substr($this->ip, 0, 8) === '192.168.') ||
57
+                (substr($this->ip, 0, 6) === '127.0.')
58 58
             ) {
59 59
                 $this->setRdns('localhost');
60 60
             } else {
Please login to merge, or discard this patch.
src/Firewall/Utils/Collection.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@
 block discarded – undo
33 33
      */
34 34
     public function __construct(array &$data = [])
35 35
     {
36
-        $this->data =& $data;
36
+        $this->data = & $data;
37 37
     }
38 38
 
39 39
     /**
Please login to merge, or discard this patch.
src/Firewall/Security/Xss.php 1 patch
Spacing   +31 added lines, -31 removed lines patch added patch discarded remove patch
@@ -89,13 +89,13 @@  discard block
 block discarded – undo
89 89
 
90 90
         $this->deniedRegexList = [
91 91
             'javascript\s*:',
92
-            '\bon\w+=\S+(?=.*>)',       // Inline JavaScript.
92
+            '\bon\w+=\S+(?=.*>)', // Inline JavaScript.
93 93
             '(document|(document\.)?window)\.(location|on\w*)',
94 94
             'expression\s*(\(|&\#40;)', // CSS and IE
95
-            'vbscript\s*:',             // IE, surprise!
96
-            'wscript\s*:',              // IE
97
-            'jscript\s*:',              // IE
98
-            'vbs\s*:',                  // IE
95
+            'vbscript\s*:', // IE, surprise!
96
+            'wscript\s*:', // IE
97
+            'jscript\s*:', // IE
98
+            'vbs\s*:', // IE
99 99
             'Redirect\s+30\d:',
100 100
             "([\"'])?data\s*:[^\\1]*?base64[^\\1]*?,[^\\1]*?\\1?",
101 101
         ];
@@ -222,9 +222,9 @@  discard block
 block discarded – undo
222 222
          */
223 223
         $words = [
224 224
             'javascript', 'expression', 'vbscript', 'jscript', 'wscript',
225
-            'vbs',        'script',     'base64',   'applet',  'alert', 
226
-            'document',   'write',      'cookie',   'window',  'confirm',
227
-            'prompt',     'eval',
225
+            'vbs', 'script', 'base64', 'applet', 'alert', 
226
+            'document', 'write', 'cookie', 'window', 'confirm',
227
+            'prompt', 'eval',
228 228
         ];
229 229
 
230 230
         foreach ($words as $word) {
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
                 );
280 280
             }
281 281
 
282
-        } while($original !== $str);
282
+        } while ($original !== $str);
283 283
 
284 284
         unset($original);
285 285
 
@@ -581,17 +581,17 @@  discard block
 block discarded – undo
581 581
             "'", '"', '&', '$', '#',
582 582
             '{', '}', '[', ']', '=',
583 583
             ';', '?', '%20', '%22',
584
-            '%3c',		// <
585
-            '%253c',	// <
586
-            '%3e',		// >
587
-            '%0e',		// >
588
-            '%28',		// (
589
-            '%29',		// )
590
-            '%2528',	// (
591
-            '%26',		// &
592
-            '%24',		// $
593
-            '%3f',		// ?
594
-            '%3b',		// ;
584
+            '%3c', // <
585
+            '%253c', // <
586
+            '%3e', // >
587
+            '%0e', // >
588
+            '%28', // (
589
+            '%29', // )
590
+            '%2528', // (
591
+            '%26', // &
592
+            '%24', // $
593
+            '%3f', // ?
594
+            '%3b', // ;
595 595
             '%3d'		// =
596 596
         ];
597 597
 
@@ -637,19 +637,19 @@  discard block
 block discarded – undo
637 637
     protected function sanitizeNaughtyHtml(array $matches): string
638 638
     {
639 639
         static $naughtyTags = [
640
-            'alert',    'prompt', 'confirm',    'applet',  'audio',
641
-            'basefont', 'base',   'behavior',   'bgsound', 'blink', 
642
-            'body',     'embed',  'expression', 'form',    'frameset', 
643
-            'frame',    'head',   'html',       'ilayer',  'iframe', 
644
-            'input',    'button', 'select',     'isindex', 'layer', 
645
-            'link',     'meta',   'keygen',     'object',  'plaintext',
646
-            'style',    'script', 'textarea',   'title',   'math',
647
-            'video',    'svg',    'xml',        'xss',
640
+            'alert', 'prompt', 'confirm', 'applet', 'audio',
641
+            'basefont', 'base', 'behavior', 'bgsound', 'blink', 
642
+            'body', 'embed', 'expression', 'form', 'frameset', 
643
+            'frame', 'head', 'html', 'ilayer', 'iframe', 
644
+            'input', 'button', 'select', 'isindex', 'layer', 
645
+            'link', 'meta', 'keygen', 'object', 'plaintext',
646
+            'style', 'script', 'textarea', 'title', 'math',
647
+            'video', 'svg', 'xml', 'xss',
648 648
         ];
649 649
 
650 650
         static $evilAttributes = [
651
-            'on\w+', 'style',      'xmlns',     'seekSegmentTime', 
652
-            'form',  'xlink:href', 'FSCommand', 'formaction',
651
+            'on\w+', 'style', 'xmlns', 'seekSegmentTime', 
652
+            'form', 'xlink:href', 'FSCommand', 'formaction',
653 653
         ];
654 654
 
655 655
         // First, escape unclosed tags
@@ -706,7 +706,7 @@  discard block
 block discarded – undo
706 706
 
707 707
             $attributes = empty($attributes)
708 708
                 ? ''
709
-                : ' '.implode(' ', $attributes);
709
+                : ' ' . implode(' ', $attributes);
710 710
             return '<' . $matches['slash'] . $matches['tagName'] . $attributes . '>';
711 711
         }
712 712
 
Please login to merge, or discard this patch.
src/Firewall/Log/ActionLogger.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -100,10 +100,10 @@  discard block
 block discarded – undo
100 100
             $record['session_id'] = substr($record['session_id'], 0, 4);
101 101
         }
102 102
 
103
-        $data[0] = $record['ip']          ?? 'null';
104
-        $data[1] = $record['session_id']  ?? 'null';
103
+        $data[0] = $record['ip'] ?? 'null';
104
+        $data[1] = $record['session_id'] ?? 'null';
105 105
         $data[2] = $record['action_code'] ?? 'null';
106
-        $data[3] = $record['timesamp']    ?? 'null';
106
+        $data[3] = $record['timesamp'] ?? 'null';
107 107
 
108 108
         file_put_contents($this->filePath, implode(',', $data) . "\n", FILE_APPEND | LOCK_EX);
109 109
     }
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
             $it = new RecursiveDirectoryIterator($this->directory, RecursiveDirectoryIterator::SKIP_DOTS);
248 248
             $files = new RecursiveIteratorIterator($it, RecursiveIteratorIterator::CHILD_FIRST);
249 249
 
250
-            foreach($files as $file) {
250
+            foreach ($files as $file) {
251 251
                 if ($file->isDir()) {
252 252
                     // @codeCoverageIgnoreStart
253 253
                     rmdir($file->getRealPath());
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
             $it = new RecursiveDirectoryIterator($this->directory, RecursiveDirectoryIterator::SKIP_DOTS);
278 278
             $files = new RecursiveIteratorIterator($it, RecursiveIteratorIterator::CHILD_FIRST);
279 279
 
280
-            foreach($files as $file) {
280
+            foreach ($files as $file) {
281 281
                 if ($file->isFile()) {
282 282
                     $key = $file->getBasename('.log');
283 283
                     $size = $file->getSize();
Please login to merge, or discard this patch.
src/Firewall/Log/ActionLogParser.php 1 patch
Spacing   +29 added lines, -29 removed lines patch added patch discarded remove patch
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
             default:
209 209
 
210 210
                 // We also accept querying N days data from logs. For example: `past_365_days`.
211
-                if (preg_match('/past_([0-9]+)_days/', $this->type, $matches) ) {
211
+                if (preg_match('/past_([0-9]+)_days/', $this->type, $matches)) {
212 212
 
213 213
                     $dayCount = $matches[1];
214 214
                     $startDate = date('Ymd', strtotime('-' . $dayCount . ' days'));
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
         // Fetch data from log files.
234 234
         $logs = $this->logger->get($startDate, $endDate);
235 235
 
236
-        foreach($logs as $log) {
236
+        foreach ($logs as $log) {
237 237
 
238 238
             $logTimesamp = (int) $log['timesamp'];
239 239
             $logIp = $log['ip'];
@@ -331,21 +331,21 @@  discard block
 block discarded – undo
331 331
             return [];
332 332
         }
333 333
 
334
-        $results['captcha_chart_string']  = '';     // string
335
-        $results['pageview_chart_string'] = '';     // string
336
-        $results['captcha_success_count'] = 0;      // integer
337
-        $results['captcha_failure_count'] = 0;      // integer
338
-        $results['captcha_count'] = 0;              // integer
339
-        $results['pageview_count'] = 0;             // integer
340
-        $results['captcha_percentageage'] = 0;      // integer
334
+        $results['captcha_chart_string']  = ''; // string
335
+        $results['pageview_chart_string'] = ''; // string
336
+        $results['captcha_success_count'] = 0; // integer
337
+        $results['captcha_failure_count'] = 0; // integer
338
+        $results['captcha_count'] = 0; // integer
339
+        $results['pageview_count'] = 0; // integer
340
+        $results['captcha_percentageage'] = 0; // integer
341 341
         $results['captcha_failure_percentage'] = 0; // integer
342 342
         $results['captcha_success_percentage'] = 0; // integer
343 343
 
344
-        $results['action_ban_count'] = 0;           // integer
345
-        $results['action_temp_ban_count'] = 0;      // integer
346
-        $results['action_unban_count'] = 0;         // integer
347
-        $results['blacklist_count'] = 0;            // integer
348
-        $results['session_limit_count'] = 0;        // integer
344
+        $results['action_ban_count'] = 0; // integer
345
+        $results['action_temp_ban_count'] = 0; // integer
346
+        $results['action_unban_count'] = 0; // integer
347
+        $results['blacklist_count'] = 0; // integer
348
+        $results['session_limit_count'] = 0; // integer
349 349
 
350 350
         $ipdData = $this->getIpData();
351 351
 
@@ -386,22 +386,22 @@  discard block
 block discarded – undo
386 386
     {
387 387
         $periodData = $this->getPeriodData();
388 388
 
389
-        $results['captcha_chart_string']  = '';     // string
390
-        $results['pageview_chart_string'] = '';     // string
391
-        $results['label_chart_string'] = '';        // string
392
-        $results['captcha_success_count'] = 0;      // integer
393
-        $results['captcha_failure_count'] = 0;      // integer
394
-        $results['captcha_count'] = 0;              // integer
395
-        $results['pageview_count'] = 0;             // integer
396
-        $results['captcha_percentageage'] = 0;      // integer
389
+        $results['captcha_chart_string']  = ''; // string
390
+        $results['pageview_chart_string'] = ''; // string
391
+        $results['label_chart_string'] = ''; // string
392
+        $results['captcha_success_count'] = 0; // integer
393
+        $results['captcha_failure_count'] = 0; // integer
394
+        $results['captcha_count'] = 0; // integer
395
+        $results['pageview_count'] = 0; // integer
396
+        $results['captcha_percentageage'] = 0; // integer
397 397
         $results['captcha_failure_percentage'] = 0; // integer
398 398
         $results['captcha_success_percentage'] = 0; // integer
399 399
 
400
-        $results['action_ban_count'] = 0;           // integer
401
-        $results['action_temp_ban_count'] = 0;      // integer
402
-        $results['action_unban_count'] = 0;         // integer
403
-        $results['blacklist_count'] = 0;            // integer
404
-        $results['session_limit_count'] = 0;        // integer
400
+        $results['action_ban_count'] = 0; // integer
401
+        $results['action_temp_ban_count'] = 0; // integer
402
+        $results['action_unban_count'] = 0; // integer
403
+        $results['blacklist_count'] = 0; // integer
404
+        $results['session_limit_count'] = 0; // integer
405 405
 
406 406
         if (!empty($periodData)) {
407 407
 
@@ -431,7 +431,7 @@  discard block
 block discarded – undo
431 431
             }
432 432
 
433 433
             $results['captcha_chart_string'] = implode(',', $chartCaptcha);
434
-            $results['pageview_chart_string']= implode(',', $chartPageview);
434
+            $results['pageview_chart_string'] = implode(',', $chartPageview);
435 435
             $results['captcha_success_chart_string'] = implode(',', $chartCaptchaSuccess);
436 436
             $results['captcha_failure_chart_string'] = implode(',', $chartCaptchaFailure);
437 437
             $results['label_chart_string'] = "'" . implode("','", $labels) . "'";
@@ -461,7 +461,7 @@  discard block
 block discarded – undo
461 461
         $ip = $log['ip'];
462 462
         $sessionId = $log['session_id'];
463 463
 
464
-        $this->ipDetail[$t][$ip]['session_id'][$sessionId ] = 1;
464
+        $this->ipDetail[$t][$ip]['session_id'][$sessionId] = 1;
465 465
 
466 466
         if ($logActionCode === self::LOG_TEMPORARILY_BAN) {
467 467
             $this->periodDetail[$t][$k]['action_temp_ban_count']++;
Please login to merge, or discard this patch.
src/Firewall/Helpers.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -167,7 +167,7 @@
 block discarded – undo
167 167
         $masked = implode('.', $tmp);
168 168
 
169 169
     } else {
170
-        $masked =  str_repeat('*', strlen($str) - 6) . substr(str, -6);
170
+        $masked = str_repeat('*', strlen($str) - 6) . substr(str, -6);
171 171
     }
172 172
 
173 173
     return $masked;
Please login to merge, or discard this patch.