Inspection of "Update tests." - terrylinooo/shieldon - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — 1.x (bc5d7e)

by Terry

created 2020-07-15 19:03 UTC

Braces +54 added lines, -18 removed lines patch added patch discarded remove patch

@@ -322,8 +322,12 @@  discard block
 block discarded – undo
                 break;
         }
 
-        if (isset($_GET)) unset($_GET);
-        if (isset($_POST)) unset($_POST);
+        if (isset($_GET)) {
+            unset($_GET);
+        }
+        if (isset($_POST)) {
+            unset($_POST);
+        }
     }
 
     /**
@@ -912,10 +916,18 @@  discard block
 block discarded – undo
                 $this->setConfig('ip_manager', $ipList);
             }
 
-            if (isset($_POST['url']))    unset($_POST['url']);
-            if (isset($_POST['ip']))     unset($_POST['ip']);
-            if (isset($_POST['action'])) unset($_POST['action']);
-            if (isset($_POST['order']))  unset($_POST['order']);
+            if (isset($_POST['url'])) {
+                unset($_POST['url']);
+            }
+            if (isset($_POST['ip'])) {
+                unset($_POST['ip']);
+            }
+            if (isset($_POST['action'])) {
+                unset($_POST['action']);
+            }
+            if (isset($_POST['order'])) {
+                unset($_POST['order']);
+            }
 
             $this->saveConfig();
         }
@@ -953,9 +965,15 @@  discard block
 block discarded – undo
 
             $this->setConfig('excluded_urls', $excludedUrls);
 
-            if (isset($_POST['url']))    unset($_POST['url']);
-            if (isset($_POST['action'])) unset($_POST['action']);
-            if (isset($_POST['order']))  unset($_POST['order']);
+            if (isset($_POST['url'])) {
+                unset($_POST['url']);
+            }
+            if (isset($_POST['action'])) {
+                unset($_POST['action']);
+            }
+            if (isset($_POST['order'])) {
+                unset($_POST['order']);
+            }
 
             $this->saveConfig();
         }
@@ -996,11 +1014,21 @@  discard block
 block discarded – undo
 
             $this->setConfig('www_authenticate', $authenticatedList);
 
-            if (isset($_POST['url']))    unset($_POST['url']);
-            if (isset($_POST['user']))   unset($_POST['user']);
-            if (isset($_POST['pass']))   unset($_POST['pass']);
-            if (isset($_POST['action'])) unset($_POST['action']);
-            if (isset($_POST['order']))  unset($_POST['order']);
+            if (isset($_POST['url'])) {
+                unset($_POST['url']);
+            }
+            if (isset($_POST['user'])) {
+                unset($_POST['user']);
+            }
+            if (isset($_POST['pass'])) {
+                unset($_POST['pass']);
+            }
+            if (isset($_POST['action'])) {
+                unset($_POST['action']);
+            }
+            if (isset($_POST['order'])) {
+                unset($_POST['order']);
+            }
 
             $this->saveConfig();
         }
@@ -1058,10 +1086,18 @@  discard block
 block discarded – undo
 
             $this->setConfig('xss_protected_list', $xssProtectedList);
 
-            if (isset($_POST['type']))     unset($_POST['type']);
-            if (isset($_POST['variable'])) unset($_POST['variable']);
-            if (isset($_POST['action']))   unset($_POST['action']);
-            if (isset($_POST['order']))    unset($_POST['order']);
+            if (isset($_POST['type'])) {
+                unset($_POST['type']);
+            }
+            if (isset($_POST['variable'])) {
+                unset($_POST['variable']);
+            }
+            if (isset($_POST['action'])) {
+                unset($_POST['action']);
+            }
+            if (isset($_POST['order'])) {
+                unset($_POST['order']);
+            }
 
             $this->saveConfig();
         }

Please login to merge, or discard this patch.

templates/panel/action_log_last_month.php 1 patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

@@ -60,9 +60,12 @@
 block discarded – undo
                 </div>
             </div>
         </div>
-    <?php else : ?>
+    <?php else {
+    : ?>
         <div class="alert alert-danger">
-            <?php _e('panel', 'log_msg_no_logger', 'Sorry, you have to implement ActionLogger to use this function.'); ?>
+            <?php _e('panel', 'log_msg_no_logger', 'Sorry, you have to implement ActionLogger to use this function.');
+}
+?>
             
         </div>
     <?php endif; ?>

Please login to merge, or discard this patch.

templates/panel/exclusion.php 1 patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

@@ -62,7 +62,8 @@  discard block
 block discarded – undo
             </tbdoy>
         </table>
     </div>
-    <?php else: ?>
+    <?php else {
+    : ?>
     <div id="so-table-loading" class="so-datatables">
         <div class="lds-css ng-scope">
             <div class="lds-ripple">
@@ -71,7 +72,9 @@  discard block
 block discarded – undo
             </div>
         </div>
     </div>
-    <?php endif; ?>
+    <?php endif;
+}
+?>
     <div id="so-table-container" class="so-datatables" style="display: none;">
         <table id="so-datalog" class="cell-border compact stripe responsive" cellspacing="0" width="100%">
             <thead>

Please login to merge, or discard this patch.

templates/panel/action_log_this_month.php 1 patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

@@ -60,9 +60,12 @@
 block discarded – undo
                 </div>
             </div>
         </div>
-    <?php else : ?>
+    <?php else {
+    : ?>
         <div class="alert alert-danger">
-            <?php _e('panel', 'log_msg_no_logger', 'Sorry, you have to implement ActionLogger to use this function.'); ?>
+            <?php _e('panel', 'log_msg_no_logger', 'Sorry, you have to implement ActionLogger to use this function.');
+}
+?>
             
         </div>
     <?php endif; ?>

Please login to merge, or discard this patch.

templates/panel/action_log_today.php 1 patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

@@ -60,9 +60,12 @@
 block discarded – undo
                 </div>
             </div>
         </div>
-    <?php else : ?>
+    <?php else {
+    : ?>
         <div class="alert alert-danger">
-            <?php _e('panel', 'log_msg_no_logger', 'Sorry, you have to implement ActionLogger to use this function.'); ?>
+            <?php _e('panel', 'log_msg_no_logger', 'Sorry, you have to implement ActionLogger to use this function.');
+}
+?>
             
         </div>
     <?php endif; ?>

Please login to merge, or discard this patch.

templates/panel/action_log_yesterday.php 1 patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

@@ -60,9 +60,12 @@
 block discarded – undo
                 </div>
             </div>
         </div>
-    <?php else : ?>
+    <?php else {
+    : ?>
         <div class="alert alert-danger">
-            <?php _e('panel', 'log_msg_no_logger', 'Sorry, you have to implement ActionLogger to use this function.'); ?>
+            <?php _e('panel', 'log_msg_no_logger', 'Sorry, you have to implement ActionLogger to use this function.');
+}
+?>
             
         </div>
     <?php endif; ?>

Please login to merge, or discard this patch.

templates/panel/xss_protection.php 1 patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

@@ -62,7 +62,8 @@  discard block
 block discarded – undo
             </tbdoy>
         </table>
     </div>
-    <?php else: ?>
+    <?php else {
+    : ?>
     <div id="so-table-loading" class="so-datatables">
         <div class="lds-css ng-scope">
             <div class="lds-ripple">
@@ -71,7 +72,9 @@  discard block
 block discarded – undo
             </div>
         </div>
     </div>
-    <?php endif; ?>
+    <?php endif;
+}
+?>
     <div id="so-table-container" class="so-datatables" style="display: none;">
         <table id="so-datalog" class="cell-border compact stripe responsive" cellspacing="0" width="100%">
             <thead>

Please login to merge, or discard this patch.

		@@ -322,8 +322,12 @@ discard block
		block discarded – undo
322	322	break;
323	323	}
324	324
325		- if (isset($_GET)) unset($_GET);
326		- if (isset($_POST)) unset($_POST);
	325	+ if (isset($_GET)) {
	326	+ unset($_GET);
	327	+ }
	328	+ if (isset($_POST)) {
	329	+ unset($_POST);
	330	+ }
327	331	}
328	332
329	333	/**
		@@ -912,10 +916,18 @@ discard block
		block discarded – undo
912	916	$this->setConfig('ip_manager', $ipList);
913	917	}
914	918
915		- if (isset($_POST['url'])) unset($_POST['url']);
916		- if (isset($_POST['ip'])) unset($_POST['ip']);
917		- if (isset($_POST['action'])) unset($_POST['action']);
918		- if (isset($_POST['order'])) unset($_POST['order']);
	919	+ if (isset($_POST['url'])) {
	920	+ unset($_POST['url']);
	921	+ }
	922	+ if (isset($_POST['ip'])) {
	923	+ unset($_POST['ip']);
	924	+ }
	925	+ if (isset($_POST['action'])) {
	926	+ unset($_POST['action']);
	927	+ }
	928	+ if (isset($_POST['order'])) {
	929	+ unset($_POST['order']);
	930	+ }
919	931
920	932	$this->saveConfig();
921	933	}
		@@ -953,9 +965,15 @@ discard block
		block discarded – undo
953	965
954	966	$this->setConfig('excluded_urls', $excludedUrls);
955	967
956		- if (isset($_POST['url'])) unset($_POST['url']);
957		- if (isset($_POST['action'])) unset($_POST['action']);
958		- if (isset($_POST['order'])) unset($_POST['order']);
	968	+ if (isset($_POST['url'])) {
	969	+ unset($_POST['url']);
	970	+ }
	971	+ if (isset($_POST['action'])) {
	972	+ unset($_POST['action']);
	973	+ }
	974	+ if (isset($_POST['order'])) {
	975	+ unset($_POST['order']);
	976	+ }
959	977
960	978	$this->saveConfig();
961	979	}
		@@ -996,11 +1014,21 @@ discard block
		block discarded – undo
996	1014
997	1015	$this->setConfig('www_authenticate', $authenticatedList);
998	1016
999		- if (isset($_POST['url'])) unset($_POST['url']);
1000		- if (isset($_POST['user'])) unset($_POST['user']);
1001		- if (isset($_POST['pass'])) unset($_POST['pass']);
1002		- if (isset($_POST['action'])) unset($_POST['action']);
1003		- if (isset($_POST['order'])) unset($_POST['order']);
	1017	+ if (isset($_POST['url'])) {
	1018	+ unset($_POST['url']);
	1019	+ }
	1020	+ if (isset($_POST['user'])) {
	1021	+ unset($_POST['user']);
	1022	+ }
	1023	+ if (isset($_POST['pass'])) {
	1024	+ unset($_POST['pass']);
	1025	+ }
	1026	+ if (isset($_POST['action'])) {
	1027	+ unset($_POST['action']);
	1028	+ }
	1029	+ if (isset($_POST['order'])) {
	1030	+ unset($_POST['order']);
	1031	+ }
1004	1032
1005	1033	$this->saveConfig();
1006	1034	}
		@@ -1058,10 +1086,18 @@ discard block
		block discarded – undo
1058	1086
1059	1087	$this->setConfig('xss_protected_list', $xssProtectedList);
1060	1088
1061		- if (isset($_POST['type'])) unset($_POST['type']);
1062		- if (isset($_POST['variable'])) unset($_POST['variable']);
1063		- if (isset($_POST['action'])) unset($_POST['action']);
1064		- if (isset($_POST['order'])) unset($_POST['order']);
	1089	+ if (isset($_POST['type'])) {
	1090	+ unset($_POST['type']);
	1091	+ }
	1092	+ if (isset($_POST['variable'])) {
	1093	+ unset($_POST['variable']);
	1094	+ }
	1095	+ if (isset($_POST['action'])) {
	1096	+ unset($_POST['action']);
	1097	+ }
	1098	+ if (isset($_POST['order'])) {
	1099	+ unset($_POST['order']);
	1100	+ }
1065	1101
1066	1102	$this->saveConfig();
1067	1103	}

		@@ -60,9 +60,12 @@
		block discarded – undo
60	60	</div>
61	61	</div>
62	62	</div>
63		- <?php else : ?>
	63	+ <?php else {
	64	+ : ?>
64	65	<div class="alert alert-danger">
65		- <?php _e('panel', 'log_msg_no_logger', 'Sorry, you have to implement ActionLogger to use this function.'); ?>
	66	+ <?php _e('panel', 'log_msg_no_logger', 'Sorry, you have to implement ActionLogger to use this function.');
	67	+}
	68	+?>
66	69
67	70	</div>
68	71	<?php endif; ?>

		@@ -62,7 +62,8 @@ discard block
		block discarded – undo
62	62	</tbdoy>
63	63	</table>
64	64	</div>
65		- <?php else: ?>
	65	+ <?php else {
	66	+ : ?>
66	67	<div id="so-table-loading" class="so-datatables">
67	68	<div class="lds-css ng-scope">
68	69	<div class="lds-ripple">
		@@ -71,7 +72,9 @@ discard block
		block discarded – undo
71	72	</div>
72	73	</div>
73	74	</div>
74		- <?php endif; ?>
	75	+ <?php endif;
	76	+}
	77	+?>
75	78	<div id="so-table-container" class="so-datatables" style="display: none;">
76	79	<table id="so-datalog" class="cell-border compact stripe responsive" cellspacing="0" width="100%">
77	80	<thead>

terrylinooo / shieldon

Branch — 1.x (bc5d7e)

Category

Braces +54 added lines, -18 removed lines patch added patch discarded remove patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch