View GitHub Repository shieldon

Schedule Inspection
Subscribe
Passed
Push — 2.x ( 8be9c2...fcd99a )
by Terry
02:19
created
Status
Category
Toggle Patches
templates/panel/action_log_past_seven_days.php 1 patch
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -60,9 +60,12 @@
 
 block discarded – undo
60 60 
                 </div>
61 61 
             </div>
62 62 
         </div>
63 
-    <?php else : ?>
63 
+    <?php else {
64 
+    : ?>
64 65 
         <div class="alert alert-danger">
65 
-            <?php _e('panel', 'log_msg_no_logger', 'Sorry, you have to implement ActionLogger to use this function.'); ?>
66 
+            <?php _e('panel', 'log_msg_no_logger', 'Sorry, you have to implement ActionLogger to use this function.');
67 
+}
68 
+?>
66 69
67 70 
         </div>
68 71 
     <?php endif; ?>
Please login to merge, or discard this patch.
templates/panel/iptables_manager.php 1 patch
Braces   +17 added lines, -5 removed lines patch added patch discarded remove patch 
@@ -46,9 +46,18 @@  discard block
 
 block discarded – undo
46 46 
                         <option value="null">---</option>
47 47 
                         <?php for ($i = 32; $i > 0; $i--) : ?>
48 48 
                             <?php $label = $i;  ?>
49 
-                            <?php if ($i === 8) $label = $i . ' (A)'; ?>
50 
-                            <?php if ($i === 16) $label = $i . ' (B)'; ?>
51 
-                            <?php if ($i === 24) $label = $i . ' (C)'; ?>
49 
+                            <?php if ($i === 8) {
50 
+    $label = $i . ' (A)';
51 
+}
52 
+?>
53 
+                            <?php if ($i === 16) {
54 
+    $label = $i . ' (B)';
55 
+}
56 
+?>
57 
+                            <?php if ($i === 24) {
58 
+    $label = $i . ' (C)';
59 
+}
60 
+?>
52 61 
                             <option value="<?php echo $i; ?>"><?php echo $label; ?></option>
53 62 
                         <?php endfor; ?>
54 63 
                     </select>
 
@@ -122,7 +131,8 @@  discard block
 
 block discarded – undo
122 131 
             </tbdoy>
123 132 
         </table>
124 133 
     </div>
125 
-    <?php else: ?>
134 
+    <?php else {
135 
+    : ?>
126 136 
     <div id="so-table-loading" class="so-datatables">
127 137 
         <div class="lds-css ng-scope">
128 138 
             <div class="lds-ripple">
 
@@ -131,7 +141,9 @@  discard block
 
 block discarded – undo
131 141 
             </div>
132 142 
         </div>
133 143 
     </div>
134 
-    <?php endif; ?>
144 
+    <?php endif;
145 
+}
146 
+?>
135 147 
     <div id="so-table-container" class="so-datatables" style="display: none;">
136 148 
         <table id="so-datalog" class="cell-border compact stripe responsive" cellspacing="0" width="100%">
137 149 
             <thead>
Please login to merge, or discard this patch.
templates/panel/authentication.php 1 patch
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -62,7 +62,8 @@  discard block
 
 block discarded – undo
62 62 
             </tbdoy>
63 63 
         </table>
64 64 
     </div>
65 
-    <?php else: ?>
65 
+    <?php else {
66 
+    : ?>
66 67 
     <div id="so-table-loading" class="so-datatables">
67 68 
         <div class="lds-css ng-scope">
68 69 
             <div class="lds-ripple">
 
@@ -71,7 +72,9 @@  discard block
 
 block discarded – undo
71 72 
             </div>
72 73 
         </div>
73 74 
     </div>
74 
-    <?php endif; ?>
75 
+    <?php endif;
76 
+}
77 
+?>
75 78 
     <div id="so-table-container" class="so-datatables" style="display: none;">
76 79 
         <table id="so-datalog" class="cell-border compact stripe responsive" cellspacing="0" width="100%">
77 80 
             <thead>
Please login to merge, or discard this patch.
templates/panel/table_rules.php 1 patch
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -53,7 +53,8 @@  discard block
 
 block discarded – undo
53 53 
             </tbdoy>
54 54 
         </table>
55 55 
     </div>
56 
-    <?php else: ?>
56 
+    <?php else {
57 
+    : ?>
57 58 
     <div id="so-table-loading" class="so-datatables">
58 59 
         <div class="lds-css ng-scope">
59 60 
             <div class="lds-ripple">
 
@@ -62,7 +63,9 @@  discard block
 
 block discarded – undo
62 63 
             </div>
63 64 
         </div>
64 65 
     </div>
65 
-    <?php endif; ?>
66 
+    <?php endif;
67 
+}
68 
+?>
66 69 
     <?php if (! empty($rule_list)) : ?>
67 70 
     <div id="so-table-container" class="so-datatables" style="display: none;">
68 71 
         <table id="so-datalog" class="cell-border compact stripe responsive" cellspacing="0" width="100%">
Please login to merge, or discard this patch.
templates/panel/operation_status.php 1 patch
Braces   +45 added lines, -18 removed lines patch added patch discarded remove patch 
@@ -27,8 +27,11 @@  discard block
 
 block discarded – undo
27 27 
                     <div class="nums">
28 28 
                         <?php if (! empty($filter_cookie)) : ?>
29 29 
                             <a href="#" onclick="displayLogs('frequency');"><?php echo $filter_cookie; ?></a>
30 
-                        <?php else : ?>
31 
-                            <?php echo $filter_cookie; ?>
30 
+                        <?php else {
31 
+    : ?>
32 
+                            <?php echo $filter_cookie;
33 
+}
34 
+?>
32 35 
                         <?php endif; ?>
33 36 
                     </div>
34 37 
                     <div class="note"><?php _e('panel', 'overview_note_cookie', 'Check whether visitors can create cookie by JavaScript.'); ?></div>
 
@@ -43,8 +46,11 @@  discard block
 
 block discarded – undo
43 46 
                     <div class="nums">
44 47 
                         <?php if (! empty($filter_session)) : ?>
45 48 
                             <a href="#" onclick="displayLogs('session');"><?php echo $filter_session; ?></a>
46 
-                        <?php else : ?>
47 
-                            <?php echo $filter_session; ?>
49 
+                        <?php else {
50 
+    : ?>
51 
+                            <?php echo $filter_session;
52 
+}
53 
+?>
48 54 
                         <?php endif; ?>
49 55 
                     </div>
50 56 
                     <div class="note"><?php _e('panel', 'overview_note_session', 'Detect whether multiple sessions created by the same visitor.'); ?></div>
 
@@ -59,8 +65,11 @@  discard block
 
 block discarded – undo
59 65 
                     <div class="nums">
60 66 
                         <?php if (! empty($filter_frequency)) : ?>
61 67 
                             <a href="#" onclick="displayLogs('frequency');"><?php echo $filter_frequency; ?></a>
62 
-                        <?php else : ?>
63 
-                            <?php echo $filter_frequency; ?>
68 
+                        <?php else {
69 
+    : ?>
70 
+                            <?php echo $filter_frequency;
71 
+}
72 
+?>
64 73 
                         <?php endif; ?>
65 74 
                     </div>
66 75 
                     <div class="note"><?php _e('panel', 'overview_note_frequency', 'Check how often does a visitor view the pages.'); ?></div>
 
@@ -75,8 +84,11 @@  discard block
 
 block discarded – undo
75 84 
                     <div class="nums">
76 85 
                         <?php if (! empty($filter_referer)) : ?>
77 86 
                             <a href="#" onclick="displayLogs('referer');"><?php echo $filter_referer; ?></a>
78 
-                        <?php else : ?>
79 
-                            <?php echo $filter_referer; ?>
87 
+                        <?php else {
88 
+    : ?>
89 
+                            <?php echo $filter_referer;
90 
+}
91 
+?>
80 92 
                         <?php endif; ?>
81 93 
                     </div>
82 94 
                     <div class="note"><?php _e('panel', 'overview_note_referer', 'Check HTTP referrer information.'); ?></div>
 
@@ -101,8 +113,11 @@  discard block
 
 block discarded – undo
101 113 
                     <div class="nums">
102 114 
                         <?php if (! empty($component_ip)) : ?>
103 115 
                             <a href="#" onclick="displayLogs('ip');"><?php echo $component_ip; ?></a>
104 
-                        <?php else : ?>
105 
-                            <?php echo $component_ip; ?>
116 
+                        <?php else {
117 
+    : ?>
118 
+                            <?php echo $component_ip;
119 
+}
120 
+?>
106 121 
                         <?php endif; ?>
107 122 
                     </div>
108 123 
                     <div class="note"><?php _e('panel', 'operation_note_ip', 'Advanced IP address mangement.'); ?></div>
 
@@ -117,8 +132,11 @@  discard block
 
 block discarded – undo
117 132 
                     <div class="nums">
118 133 
                         <?php if (! empty($component_trustedbot)) : ?>
119 134 
                             <a href="#" onclick="displayLogs('trustedbot');"><?php echo $component_trustedbot; ?></a>
120 
-                        <?php else : ?>
121 
-                            <?php echo $component_trustedbot; ?>
135 
+                        <?php else {
136 
+    : ?>
137 
+                            <?php echo $component_trustedbot;
138 
+}
139 
+?>
122 140 
                         <?php endif; ?>
123 141 
                     </div>
124 142 
                     <div class="note"><?php _e('panel', 'operation_note_trustedbot', 'Allow popular search engines crawl your website.'); ?></div>
 
@@ -133,8 +151,11 @@  discard block
 
 block discarded – undo
133 151 
                     <div class="nums">
134 152 
                         <?php if (! empty($component_header)) : ?>
135 153 
                             <a href="#" onclick="displayLogs('header');"><?php echo $component_header; ?></a>
136 
-                        <?php else : ?>
137 
-                            <?php echo $component_header; ?>
154 
+                        <?php else {
155 
+    : ?>
156 
+                            <?php echo $component_header;
157 
+}
158 
+?>
138 159 
                         <?php endif; ?>
139 160 
                     </div>
140 161 
                     <div class="note"><?php _e('panel', 'operation_note_header', 'Analyze header information from visitors.'); ?></div>
 
@@ -149,8 +170,11 @@  discard block
 
 block discarded – undo
149 170 
                     <div class="nums">
150 171 
                         <?php if (! empty($component_rdns)) : ?>
151 172 
                             <a href="#" onclick="displayLogs('rdns');"><?php echo $component_rdns; ?></a>
152 
-                        <?php else : ?>
153 
-                            <?php echo $component_rdns; ?>
173 
+                        <?php else {
174 
+    : ?>
175 
+                            <?php echo $component_rdns;
176 
+}
177 
+?>
154 178 
                         <?php endif; ?>
155 179 
                     </div>
156 180 
                     <div class="note"><?php _e('panel', 'operation_note_rdns', 'Identify IP resolved hostname (RDNS) from visitors.'); ?></div>
 
@@ -165,8 +189,11 @@  discard block
 
 block discarded – undo
165 189 
                     <div class="nums">
166 190 
                         <?php if (! empty($component_useragent)) : ?>
167 191 
                             <a href="#" onclick="displayLogs('useragent');"><?php echo $component_useragent; ?></a>
168 
-                        <?php else : ?>
169 
-                            <?php echo $component_useragent; ?>
192 
+                        <?php else {
193 
+    : ?>
194 
+                            <?php echo $component_useragent;
195 
+}
196 
+?>
170 197 
                         <?php endif; ?>
171 198 
                     </div>
172 199 
                     <div class="note"><?php _e('panel', 'operation_note_useragent', 'Analysis user-agent information from visitors.'); ?></div>
Please login to merge, or discard this patch.
templates/panel/template.php 1 patch
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -279,11 +279,14 @@
 
 block discarded – undo
279 279 
                                     <i class="fas fa-times-circle"></i>
280 280 
                                 <?php endif; ?>
281 281 
                             </div>
282 
-                            <?php else: ?>
282 
+                            <?php else {
283 
+    : ?>
283 284 
                                 <div class="icon-box">
284 285 
                                     <i class="fas fa-exclamation-circle"></i>
285 286 
                                 </div>
286 
-                            <?php endif; ?>
287 
+                            <?php endif;
288 
+}
289 
+?>
287 290 
                         </div>
288 291 
                         <button type="button" class="close" data-dismiss="modal" aria-label="Close">
289 292 
                             <span aria-hidden="true">&times;</span>
Please login to merge, or discard this patch.
templates/panel/js/chart.php 1 patch
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -21,8 +21,11 @@
 
 block discarded – undo
21 21 
     var pageviewChartString = [<?php echo ($past_seven_hours['pageview_chart_string'] ?? ''); ?>];
22 22 
     var captchaChartString = [<?php echo ($past_seven_hours['captcha_chart_string'] ?? ''); ?>];
23 23 
     var labelChartString = [<?php echo ($past_seven_hours['label_chart_string'] ?? ''); ?>];
24 
-    <?php else : ?>
25 
-    var pageviewChartString = [<?php echo ($period_data['pageview_chart_string'] ?? ''); ?>];
24 
+    <?php else {
25 
+    : ?>
26 
+    var pageviewChartString = [<?php echo ($period_data['pageview_chart_string'] ?? '');
27 
+}
28 
+?>];
26 29 
     var captchaChartString = [<?php echo ($period_data['captcha_chart_string'] ?? ''); ?>];
27 30 
     var labelChartString = [<?php echo ($period_data['label_chart_string'] ?? ''); ?>];
28 31 
     <?php endif; ?>
Please login to merge, or discard this patch.
templates/panel/ip_manager.php 1 patch
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -69,7 +69,8 @@  discard block
 
 block discarded – undo
69 69 
             </tbdoy>
70 70 
         </table>
71 71 
     </div>
72 
-    <?php else: ?>
72 
+    <?php else {
73 
+    : ?>
73 74 
     <div id="so-table-loading" class="so-datatables">
74 75 
         <div class="lds-css ng-scope">
75 76 
             <div class="lds-ripple">
 
@@ -78,7 +79,9 @@  discard block
 
 block discarded – undo
78 79 
             </div>
79 80 
         </div>
80 81 
     </div>
81 
-    <?php endif; ?>
82 
+    <?php endif;
83 
+}
84 
+?>
82 85
83 86 
     <div id="so-table-container" class="so-datatables" style="display: none;">
84 87 
         <table id="so-datalog" class="cell-border compact stripe responsive" cellspacing="0" width="100%">
Please login to merge, or discard this patch.
src/Firewall/Driver/SqliteDriver.php 1 patch
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch 
@@ -27,11 +27,11 @@
 
 block discarded – undo
27 27 
         parent::__construct($pdo, $debug);
28 28 
     }
29 29
30 
-      /**
31 
-     * Create SQL tables that Shieldon needs.
32 
-     *
33 
-     * @return bool
34 
-     */
30 
+        /**
31 
+         * Create SQL tables that Shieldon needs.
32 
+         *
33 
+         * @return bool
34 
+         */
35 35 
     protected function installSql(): bool
36 36 
     {
37 37 
         try {
Please login to merge, or discard this patch.