View GitHub Repository shieldon

Schedule Inspection
Subscribe
Passed
Push — 2.x ( 958536...e12ed9 )
by Terry
02:44 queued 25s
created
Status
Category
Toggle Patches
src/Firewall/Helpers.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -167,7 +167,7 @@
 
 block discarded – undo
167 167 
         $masked = implode('.', $tmp);
168 168
169 169 
     } else {
170 
-        $masked =  str_repeat('*', strlen($str) - 6) . substr(str, -6);
170 
+        $masked = str_repeat('*', strlen($str) - 6) . substr(str, -6);
171 171 
     }
172 172
173 173 
     return $masked;
Please login to merge, or discard this patch.
src/Firewall/Panel/User.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -56,7 +56,7 @@
 
 block discarded – undo
56 56
57 57 
             if (
58 58 
                 // Default password, unencrypted.
59 
-                $admin['user']  === $postParams['s_user'] &&
59 
+                $admin['user'] === $postParams['s_user'] &&
60 60 
                 'shieldon_pass' === $postParams['s_pass'] &&
61 61 
                 'shieldon_pass' === $admin['pass']
62 62 
             ) {
Please login to merge, or discard this patch.
templates/panel/action_log_last_month.php 2 patches
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -60,9 +60,12 @@
 
 block discarded – undo
60 60 
                 </div>
61 61 
             </div>
62 62 
         </div>
63 
-    <?php else : ?>
63 
+    <?php else {
64 
+    : ?>
64 65 
         <div class="alert alert-danger">
65 
-            <?php _e('panel', 'log_msg_no_logger', 'Sorry, you have to implement ActionLogger to use this function.'); ?>
66 
+            <?php _e('panel', 'log_msg_no_logger', 'Sorry, you have to implement ActionLogger to use this function.');
67 
+}
68 
+?>
66 69
67 70 
         </div>
68 71 
     <?php endif; ?>
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -18,7 +18,7 @@  discard block
 
 block discarded – undo
18 18 
 ?>
19 19
20 20 
 <div class="so-dashboard">
21 
-    <?php if (! empty($period_data)) : ?>
21 
+    <?php if (!empty($period_data)) : ?>
22 22 
     <div class="so-flex">
23 23 
         <div class="so-board">
24 24 
             <div class="board-field left">
 
@@ -89,7 +89,7 @@  discard block
 
 block discarded – undo
89 89 
                 </tr>
90 90 
             </thead>
91 91 
             <tbody>
92 
-                <?php if (! empty($ip_details)) : ?>
92 
+                <?php if (!empty($ip_details)) : ?>
93 93 
                 <?php foreach ($ip_details as $ip => $ipInfo) : ?>
94 94 
                 <tr>
95 95 
                     <td>
 
@@ -112,7 +112,7 @@  discard block
 
 block discarded – undo
112 112 
         </table>
113 113 
     </div>
114 114 
     <div class="so-timezone">
115 
-        <?php if (! empty($last_cached_time)) : ?>
115 
+        <?php if (!empty($last_cached_time)) : ?>
116 116 
             <?php _e('panel', 'log_label_cache_time', 'Report generated time'); ?>: <strong class="text-info"><?php echo $last_cached_time; ?></strong>
117 117 
             &nbsp;&nbsp;&nbsp;&nbsp;
118 118 
         <?php endif; ?>
 
@@ -122,7 +122,7 @@  discard block
 
 block discarded – undo
122 122
123 123 
 <?php
124 124
125 
-    if (! empty($period_data)) {
125 
+    if (!empty($period_data)) {
126 126 
         $data['period_data'] = $period_data;
127 127 
         $this->_include('panel/js/chart', $data);
128 128 
     }
Please login to merge, or discard this patch.
templates/panel/exclusion.php 2 patches
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -62,7 +62,8 @@  discard block
 
 block discarded – undo
62 62 
             </tbdoy>
63 63 
         </table>
64 64 
     </div>
65 
-    <?php else: ?>
65 
+    <?php else {
66 
+    : ?>
66 67 
     <div id="so-table-loading" class="so-datatables">
67 68 
         <div class="lds-css ng-scope">
68 69 
             <div class="lds-ripple">
 
@@ -71,7 +72,9 @@  discard block
 
 block discarded – undo
71 72 
             </div>
72 73 
         </div>
73 74 
     </div>
74 
-    <?php endif; ?>
75 
+    <?php endif;
76 
+}
77 
+?>
75 78 
     <div id="so-table-container" class="so-datatables" style="display: none;">
76 79 
         <table id="so-datalog" class="cell-border compact stripe responsive" cellspacing="0" width="100%">
77 80 
             <thead>
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -77,7 +77,7 @@
 
 block discarded – undo
77 77 
                 </tr>
78 78 
             </thead>
79 79 
             <tbody>
80 
-                <?php if (! empty($exclusion_list)) : ?>
80 
+                <?php if (!empty($exclusion_list)) : ?>
81 81 
                 <?php foreach ($exclusion_list as $i => $urlInfo) : ?>
82 82 
                 <tr>
83 83 
                     <td><?php echo $urlInfo['url']; ?></td>
Please login to merge, or discard this patch.
templates/panel/action_log_this_month.php 2 patches
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -60,9 +60,12 @@
 
 block discarded – undo
60 60 
                 </div>
61 61 
             </div>
62 62 
         </div>
63 
-    <?php else : ?>
63 
+    <?php else {
64 
+    : ?>
64 65 
         <div class="alert alert-danger">
65 
-            <?php _e('panel', 'log_msg_no_logger', 'Sorry, you have to implement ActionLogger to use this function.'); ?>
66 
+            <?php _e('panel', 'log_msg_no_logger', 'Sorry, you have to implement ActionLogger to use this function.');
67 
+}
68 
+?>
66 69
67 70 
         </div>
68 71 
     <?php endif; ?>
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -18,7 +18,7 @@  discard block
 
 block discarded – undo
18 18 
 ?>
19 19
20 20 
 <div class="so-dashboard">
21 
-    <?php if (! empty($period_data)) : ?>
21 
+    <?php if (!empty($period_data)) : ?>
22 22 
     <div class="so-flex">
23 23 
         <div class="so-board">
24 24 
             <div class="board-field left">
 
@@ -89,7 +89,7 @@  discard block
 
 block discarded – undo
89 89 
                 </tr>
90 90 
             </thead>
91 91 
             <tbody>
92 
-                <?php if (! empty($ip_details)) : ?>
92 
+                <?php if (!empty($ip_details)) : ?>
93 93 
                 <?php foreach ($ip_details as $ip => $ipInfo) : ?>
94 94 
                 <tr>
95 95 
                     <td>
 
@@ -112,7 +112,7 @@  discard block
 
 block discarded – undo
112 112 
         </table>
113 113 
     </div>
114 114 
     <div class="so-timezone">
115 
-        <?php if (! empty($last_cached_time)) : ?>
115 
+        <?php if (!empty($last_cached_time)) : ?>
116 116 
             <?php _e('panel', 'log_label_cache_time', 'Report generated time'); ?>: <strong class="text-info"><?php echo $last_cached_time; ?></strong>
117 117 
             &nbsp;&nbsp;&nbsp;&nbsp;
118 118 
         <?php endif; ?>
 
@@ -122,7 +122,7 @@  discard block
 
 block discarded – undo
122 122
123 123 
 <?php
124 124
125 
-    if (! empty($period_data)) {
125 
+    if (!empty($period_data)) {
126 126 
         $data['period_data'] = $period_data;
127 127 
         $this->_include('panel/js/chart', $data);
128 128 
     }
Please login to merge, or discard this patch.
templates/panel/action_log_today.php 2 patches
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -60,9 +60,12 @@
 
 block discarded – undo
60 60 
                 </div>
61 61 
             </div>
62 62 
         </div>
63 
-    <?php else : ?>
63 
+    <?php else {
64 
+    : ?>
64 65 
         <div class="alert alert-danger">
65 
-            <?php _e('panel', 'log_msg_no_logger', 'Sorry, you have to implement ActionLogger to use this function.'); ?>
66 
+            <?php _e('panel', 'log_msg_no_logger', 'Sorry, you have to implement ActionLogger to use this function.');
67 
+}
68 
+?>
66 69
67 70 
         </div>
68 71 
     <?php endif; ?>
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -18,7 +18,7 @@  discard block
 
 block discarded – undo
18 18 
 ?>
19 19
20 20 
 <div class="so-dashboard">
21 
-    <?php if (! empty($period_data)) : ?>
21 
+    <?php if (!empty($period_data)) : ?>
22 22 
     <div class="so-flex">
23 23 
         <div class="so-board">
24 24 
             <div class="board-field left">
 
@@ -88,7 +88,7 @@  discard block
 
 block discarded – undo
88 88 
                 </tr>
89 89 
             </thead>
90 90 
             <tbody>
91 
-                <?php if (! empty($ip_details)) : ?>
91 
+                <?php if (!empty($ip_details)) : ?>
92 92 
                 <?php foreach ($ip_details as $ip => $ipInfo) : ?>
93 93 
                 <tr>
94 94 
                     <td>
 
@@ -111,7 +111,7 @@  discard block
 
 block discarded – undo
111 111 
         </table>
112 112 
     </div>
113 113 
     <div class="so-timezone">
114 
-        <?php if (! empty($last_cached_time)) : ?>
114 
+        <?php if (!empty($last_cached_time)) : ?>
115 115 
             <?php _e('panel', 'log_label_cache_time', 'Report generated time'); ?>: <strong class="text-info"><?php echo $last_cached_time; ?></strong>
116 116 
             &nbsp;&nbsp;&nbsp;&nbsp;
117 117 
         <?php endif; ?>
 
@@ -121,7 +121,7 @@  discard block
 
 block discarded – undo
121 121
122 122 
 <?php
123 123
124 
-    if (! empty($period_data)) {
124 
+    if (!empty($period_data)) {
125 125 
         $data['period_data'] = $period_data;
126 126 
         $data['past_seven_hours'] = $past_seven_hours;
127 127 
         $this->_include('panel/js/chart', $data);
Please login to merge, or discard this patch.
templates/panel/action_log_yesterday.php 2 patches
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -60,9 +60,12 @@
 
 block discarded – undo
60 60 
                 </div>
61 61 
             </div>
62 62 
         </div>
63 
-    <?php else : ?>
63 
+    <?php else {
64 
+    : ?>
64 65 
         <div class="alert alert-danger">
65 
-            <?php _e('panel', 'log_msg_no_logger', 'Sorry, you have to implement ActionLogger to use this function.'); ?>
66 
+            <?php _e('panel', 'log_msg_no_logger', 'Sorry, you have to implement ActionLogger to use this function.');
67 
+}
68 
+?>
66 69
67 70 
         </div>
68 71 
     <?php endif; ?>
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -18,7 +18,7 @@  discard block
 
 block discarded – undo
18 18 
 ?>
19 19
20 20 
 <div class="so-dashboard">
21 
-    <?php if (! empty($period_data)) : ?>
21 
+    <?php if (!empty($period_data)) : ?>
22 22 
     <div class="so-flex">
23 23 
         <div class="so-board">
24 24 
             <div class="board-field left">
 
@@ -89,7 +89,7 @@  discard block
 
 block discarded – undo
89 89 
                 </tr>
90 90 
             </thead>
91 91 
             <tbody>
92 
-                <?php if (! empty($ip_details)) : ?>
92 
+                <?php if (!empty($ip_details)) : ?>
93 93 
                 <?php foreach ($ip_details as $ip => $ipInfo) : ?>
94 94 
                 <tr>
95 95 
                     <td>
 
@@ -112,7 +112,7 @@  discard block
 
 block discarded – undo
112 112 
         </table>
113 113 
     </div>
114 114 
     <div class="so-timezone">
115 
-        <?php if (! empty($last_cached_time)) : ?>
115 
+        <?php if (!empty($last_cached_time)) : ?>
116 116 
             <?php _e('panel', 'log_label_cache_time', 'Report generated time'); ?>: <strong class="text-info"><?php echo $last_cached_time; ?></strong>
117 117 
             &nbsp;&nbsp;&nbsp;&nbsp;
118 118 
         <?php endif; ?>
 
@@ -122,7 +122,7 @@  discard block
 
 block discarded – undo
122 122
123 123 
 <?php
124 124
125 
-    if (! empty($period_data)) {
125 
+    if (!empty($period_data)) {
126 126 
         $data['period_data'] = $period_data;
127 127 
         $this->_include('panel/js/chart', $data);
128 128 
     }
Please login to merge, or discard this patch.
templates/panel/overview.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -203,7 +203,7 @@  discard block
 
 block discarded – undo
203 203 
                 <div class="filter-status">
204 204 
                     <div class="heading"><?php _e('panel', 'overview_label_action_logger', 'Action Logger'); ?></div>
205 205 
                     <div class="nums">
206 
-                        <?php echo $data['action_logger']  ? '<i class="far fa-play-circle"></i>' : '<i class="far fa-stop-circle"></i>'; ?>
206 
+                        <?php echo $data['action_logger'] ? '<i class="far fa-play-circle"></i>' : '<i class="far fa-stop-circle"></i>'; ?>
207 207 
                     </div>
208 208 
                     <div class="note"><?php _e('panel', 'overview_note_action_logger', 'Record every visitor’s behavior.'); ?></div>
209 209 
                 </div>
 
@@ -222,7 +222,7 @@  discard block
 
 block discarded – undo
222 222 
                 <div class="filter-status">
223 223 
                     <div class="heading"><?php _e('panel', 'overview_label_recaptcha', 'reCAPTCHA'); ?></div>
224 224 
                     <div class="nums">
225 
-                        <?php echo $captcha['recaptcha']  ? '<i class="far fa-play-circle"></i>' : '<i class="far fa-stop-circle"></i>'; ?>
225 
+                        <?php echo $captcha['recaptcha'] ? '<i class="far fa-play-circle"></i>' : '<i class="far fa-stop-circle"></i>'; ?>
226 226 
                     </div>
227 227 
                     <div class="note"><?php _e('panel', 'overview_note_recaptcha', 'Provided by Google.'); ?></div>
228 228 
                 </div>
 
@@ -231,7 +231,7 @@  discard block
 
 block discarded – undo
231 231 
                 <div class="filter-status">
232 232 
                     <div class="heading"><?php _e('panel', 'overview_label_image_captcha', 'Image Captcha'); ?></div>
233 233 
                     <div class="nums">
234 
-                        <?php echo $captcha['imagecaptcha']  ? '<i class="far fa-play-circle"></i>' : '<i class="far fa-stop-circle"></i>'; ?>
234 
+                        <?php echo $captcha['imagecaptcha'] ? '<i class="far fa-play-circle"></i>' : '<i class="far fa-stop-circle"></i>'; ?>
235 235 
                     </div>
236 236 
                     <div class="note"><?php _e('panel', 'overview_note_image_captcha', 'A simple text-in-image Captcha.'); ?></div>
237 237 
                 </div>
 
@@ -251,7 +251,7 @@  discard block
 
 block discarded – undo
251 251 
                 <div class="filter-status">
252 252 
                     <div class="heading"><?php _e('panel', 'overview_label_' . $k, ''); ?></div>
253 253 
                     <div class="nums">
254 
-                        <?php echo $messengers[$k]  ? '<i class="far fa-play-circle"></i>' : '<i class="far fa-stop-circle"></i>'; ?>
254 
+                        <?php echo $messengers[$k] ? '<i class="far fa-play-circle"></i>' : '<i class="far fa-stop-circle"></i>'; ?>
255 255 
                     </div>
256 256 
                     <div class="note"><?php _e('panel', 'overview_note_' . $k, ''); ?></div>
257 257 
                 </div>
Please login to merge, or discard this patch.
templates/panel/xss_protection.php 2 patches
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -62,7 +62,8 @@  discard block
 
 block discarded – undo
62 62 
             </tbdoy>
63 63 
         </table>
64 64 
     </div>
65 
-    <?php else: ?>
65 
+    <?php else {
66 
+    : ?>
66 67 
     <div id="so-table-loading" class="so-datatables">
67 68 
         <div class="lds-css ng-scope">
68 69 
             <div class="lds-ripple">
 
@@ -71,7 +72,9 @@  discard block
 
 block discarded – undo
71 72 
             </div>
72 73 
         </div>
73 74 
     </div>
74 
-    <?php endif; ?>
75 
+    <?php endif;
76 
+}
77 
+?>
75 78 
     <div id="so-table-container" class="so-datatables" style="display: none;">
76 79 
         <table id="so-datalog" class="cell-border compact stripe responsive" cellspacing="0" width="100%">
77 80 
             <thead>
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -114,7 +114,7 @@  discard block
 
 block discarded – undo
114 114 
         </div>
115 115 
     </div>
116 116 
     <br />
117 
-    <?php if ( empty($xss_protected_list)) : ?>
117 
+    <?php if (empty($xss_protected_list)) : ?>
118 118 
     <div id="so-table-container" class="so-datatables">
119 119 
         <table id="so-datalog" class="cell-border compact stripe responsive" cellspacing="0" width="100%">
120 120 
             <tbody>
 
@@ -146,7 +146,7 @@  discard block
 
 block discarded – undo
146 146 
                 </tr>
147 147 
             </thead>
148 148 
             <tbody>
149 
-                <?php if (! empty($xss_protected_list)) : ?>
149 
+                <?php if (!empty($xss_protected_list)) : ?>
150 150 
                 <?php foreach ($xss_protected_list as $i => $info) : ?>
151 151 
                 <tr>
152 152 
                     <td><?php echo $info['type']; ?></td>
Please login to merge, or discard this patch.