terox /
SubscriptionBundle
| Conditions | 10 |
| Paths | 25 |
| Total Lines | 45 |
| Code Lines | 20 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 19 |
| CRAP Score | 10.0125 |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 20 | 12 | public function createSubscription(ProductInterface $product, array $subscriptions = []) |
|
| 21 | { |
||
| 22 | 12 | if (empty($subscriptions)) { |
|
| 23 | 4 | return $this->create($this->createCurrentDate(), $product); |
|
| 24 | } |
||
| 25 | |||
| 26 | 8 | $startDate = null; |
|
| 27 | 8 | foreach ($subscriptions as $subscription) { |
|
| 28 | |||
| 29 | // Subscription is permanent, don't continue |
||
| 30 | 8 | if (null === $subscription->getEndDate()) { |
|
| 31 | 4 | $startDate = null; |
|
| 32 | 4 | break; |
|
| 33 | } |
||
| 34 | |||
| 35 | // Catch the subscription with higher end date |
||
| 36 | 5 | if (null === $startDate || $startDate < $subscription->getEndDate()) { |
|
| 37 | 5 | $startDate = $subscription->getEndDate(); |
|
| 38 | } |
||
| 39 | } |
||
| 40 | |||
| 41 | // It's a permanent subscription |
||
| 42 | 8 | if (null === $startDate) { |
|
|
introduced
by
|
|||
| 43 | |||
| 44 | 4 | if (count($subscriptions) > 1) { |
|
| 45 | 2 | throw new PermanentSubscriptionException( |
|
| 46 | 2 | 'More than one subscription per product is not allowed when there is a permanent subscription |
|
| 47 | enabled. Maybe you are mixing different strategies?' |
||
| 48 | ); |
||
| 49 | } |
||
| 50 | |||
| 51 | 2 | return $subscriptions[0]; |
|
| 52 | } |
||
| 53 | |||
| 54 | // Check if subscription is expired |
||
| 55 | 4 | if (time() > $startDate->getTimestamp()) { |
|
| 56 | 1 | $startDate = $this->createCurrentDate(); |
|
| 57 | } |
||
| 58 | |||
| 59 | // Date should use the \DateTimeImmutable (a little fix) |
||
| 60 | 4 | if (!$startDate instanceof \DateTimeImmutable) { |
|
| 61 | $startDate = (new \DateTimeImmutable())->setTimestamp($startDate->getTimestamp()); |
||
| 62 | } |
||
| 63 | |||
| 64 | 4 | return $this->create($startDate, $product); |
|
| 65 | } |
||
| 90 |
Loading history...