Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 7 | abstract class DataMapper |
||
| 8 | { |
||
| 9 | |||
| 10 | protected $connection; |
||
| 11 | protected $table; |
||
| 12 | |||
| 13 | |||
| 14 | /** |
||
| 15 | * Creates new mapper instance |
||
| 16 | * |
||
| 17 | * @param PDO $connection |
||
| 18 | * @param string $table A list of table name aliases |
||
| 19 | * |
||
| 20 | * @codeCoverageIgnore |
||
| 21 | */ |
||
| 22 | public function __construct(PDO $connection, string $table) |
||
| 27 | |||
| 28 | |||
| 29 | /** |
||
| 30 | * Method for populating the doven instance with values from the array via setters |
||
| 31 | * |
||
| 32 | * @param object $instance The object to be populated with values |
||
| 33 | * @param array $parameters A key-value array, that will be matched to setters |
||
| 34 | */ |
||
| 35 | 1 | View Code Duplication | public function applyValues($instance, array $parameters) |
| 44 | |||
| 45 | } |
||
| 46 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.