OneTimeIdentity::setKey() - Code Metrics - Inspection of "Adding service logic for handling one-time use ide..." - teresko/palladium - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 25598f...82bcfc )

by Mārtiņš

created 2017-05-15 17:20 UTC

OneTimeIdentity::setKey() A

↳ Parent: OneTimeIdentity

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	12
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	12
loc	12
ccs	0
cts	10
cp	0
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	1
crap	6

<?php

namespace Palladium\Entity;

class OneTimeIdentity extends Identity
{

    const HASH_ALGO = PASSWORD_BCRYPT;
    const HASH_COST = 12;

    const NONCE_SIZE = 16;
    const KEY_SIZE = 32;

    private $nonce;
    private $hash;

    protected $type = Identity::TYPE_ONETIME;


    public function setNonce($nonce)
    {
        $this->nonce = (string) $nonce;
    }


    public function getNonce()
    {
        return $this->nonce;
    }


    public function generateNewNonce()
    {
        $this->nonce = bin2hex(random_bytes(self::NONCE_SIZE));
    }


    public function getFootprint()
    {
        return hash('sha384', $this->nonce);
    }


    /**
     * Sets a new key and resets the hash.
     */
    public function generateNewKey()
    {
        $key = bin2hex(random_bytes(self::KEY_SIZE));
        $this->key = $key;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->hash = $this->makeHash($key);
    }


    private function makeHash($key)
    {
        $hash = password_hash($key, self::HASH_ALGO, ['cost' => self::HASH_COST]);

        return $hash;
    }


    public function matchKey($key)
    {
        return password_verify($key, $this->hash);
    }


    /**
     * Assignes a new identification key and resets a the hash.
     *
     * @param string $key
     */
    public function setKey($key)

    {
        $this->hash = null;

        if (empty($key)) {
            $this->key = null;
            return;
        }

        $this->key = (string) $key;
        $this->hash = $this->makeHash($key);
    }


    public function setHash($hash)
    {
        $this->hash = (string) $hash;
    }

    /**
     * @codeCoverageIgnore
     * @return string
     */
    public function getHash()
    {
        return $this->hash;
    }
}


1		<?php
2
3		namespace Palladium\Entity;
4
5		class OneTimeIdentity extends Identity
6		{
7
8		const HASH_ALGO = PASSWORD_BCRYPT;
9		const HASH_COST = 12;
10
11		const NONCE_SIZE = 16;
12		const KEY_SIZE = 32;
13
14		private $nonce;
15		private $hash;
16
17		protected $type = Identity::TYPE_ONETIME;
18
19
20		public function setNonce($nonce)
21		{
22		$this->nonce = (string) $nonce;
23		}
24
25
26		public function getNonce()
27		{
28		return $this->nonce;
29		}
30
31
32		public function generateNewNonce()
33		{
34		$this->nonce = bin2hex(random_bytes(self::NONCE_SIZE));
35		}
36
37
38		public function getFootprint()
39		{
40		return hash('sha384', $this->nonce);
41		}
42
43
44		/**
45		* Sets a new key and resets the hash.
46		*/
47		public function generateNewKey()
48		{
49		$key = bin2hex(random_bytes(self::KEY_SIZE));
50		$this->key = $key;
		0 ignored issues – show Bug introduced 2017-05-15 17:22 UTC by Report Bug Copy Issue Report The property `key` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
51		$this->hash = $this->makeHash($key);
52		}
53
54
55		private function makeHash($key)
56		{
57		$hash = password_hash($key, self::HASH_ALGO, ['cost' => self::HASH_COST]);
58
59		return $hash;
60		}
61
62
63		public function matchKey($key)
64		{
65		return password_verify($key, $this->hash);
66		}
67
68
69		/**
70		* Assignes a new identification key and resets a the hash.
71		*
72		* @param string $key
73		*/
74	View Code Duplication	public function setKey($key)
		0 ignored issues – show Duplication introduced 2017-05-15 17:22 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
75		{
76		$this->hash = null;
77
78		if (empty($key)) {
79		$this->key = null;
80		return;
81		}
82
83		$this->key = (string) $key;
84		$this->hash = $this->makeHash($key);
85		}
86
87
88		public function setHash($hash)
89		{
90		$this->hash = (string) $hash;
91		}
92
93		/**
94		* @codeCoverageIgnore
95		* @return string
96		*/
97		public function getHash()
98		{
99		return $this->hash;
100		}
101		}
102

teresko / palladium

Push — master ( 25598f...82bcfc )

OneTimeIdentity::setKey() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like