| Conditions | 14 |
| Paths | 9 |
| Total Lines | 73 |
| Code Lines | 38 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 63 | function parseArgs($argv) |
||
| 64 | { |
||
| 65 | array_shift($argv); |
||
| 66 | $out = []; |
||
| 67 | for ($i = 0, $j = count($argv); $i < $j; $i++) |
||
| 68 | { |
||
| 69 | $arg = $argv[$i]; |
||
| 70 | // --foo --bar=baz |
||
| 71 | if (mb_substr($arg, 0, 2) === '--') |
||
| 72 | { |
||
| 73 | $eqPos = mb_strpos($arg, '='); |
||
| 74 | // --foo |
||
| 75 | if ($eqPos === false) |
||
| 76 | { |
||
| 77 | $key = mb_substr($arg, 2); |
||
| 78 | // --foo value |
||
| 79 | if ($i + 1 < $j && $argv[$i + 1][0] !== '-') |
||
| 80 | { |
||
| 81 | $value = $argv[$i + 1]; |
||
| 82 | $i++; |
||
| 83 | } |
||
| 84 | else |
||
| 85 | { |
||
| 86 | $value = isset($out[$key]) ? $out[$key] : true; |
||
| 87 | } |
||
| 88 | $out[$key] = $value; |
||
| 89 | } |
||
| 90 | // --bar=baz |
||
| 91 | else |
||
| 92 | { |
||
| 93 | $key = mb_substr($arg, 2, $eqPos - 2); |
||
| 94 | $value = mb_substr($arg, $eqPos + 1); |
||
| 95 | $out[$key] = $value; |
||
| 96 | } |
||
| 97 | } |
||
| 98 | // -k=value -abc |
||
| 99 | else if (mb_substr($arg, 0, 1) === '-') |
||
| 100 | { |
||
| 101 | // -k=value |
||
| 102 | $key = null; |
||
| 103 | if (mb_substr($arg, 2, 1) === '=') |
||
| 104 | { |
||
| 105 | $key = mb_substr($arg, 1, 1); |
||
| 106 | $value = mb_substr($arg, 3); |
||
| 107 | $out[$key] = $value; |
||
| 108 | } |
||
| 109 | // -abc |
||
| 110 | else |
||
| 111 | { |
||
| 112 | $chars = str_split(mb_substr($arg, 1)); |
||
| 113 | foreach ($chars as $char) |
||
| 114 | { |
||
| 115 | $key = $char; |
||
| 116 | $value = isset($out[$key]) ? $out[$key] : true; |
||
| 117 | $out[$key] = $value; |
||
| 118 | } |
||
| 119 | // -a value1 -abc value2 |
||
| 120 | if ($key && $i + 1 < $j && $argv[$i + 1][0] !== '-') |
||
| 121 | { |
||
| 122 | $out[$key] = $argv[$i + 1]; |
||
| 123 | $i++; |
||
| 124 | } |
||
| 125 | } |
||
| 126 | } |
||
| 127 | // plain-arg |
||
| 128 | else |
||
| 129 | { |
||
| 130 | $value = $arg; |
||
| 131 | $out[] = $value; |
||
| 132 | } |
||
| 133 | } |
||
| 134 | return $out; |
||
| 135 | } |
||
| 136 | |||
| 156 |