Issues in Tracker.php (master) - Issues in master - tequilarapido/trackit - Measure and Improve Code Quality continuously with Scrutinizer

Issues (8)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Tracker.php (4 issues)

Labels

Duplication 4

Severity

Informational 4

Nassif Bourguig 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Tequilarapido\TrackIt;

use Tequilarapido\TrackIt\Store\Store;

abstract class Tracker
{
    protected $uid = 'uid';

    protected $prefix = 'prefix';

    /** @var Store */
    protected $store;

    public function setUid($uid)
    {
        $this->uid = $uid;

        return $this;
    }

    public function setPrefix($prefix)
    {
        $this->prefix = $prefix;

        return $this;
    }

    protected function getFullKey($key)
    {
        return "{$this->prefix}:{$this->uid}:{$key}";
    }

    public function get($key)
    {
        return $this->store()->get($this->getFullKey($key));
    }

    public function set($key, $value)
    {
        $this->store()->set($this->getFullKey($key), $value);
    }

    public function jsonGet($key)
    {
        return json_decode($this->get($key), true);
    }

    public function jsonSet($key, $value)
    {
        $this->set($key, json_encode($value));
    }

    public function increment($key, $increment = 1)
    {
        $this->store()->increment($this->getFullKey($key), $increment);
    }

    public function exists($key)
    {
        return $this->store()->exists($key);
    }

    /** @return Store */
    public function store()
    {
        if (! $this->store) {
            $this->store = app()->make(Store::class);
        }

        return $this->store;
    }

    public function __call($method, $parameters)
    {
        // getSomething() -> get(const::SOMETHING)
        if (starts_with($method, 'get')) {
            return $this->dynamicGet($method);
        }

        // setSomething(value)
        if (starts_with($method, 'set')) {
            $this->dynamicSet($method, $parameters[0]);

            return;
        }

        // incrementSomething(value)
        if (starts_with($method, 'increment')) {
            $this->dynamicIncrement($method, $parameters);

            return;
        }

        // jsonGetSomething()
        if (starts_with($method, 'jsonGet')) {
            return $this->dynamicJsonGet($method);
        }

        // jsonSetSomething(value)
        if (starts_with($method, 'jsonSet')) {
            $this->dynamicJsonSet($method, $parameters[0]);

            return;
        }

        throw new UndefinedTrackerConstant("Uknown method called on tracker. [$method]");
    }

    protected function dynamicGet($method)

    {
        $key = strtoupper(str_after($method, 'get'));
        if (! defined("static::{$key}")) {
            throw new UndefinedTrackerConstant("Tracker: Undefined key constant [{$key}]");
        }

        return $this->get(constant("static::{$key}"));
    }

    protected function dynamicSet($method, $value)

    {
        $key = strtoupper(str_after($method, 'set'));
        if (! defined("static::{$key}")) {
            throw new UndefinedTrackerConstant("Tracker: Undefined key constant [{$key}]");
        }

        $this->set(constant("static::{$key}"), $value);
    }

    protected function dynamicJsonGet($method)

    {
        $key = strtoupper(str_after($method, 'jsonGet'));
        if (! defined("static::{$key}")) {
            throw new UndefinedTrackerConstant("Tracker: Undefined key constant [{$key}]");
        }

        return $this->jsonGet(constant("static::{$key}"));
    }

    protected function dynamicJsonSet($method, $value)

    {
        $key = strtoupper(str_after($method, 'jsonSet'));
        if (! defined("static::{$key}")) {
            throw new UndefinedTrackerConstant("Tracker: Undefined key constant [{$key}]");
        }

        $this->jsonSet(constant("static::{$key}"), $value);
    }

    protected function dynamicIncrement($method, $parameters)
    {
        $key = strtoupper(str_after($method, 'increment'));
        if (! defined("static::{$key}")) {
            throw new UndefinedTrackerConstant("Tracker: Undefined key constant [{$key}]");
        }

        if (isset($parameters[0])) {
            $this->increment(constant("static::{$key}"), $parameters[0]);
        } else {
            $this->increment(constant("static::{$key}"));
        }
    }
}


1			<?php
2
3			namespace Tequilarapido\TrackIt;
4
5			use Tequilarapido\TrackIt\Store\Store;
6
7			abstract class Tracker
8			{
9			protected $uid = 'uid';
10
11			protected $prefix = 'prefix';
12
13			/** @var Store */
14			protected $store;
15
16	8		public function setUid($uid)
17			{
18	8		$this->uid = $uid;
19
20	8		return $this;
21			}
22
23	8		public function setPrefix($prefix)
24			{
25	8		$this->prefix = $prefix;
26
27	8		return $this;
28			}
29
30	7		protected function getFullKey($key)
31			{
32	7		return "{$this->prefix}:{$this->uid}:{$key}";
33			}
34
35	6		public function get($key)
36			{
37	6		return $this->store()->get($this->getFullKey($key));
38			}
39
40	7		public function set($key, $value)
41			{
42	7		$this->store()->set($this->getFullKey($key), $value);
43	7		}
44
45	2		public function jsonGet($key)
46			{
47	2		return json_decode($this->get($key), true);
48			}
49
50	2		public function jsonSet($key, $value)
51			{
52	2		$this->set($key, json_encode($value));
53	2		}
54
55	3		public function increment($key, $increment = 1)
56			{
57	3		$this->store()->increment($this->getFullKey($key), $increment);
58	3		}
59
60	1		public function exists($key)
61			{
62	1		return $this->store()->exists($key);
63			}
64
65			/** @return Store */
66	7		public function store()
67			{
68	7		if (! $this->store) {
69	7		$this->store = app()->make(Store::class);
70			}
71
72	7		return $this->store;
73			}
74
75	3		public function __call($method, $parameters)
76			{
77			// getSomething() -> get(const::SOMETHING)
78	3		if (starts_with($method, 'get')) {
79	1		return $this->dynamicGet($method);
80			}
81
82			// setSomething(value)
83	3		if (starts_with($method, 'set')) {
84	2		$this->dynamicSet($method, $parameters[0]);
85
86	1		return;
87			}
88
89			// incrementSomething(value)
90	2		if (starts_with($method, 'increment')) {
91	1		$this->dynamicIncrement($method, $parameters);
92
93	1		return;
94			}
95
96			// jsonGetSomething()
97	1		if (starts_with($method, 'jsonGet')) {
98	1		return $this->dynamicJsonGet($method);
99			}
100
101			// jsonSetSomething(value)
102	1		if (starts_with($method, 'jsonSet')) {
103	1		$this->dynamicJsonSet($method, $parameters[0]);
104
105	1		return;
106			}
107
108			throw new UndefinedTrackerConstant("Uknown method called on tracker. [$method]");
109			}
110
111	1	View Code Duplication	protected function dynamicGet($method)
			0 ignored issues – show Duplication introduced 2018-03-12 07:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
112			{
113	1		$key = strtoupper(str_after($method, 'get'));
114	1		if (! defined("static::{$key}")) {
115			throw new UndefinedTrackerConstant("Tracker: Undefined key constant [{$key}]");
116			}
117
118	1		return $this->get(constant("static::{$key}"));
119			}
120
121	2	View Code Duplication	protected function dynamicSet($method, $value)
			0 ignored issues – show Duplication introduced 2018-03-12 07:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
122			{
123	2		$key = strtoupper(str_after($method, 'set'));
124	2		if (! defined("static::{$key}")) {
125	1		throw new UndefinedTrackerConstant("Tracker: Undefined key constant [{$key}]");
126			}
127
128	1		$this->set(constant("static::{$key}"), $value);
129	1		}
130
131	1	View Code Duplication	protected function dynamicJsonGet($method)
			0 ignored issues – show Duplication introduced 2018-03-12 07:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
132			{
133	1		$key = strtoupper(str_after($method, 'jsonGet'));
134	1		if (! defined("static::{$key}")) {
135			throw new UndefinedTrackerConstant("Tracker: Undefined key constant [{$key}]");
136			}
137
138	1		return $this->jsonGet(constant("static::{$key}"));
139			}
140
141	1	View Code Duplication	protected function dynamicJsonSet($method, $value)
			0 ignored issues – show Duplication introduced 2018-03-12 07:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
142			{
143	1		$key = strtoupper(str_after($method, 'jsonSet'));
144	1		if (! defined("static::{$key}")) {
145			throw new UndefinedTrackerConstant("Tracker: Undefined key constant [{$key}]");
146			}
147
148	1		$this->jsonSet(constant("static::{$key}"), $value);
149	1		}
150
151	1		protected function dynamicIncrement($method, $parameters)
152			{
153	1		$key = strtoupper(str_after($method, 'increment'));
154	1		if (! defined("static::{$key}")) {
155			throw new UndefinedTrackerConstant("Tracker: Undefined key constant [{$key}]");
156			}
157
158	1		if (isset($parameters[0])) {
159	1		$this->increment(constant("static::{$key}"), $parameters[0]);
160			} else {
161	1		$this->increment(constant("static::{$key}"));
162			}
163	1		}
164			}
165

tequilarapido / trackit

Issues (8)

Security Analysis no request data

src/Tracker.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like