DatabaseConvertToUtf8::setCharsetAndCollation() - Code Metrics - tequilarapido/appcli - Measure and Improve Code Quality continuously with Scrutinizer

DatabaseConvertToUtf8::setCharsetAndCollation() A
last analyzed 2016-10-06 13:29 UTC

↳ Parent: DatabaseConvertToUtf8

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	9

Duplication

Lines	16
Ratio	100 %

Importance

Changes

Metric	Value
dl	16
loc	16
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	9
nc	2
nop	2

<?php namespace Tequilarapido\Cli\Commands;

use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Tequilarapido\Cli\Commands\Base\AbstractDatabaseCommand;
use Tequilarapido\Database\Database;
use Tequilarapido\Database\Table;

class DatabaseConvertToUtf8 extends AbstractDatabaseCommand
{
    const CHARSET = 'utf8';
    const COLLATION = 'utf8_general_ci';

    protected $databaseTables;

    protected function configure()
    {
        parent::configure();

        $description = '';
        $description .= 'Converts database tables to utf8. ' . PHP_EOL;
        $description .= '  ';

        $this
            ->setName('db:utf8')
            ->setDescription($description);


    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        parent::execute($input, $output);

        // Database configuration
        $dbConfig = $this->config->getDatabase();
        $databaseName = $this->config->getDatabaseName();

        // Connection
        $this->db = new Database();
        $this->db->connect($dbConfig);

        // Tables
        $this->table = new Table();

        $this->databaseTables = $this->table->all($databaseName);

        // Set proper engine
        $this->setCharsetAndCollation(static::CHARSET, static::COLLATION);

        // Test out
        $isOK = $this->table->isCollation($databaseName, static::COLLATION);
        if ($isOK) {
            $this->output->success("Done. All table are now " . static::CHARSET . '/' . static::COLLATION);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        } else {
            $this->output->warn("Done. But not sure all tables are " . static::CHARSET . '/' . static::COLLATION);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        }
    }

    /**
     * @param string $charset
     * @param string $collation
     */
    protected function setCharsetAndCollation($charset, $collation)

    {
        $this->output->title("Setting database charset to $charset and collation to $collation");
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        // Cli progress setup
        $progress = $this->getHelperSet()->get('progress');
        $progress->start($this->output, count($this->databaseTables));

        foreach ($this->databaseTables as $tableName) {

            $this->output->info($tableName);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $this->table->alterCharsetAndCollation($tableName, $charset, $collation);
            $progress->advance();
        }
        $progress->finish();
    }

}

1		<?php namespace Tequilarapido\Cli\Commands;
2
3		use Symfony\Component\Console\Input\InputInterface;
4		use Symfony\Component\Console\Output\OutputInterface;
5		use Tequilarapido\Cli\Commands\Base\AbstractDatabaseCommand;
6		use Tequilarapido\Database\Database;
7		use Tequilarapido\Database\Table;
8
9		class DatabaseConvertToUtf8 extends AbstractDatabaseCommand
10		{
11		const CHARSET = 'utf8';
12		const COLLATION = 'utf8_general_ci';
13
14		protected $databaseTables;
15
16		protected function configure()
17		{
18		parent::configure();
19
20		$description = '';
21		$description .= 'Converts database tables to utf8. ' . PHP_EOL;
22		$description .= ' ';
23
24		$this
25		->setName('db:utf8')
26		->setDescription($description);
27
28
29		}
30
31		protected function execute(InputInterface $input, OutputInterface $output)
32		{
33		parent::execute($input, $output);
34
35		// Database configuration
36		$dbConfig = $this->config->getDatabase();
37		$databaseName = $this->config->getDatabaseName();
38
39		// Connection
40		$this->db = new Database();
41		$this->db->connect($dbConfig);
42
43		// Tables
44		$this->table = new Table();
		0 ignored issues – show Documentation Bug introduced 2016-10-06 10:37 UTC by Report Bug Copy Issue Report It seems like `new \Tequilarapido\Database\Table()` of type `object<Tequilarapido\Database\Table>` is incompatible with the declared type `object<Tequilarapido\Cli\Commands\Base\Table>` of property `$table`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
45		$this->databaseTables = $this->table->all($databaseName);
46
47		// Set proper engine
48		$this->setCharsetAndCollation(static::CHARSET, static::COLLATION);
49
50		// Test out
51		$isOK = $this->table->isCollation($databaseName, static::COLLATION);
52		if ($isOK) {
53		$this->output->success("Done. All table are now " . static::CHARSET . '/' . static::COLLATION);
		0 ignored issues – show Bug introduced 2016-10-06 10:37 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Console\Output\OutputInterface` as the method `success()` does only exist in the following implementations of said interface: `Tequilarapido\Cli\EnhancedOutput`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
54		} else {
55		$this->output->warn("Done. But not sure all tables are " . static::CHARSET . '/' . static::COLLATION);
		0 ignored issues – show Bug introduced 2016-10-06 10:37 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Console\Output\OutputInterface` as the method `warn()` does only exist in the following implementations of said interface: `Tequilarapido\Cli\EnhancedOutput`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
56		}
57		}
58
59		/**
60		* @param string $charset
61		* @param string $collation
62		*/
63	View Code Duplication	protected function setCharsetAndCollation($charset, $collation)
		0 ignored issues – show Duplication introduced 2016-10-06 10:37 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
64		{
65		$this->output->title("Setting database charset to $charset and collation to $collation");
		0 ignored issues – show Bug introduced 2016-10-06 10:37 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Console\Output\OutputInterface` as the method `title()` does only exist in the following implementations of said interface: `Tequilarapido\Cli\EnhancedOutput`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
66
67		// Cli progress setup
68		$progress = $this->getHelperSet()->get('progress');
69		$progress->start($this->output, count($this->databaseTables));
70
71		foreach ($this->databaseTables as $tableName) {
72
73		$this->output->info($tableName);
		0 ignored issues – show Bug introduced 2016-10-06 10:37 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Console\Output\OutputInterface` as the method `info()` does only exist in the following implementations of said interface: `Tequilarapido\Cli\EnhancedOutput`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
74		$this->table->alterCharsetAndCollation($tableName, $charset, $collation);
75		$progress->advance();
76		}
77		$progress->finish();
78		}
79
80		}

tequilarapido / appcli

DatabaseConvertToUtf8::setCharsetAndCollation() A last analyzed 2016-10-06 13:29 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

DatabaseConvertToUtf8::setCharsetAndCollation() A
last analyzed 2016-10-06 13:29 UTC