AbstractDatabaseCommand::outputGain() - Code Metrics - tequilarapido/appcli - Measure and Improve Code Quality continuously with Scrutinizer

AbstractDatabaseCommand::outputGain() A
last analyzed 2016-10-06 13:29 UTC

↳ Parent: AbstractDatabaseCommand

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	0

<?php namespace Tequilarapido\Cli\Commands\Base;


use Tequilarapido\Database\Database;

abstract class  AbstractDatabaseCommand extends AbstractConfigurableCommand
{

    protected $databaseName;
    protected $databasePrefix;

    /**
     * Database size (before and after) used in outputGain
     * @var array
     */
    protected $databaseSize = array();

    /**
     * @var Database
     */
    protected $db;

    /**
     * @var Table
     */
    protected $table;

    protected function setup()
    {
        // Database name
        $this->databaseName = $this->config->getDatabaseName();

        // Database tables prefix
        $this->databasePrefix = $this->config->getDatabasePrefix();

        // Golbal connection
        $this->db = new Database();
        $dbConfig = $this->config->getDatabase();
        $this->db->connect($dbConfig);
    }

    protected function outputGain()
    {
        $gain = $this->databaseSize['before'] - $this->databaseSize['after'];
        $percentGain = round(($gain * 100) / $this->databaseSize['before'], 2);
        $this->output->info();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $this->output->info("Database size: before=" . $this->databaseSize['before'] . "Mb -> after=" . $this->databaseSize['after'] . "Mb > Gain : " . $gain . "Mb (" . $percentGain . "%)");
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

}

AbstractDatabaseCommand::outputGain() A
last analyzed 2016-10-06 13:29 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php namespace Tequilarapido\Cli\Commands\Base;
2
3
4			use Tequilarapido\Database\Database;
5
6			abstract class AbstractDatabaseCommand extends AbstractConfigurableCommand
7			{
8
9			protected $databaseName;
10			protected $databasePrefix;
11
12			/**
13			* Database size (before and after) used in outputGain
14			* @var array
15			*/
16			protected $databaseSize = array();
17
18			/**
19			* @var Database
20			*/
21			protected $db;
22
23			/**
24			* @var Table
25			*/
26			protected $table;
27
28			protected function setup()
29			{
30			// Database name
31			$this->databaseName = $this->config->getDatabaseName();
32
33			// Database tables prefix
34			$this->databasePrefix = $this->config->getDatabasePrefix();
35
36			// Golbal connection
37			$this->db = new Database();
38			$dbConfig = $this->config->getDatabase();
39			$this->db->connect($dbConfig);
40			}
41
42			protected function outputGain()
43			{
44			$gain = $this->databaseSize['before'] - $this->databaseSize['after'];
45			$percentGain = round(($gain * 100) / $this->databaseSize['before'], 2);
46			$this->output->info();
			0 ignored issues – show Bug introduced 2016-10-06 10:37 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Console\Output\OutputInterface` as the method `info()` does only exist in the following implementations of said interface: `Tequilarapido\Cli\EnhancedOutput`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
47			$this->output->info("Database size: before=" . $this->databaseSize['before'] . "Mb -> after=" . $this->databaseSize['after'] . "Mb > Gain : " . $gain . "Mb (" . $percentGain . "%)");
			0 ignored issues – show Bug introduced 2016-10-06 10:37 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Console\Output\OutputInterface` as the method `info()` does only exist in the following implementations of said interface: `Tequilarapido\Cli\EnhancedOutput`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
48			}
49
50			}

tequilarapido / appcli

AbstractDatabaseCommand::outputGain() A last analyzed 2016-10-06 13:29 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

AbstractDatabaseCommand::outputGain() A
last analyzed 2016-10-06 13:29 UTC