COBUnknownBlock::Compile() - Code Metrics - Inspection of "Fix bugs with COB stuff" - telyn/c2ephp - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 108f3b...905b81 )

by Telyn

created 2018-01-28 11:09 UTC

COBUnknownBlock::Compile() A

↳ Parent: COBUnknownBlock

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php
require_once(dirname(__FILE__).'/COBBlock.php');

/// @brief Simple class to allow for extra block types.
class COBUnknownBlock extends COBBlock {

    /// @cond INTERNAL_DOCS
    
    private $contents;

    /// @endcond

    /// @brief Creates a new COBUnknown block with the given type and contents
    /**
     * @param $type The four-character type of the block
     * @param $contents The contents of the block
     */
    public function COBUnknownBlock($type, $contents) {

        parent::COBBlock($type);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /// @brief Returns the raw data back again
    /** @return string
     */
    public function Compile() {
        return $this->GetType() . $this->contents;
    }

    /// @brief Gets the block's contents
    public function GetContents() {
        return $this->contents;
    }
}
?>



1			<?php
2			require_once(dirname(__FILE__).'/COBBlock.php');
3
4			/// @brief Simple class to allow for extra block types.
5			class COBUnknownBlock extends COBBlock {
6
7			/// @cond INTERNAL_DOCS
8
9			private $contents;
10
11			/// @endcond
12
13			/// @brief Creates a new COBUnknown block with the given type and contents
14			/**
15			* @param $type The four-character type of the block
16			* @param $contents The contents of the block
17			*/
18			public function COBUnknownBlock($type, $contents) {
			0 ignored issues – show Unused Code introduced 2018-01-28 11:03 UTC by Report Bug Copy Issue Report The parameter `$contents` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
19			parent::COBBlock($type);
			0 ignored issues – show Comprehensibility Bug introduced 2016-10-26 17:17 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`COBBlock()` instead of `COBUnknownBlock()`). Are you sure this is correct? If so, you might want to change this to `$this->COBBlock()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
20			}
21
22			/// @brief Returns the raw data back again
23			/** @return string
24			*/
25			public function Compile() {
26			return $this->GetType() . $this->contents;
27			}
28
29			/// @brief Gets the block's contents
30			public function GetContents() {
31			return $this->contents;
32			}
33			}
34			?>
			0 ignored issues – show Best Practice introduced 2016-10-26 17:17 UTC by Report Bug Copy Issue Report It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
35

telyn / c2ephp

GitHub Access Token became invalid

Push — master ( 108f3b...905b81 )

COBUnknownBlock::Compile() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like