ArticleMapper::mapArticles() - Code Metrics - teiling88/scd16-unit-testing - Measure and Improve Code Quality continuously with Scrutinizer

ArticleMapper::mapArticles() C
last analyzed 2016-05-27 06:01 UTC

↳ Parent: ArticleMapper

Complexity

Conditions	11
Paths	26

Size

Total Lines	56
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	56
rs	6.5481
cc	11
eloc	31
nc	26
nop	1

How to fix Long Method Complexity

<?php

namespace TEiling\Scd16\Mapper;

use TEiling\Scd16\Config\ConfigInterface;
use TEiling\Scd16\Utils\ArticleUtil;

class ArticleMapper implements ArticleMapperInterface
{
    private $groupName;

    /** @var ConfigInterface */
    private $config;


    public function __construct(ConfigInterface $config)
    {
        $this->config = $config;
        $this->groupName = $this->config->getGroupName();

    }

    /**
     * @param array $csv
     *
     * @return array
     */
    public function mapArticles($csv)
    {
        $articles = [];
        foreach ($csv as $key => $entry) {
            if (strpos($entry['Artikelnummer'], '_1') !== false) {
                continue;
            }
            $article = $this->getArticleArray($entry);
            if ($csv[$key + 1]['Artikelnummer'] === $entry['Artikelnummer'] . '_1') {
                $secondLine = $csv[$key + 1];
                $secondLine['Artikelnummer'] = str_replace('_1', '', $secondLine['Artikelnummer']);
                $articleExtended = $this->getArticleArray($secondLine);

                $article['variants'] = array_merge($article['variants'], $articleExtended['variants']);

                $groupKeys = array_keys($article['configuratorSet']['groups']);
                if (is_array($groupKeys)) {
                    foreach ($groupKeys as $groupKey) {
                        $article['configuratorSet']['groups'][$groupKey]['options'] = array_merge(
                            $article['configuratorSet']['groups'][$groupKey]['options'],
                            $articleExtended['configuratorSet']['groups'][$groupKey]['options']
                        );
                    }
                }
            }
            // if in the first row no variant has a stock but the second row
            if ($article['mainDetail']['number'] === false && !empty($articleExtended['mainDetail']['number'])) {
                $article['mainDetail']['number'] = $articleExtended['mainDetail']['number'];
            }

            // we need at least one default order number ;-)
            if ($article['mainDetail']['number'] === false) {
                $stockArray = ArticleUtil::getKeyValueArray($entry['Bestand']);
                $article['mainDetail']['number'] = ArticleUtil::convertOrderNumber(
                    $entry['Artikelnummer'] . '-' . key($stockArray)
                );
                foreach ($article['variants'] as &$value) {
                    if ($value['number'] === $article['mainDetail']['number']) {
                        $value['isMain'] = true;
                        break;
                    }
                }
            }

            // testing category
            $article['categories'][] = [
                'id' => 4
            ];


            $articles[] = $article;
        }

        return $articles;

    }

    /**
     * @todo fixing magic number
     *
     * @param $article
     *
     * @return array
     */
    private function getArticleArray($article)
    {
        $articleArray = [
            'name' => $article['Hersteller'] . ' ' . $article['Modell'],
            'taxId' => 1,
            'active' => 1,
            'description' => $article['Notiz'],
            'lastStock' => $article['Abverkauf'],
            'supplier' => $article['Hersteller'],
            'mainDetail' => [
                'active' => 1,
                'inStock' => 0,
                'number' => ArticleUtil::getMainOrderNumber($article['Artikelnummer'], $article['Bestand']),
                'prices' => [
                    [
                        'customerGroupKey' => 'EK',
                        'price' => ArticleUtil::convertPrice($article['Preis']),
                        'pseudoPrice' => ArticleUtil::convertPrice($article['VKS'])
                    ],
                ]
            ]
        ];

        $this->attachArticleVariants($articleArray, $article);

        return $articleArray;
    }

    /**
     * @param $articleArray
     * @param $article
     */
    private function attachArticleVariants(&$articleArray, $article)
    {
        $stock = ArticleUtil::getKeyValueArray($article['Bestand']);

        if (key($stock) === '-') {
            return;
        }

        $ean = ArticleUtil::getKeyValueArray($article['EAN']);

        $groupOptions = [];
        $variants = [];

        foreach ($stock as $size => $value) {
            $variantNumber = ArticleUtil::convertOrderNumber($article['Artikelnummer'] . '-' . $size);
            $variants[] =
                [
                    'isMain' => $variantNumber === $articleArray['mainDetail']['number'],
                    'number' => $variantNumber,
                    'ean' => $ean[$size],
                    'active' => $stock[$size] > 0,
                    'inStock' => $stock[$size],
                    'additionalText' => $size,
                    'configuratorOptions' => [
                        [
                            'group' => $this->groupName,
                            'option' => $size
                        ]
                    ],
                    'prices' => [
                        [
                            'price' => ArticleUtil::convertPrice($article['Preis']),
                            'pseudoPrice' => ArticleUtil::convertPrice($article['VKS'])
                        ],
                    ],
                ];

            // add configurator set
            $groupOptions[] = ['name' => $size];

        }
        // add configurator set
        $articleArray['configuratorSet'] = [
            'type' => 1,
            'groups' => [
                [
                    'name' => $this->groupName,
                    'options' => $groupOptions
                ]
            ]
        ];

        $articleArray['variants'] = $variants;
    }
}


1			<?php
2
3			namespace TEiling\Scd16\Mapper;
4
5			use TEiling\Scd16\Config\ConfigInterface;
6			use TEiling\Scd16\Utils\ArticleUtil;
7
8			class ArticleMapper implements ArticleMapperInterface
9			{
10			private $groupName;
11
12			/** @var ConfigInterface */
13			private $config;
14
15
16			public function __construct(ConfigInterface $config)
17			{
18			$this->config = $config;
19			$this->groupName = $this->config->getGroupName();
20
21			}
22
23			/**
24			* @param array $csv
25			*
26			* @return array
27			*/
28			public function mapArticles($csv)
29			{
30			$articles = [];
31			foreach ($csv as $key => $entry) {
32			if (strpos($entry['Artikelnummer'], '_1') !== false) {
33			continue;
34			}
35			$article = $this->getArticleArray($entry);
36			if ($csv[$key + 1]['Artikelnummer'] === $entry['Artikelnummer'] . '_1') {
37			$secondLine = $csv[$key + 1];
38			$secondLine['Artikelnummer'] = str_replace('_1', '', $secondLine['Artikelnummer']);
39			$articleExtended = $this->getArticleArray($secondLine);
40
41			$article['variants'] = array_merge($article['variants'], $articleExtended['variants']);
42
43			$groupKeys = array_keys($article['configuratorSet']['groups']);
44			if (is_array($groupKeys)) {
45			foreach ($groupKeys as $groupKey) {
46			$article['configuratorSet']['groups'][$groupKey]['options'] = array_merge(
47			$article['configuratorSet']['groups'][$groupKey]['options'],
48			$articleExtended['configuratorSet']['groups'][$groupKey]['options']
49			);
50			}
51			}
52			}
53			// if in the first row no variant has a stock but the second row
54			if ($article['mainDetail']['number'] === false && !empty($articleExtended['mainDetail']['number'])) {
55			$article['mainDetail']['number'] = $articleExtended['mainDetail']['number'];
56			}
57
58			// we need at least one default order number ;-)
59			if ($article['mainDetail']['number'] === false) {
60			$stockArray = ArticleUtil::getKeyValueArray($entry['Bestand']);
61			$article['mainDetail']['number'] = ArticleUtil::convertOrderNumber(
62			$entry['Artikelnummer'] . '-' . key($stockArray)
63			);
64			foreach ($article['variants'] as &$value) {
65			if ($value['number'] === $article['mainDetail']['number']) {
66			$value['isMain'] = true;
67			break;
68			}
69			}
70			}
71
72			// testing category
73			$article['categories'][] = [
74			'id' => 4
75			];
76
77
78			$articles[] = $article;
79			}
80
81			return $articles;
82
83			}
84
85			/**
86			* @todo fixing magic number
87			*
88			* @param $article
89			*
90			* @return array
91			*/
92			private function getArticleArray($article)
93			{
94			$articleArray = [
95			'name' => $article['Hersteller'] . ' ' . $article['Modell'],
96			'taxId' => 1,
97			'active' => 1,
98			'description' => $article['Notiz'],
99			'lastStock' => $article['Abverkauf'],
100			'supplier' => $article['Hersteller'],
101			'mainDetail' => [
102			'active' => 1,
103			'inStock' => 0,
104			'number' => ArticleUtil::getMainOrderNumber($article['Artikelnummer'], $article['Bestand']),
105			'prices' => [
106			[
107			'customerGroupKey' => 'EK',
108			'price' => ArticleUtil::convertPrice($article['Preis']),
109			'pseudoPrice' => ArticleUtil::convertPrice($article['VKS'])
110			],
111			]
112			]
113			];
114
115			$this->attachArticleVariants($articleArray, $article);
116
117			return $articleArray;
118			}
119
120			/**
121			* @param $articleArray
122			* @param $article
123			*/
124			private function attachArticleVariants(&$articleArray, $article)
125			{
126			$stock = ArticleUtil::getKeyValueArray($article['Bestand']);
127
128			if (key($stock) === '-') {
129			return;
130			}
131
132			$ean = ArticleUtil::getKeyValueArray($article['EAN']);
133
134			$groupOptions = [];
135			$variants = [];
136
137			foreach ($stock as $size => $value) {
138			$variantNumber = ArticleUtil::convertOrderNumber($article['Artikelnummer'] . '-' . $size);
139			$variants[] =
140			[
141			'isMain' => $variantNumber === $articleArray['mainDetail']['number'],
142			'number' => $variantNumber,
143			'ean' => $ean[$size],
144			'active' => $stock[$size] > 0,
145			'inStock' => $stock[$size],
146			'additionalText' => $size,
147			'configuratorOptions' => [
148			[
149			'group' => $this->groupName,
150			'option' => $size
151			]
152			],
153			'prices' => [
154			[
155			'price' => ArticleUtil::convertPrice($article['Preis']),
156			'pseudoPrice' => ArticleUtil::convertPrice($article['VKS'])
157			],
158			],
159			];
160
161			// add configurator set
162			$groupOptions[] = ['name' => $size];
163
164			}
165			// add configurator set
166			$articleArray['configuratorSet'] = [
167			'type' => 1,
168			'groups' => [
169			[
170			'name' => $this->groupName,
171			'options' => $groupOptions
172			]
173			]
174			];
175
176			$articleArray['variants'] = $variants;
177			}
178			}
179

teiling88 / scd16-unit-testing

ArticleMapper::mapArticles() C last analyzed 2016-05-27 06:01 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like

ArticleMapper::mapArticles() C
last analyzed 2016-05-27 06:01 UTC