Code Duplication - techork/amadeus-ws-client - Measure and Improve Code Quality continuously with Scrutinizer

Code Duplication Length = 9-10 lines in 6 locations

src/Amadeus/Client/ResponseHandler/PNR/HandlerDisplayHistory.php 1 location



        $errorCodeNodeList = $domXpath->query($queryAllErrorCodes);

        if ($errorCodeNodeList->length > 0) {
            $analyzeResponse->status = Result::STATUS_ERROR;

            $code = $errorCodeNodeList->item(0)->nodeValue;
            $errorTextNodeList = $domXpath->query($queryAllErrorMsg);
            $message = $this->makeMessageFromMessagesNodeList($errorTextNodeList);

            $analyzeResponse->messages[] = new Result\NotOk($code, trim($message));
        }

        return $analyzeResponse;
    }

src/Amadeus/Client/ResponseHandler/PNR/HandlerRetrieve.php 5 locations


        //General Errors:
        $errorCodeNodeList = $domXpath->query(self::Q_G_ERR);

        if ($errorCodeNodeList->length > 0) {
            $analyzeResponse->status = Result::STATUS_ERROR;

            $code = $errorCodeNodeList->item(0)->nodeValue;
            $errorTextNodeList = $domXpath->query(self::Q_G_MSG);
            $message = $this->makeMessageFromMessagesNodeList($errorTextNodeList);

            $analyzeResponse->messages[] = new Result\NotOk($code, trim($message), 'general');
        }

        //General Errors - PNR_Reply v 14.1 and below:
        $errorCodeNodeList = $domXpath->query(self::Q_G_OLD_ERR);

        //General Errors - PNR_Reply v 14.1 and below:
        $errorCodeNodeList = $domXpath->query(self::Q_G_OLD_ERR);

        if ($errorCodeNodeList->length > 0) {
            $analyzeResponse->status = Result::STATUS_ERROR;

            $code = $errorCodeNodeList->item(0)->nodeValue;
            $errorTextNodeList = $domXpath->query(self::Q_G_OLD_MSG);
            $message = $this->makeMessageFromMessagesNodeList($errorTextNodeList);

            $analyzeResponse->messages[] = new Result\NotOk($code, trim($message), 'general');
        }

        //Passenger error
        $errorCodeNodeList = $domXpath->query(self::Q_P_ERR);

        //Passenger error
        $errorCodeNodeList = $domXpath->query(self::Q_P_ERR);

        if ($errorCodeNodeList->length > 0) {
            $analyzeResponse->status = Result::STATUS_ERROR;

            $code = $errorCodeNodeList->item(0)->nodeValue;
            $errorTextNodeList = $domXpath->query(self::Q_P_MSG);
            $message = $this->makeMessageFromMessagesNodeList($errorTextNodeList);

            $analyzeResponse->messages[] = new Result\NotOk($code, trim($message), 'passenger');
        }

        //Segment errors:
        $errorCodeNodeList = $domXpath->query(self::Q_S_ERR);

        //Segment errors:
        $errorCodeNodeList = $domXpath->query(self::Q_S_ERR);

        if ($errorCodeNodeList->length > 0) {
            $analyzeResponse->status = Result::STATUS_ERROR;

            $code = $errorCodeNodeList->item(0)->nodeValue;
            $errorTextNodeList = $domXpath->query(self::Q_S_MSG);
            $message = $this->makeMessageFromMessagesNodeList($errorTextNodeList);

            $analyzeResponse->messages[] = new Result\NotOk($code, trim($message), 'segment');
        }

        //Element errors:
        $errorCodeNodeList = $domXpath->query(self::Q_E_ERR);

        //Element errors:
        $errorCodeNodeList = $domXpath->query(self::Q_E_ERR);

        if ($errorCodeNodeList->length > 0) {
            $analyzeResponse->status = Result::STATUS_ERROR;

            $code = $errorCodeNodeList->item(0)->nodeValue;

            $errorTextNodeList = $domXpath->query(self::Q_E_MSG);
            $message = $this->makeMessageFromMessagesNodeList($errorTextNodeList);

            $analyzeResponse->messages[] = new Result\NotOk($code, trim($message), 'element');
        }

        return $analyzeResponse;
    }

		@@ 54-62 (lines=9) @@
51
52		$errorCodeNodeList = $domXpath->query($queryAllErrorCodes);
53
54		if ($errorCodeNodeList->length > 0) {
55		$analyzeResponse->status = Result::STATUS_ERROR;
56
57		$code = $errorCodeNodeList->item(0)->nodeValue;
58		$errorTextNodeList = $domXpath->query($queryAllErrorMsg);
59		$message = $this->makeMessageFromMessagesNodeList($errorTextNodeList);
60
61		$analyzeResponse->messages[] = new Result\NotOk($code, trim($message));
62		}
63
64		return $analyzeResponse;
65		}

		@@ 63-71 (lines=9) @@
60		//General Errors:
61		$errorCodeNodeList = $domXpath->query(self::Q_G_ERR);
62
63		if ($errorCodeNodeList->length > 0) {
64		$analyzeResponse->status = Result::STATUS_ERROR;
65
66		$code = $errorCodeNodeList->item(0)->nodeValue;
67		$errorTextNodeList = $domXpath->query(self::Q_G_MSG);
68		$message = $this->makeMessageFromMessagesNodeList($errorTextNodeList);
69
70		$analyzeResponse->messages[] = new Result\NotOk($code, trim($message), 'general');
71		}
72
73		//General Errors - PNR_Reply v 14.1 and below:
74		$errorCodeNodeList = $domXpath->query(self::Q_G_OLD_ERR);
		@@ 76-84 (lines=9) @@
73		//General Errors - PNR_Reply v 14.1 and below:
74		$errorCodeNodeList = $domXpath->query(self::Q_G_OLD_ERR);
75
76		if ($errorCodeNodeList->length > 0) {
77		$analyzeResponse->status = Result::STATUS_ERROR;
78
79		$code = $errorCodeNodeList->item(0)->nodeValue;
80		$errorTextNodeList = $domXpath->query(self::Q_G_OLD_MSG);
81		$message = $this->makeMessageFromMessagesNodeList($errorTextNodeList);
82
83		$analyzeResponse->messages[] = new Result\NotOk($code, trim($message), 'general');
84		}
85
86		//Passenger error
87		$errorCodeNodeList = $domXpath->query(self::Q_P_ERR);
		@@ 89-97 (lines=9) @@
86		//Passenger error
87		$errorCodeNodeList = $domXpath->query(self::Q_P_ERR);
88
89		if ($errorCodeNodeList->length > 0) {
90		$analyzeResponse->status = Result::STATUS_ERROR;
91
92		$code = $errorCodeNodeList->item(0)->nodeValue;
93		$errorTextNodeList = $domXpath->query(self::Q_P_MSG);
94		$message = $this->makeMessageFromMessagesNodeList($errorTextNodeList);
95
96		$analyzeResponse->messages[] = new Result\NotOk($code, trim($message), 'passenger');
97		}
98
99		//Segment errors:
100		$errorCodeNodeList = $domXpath->query(self::Q_S_ERR);
		@@ 102-110 (lines=9) @@
99		//Segment errors:
100		$errorCodeNodeList = $domXpath->query(self::Q_S_ERR);
101
102		if ($errorCodeNodeList->length > 0) {
103		$analyzeResponse->status = Result::STATUS_ERROR;
104
105		$code = $errorCodeNodeList->item(0)->nodeValue;
106		$errorTextNodeList = $domXpath->query(self::Q_S_MSG);
107		$message = $this->makeMessageFromMessagesNodeList($errorTextNodeList);
108
109		$analyzeResponse->messages[] = new Result\NotOk($code, trim($message), 'segment');
110		}
111
112		//Element errors:
113		$errorCodeNodeList = $domXpath->query(self::Q_E_ERR);
		@@ 115-124 (lines=10) @@
112		//Element errors:
113		$errorCodeNodeList = $domXpath->query(self::Q_E_ERR);
114
115		if ($errorCodeNodeList->length > 0) {
116		$analyzeResponse->status = Result::STATUS_ERROR;
117
118		$code = $errorCodeNodeList->item(0)->nodeValue;
119
120		$errorTextNodeList = $domXpath->query(self::Q_E_MSG);
121		$message = $this->makeMessageFromMessagesNodeList($errorTextNodeList);
122
123		$analyzeResponse->messages[] = new Result\NotOk($code, trim($message), 'element');
124		}
125
126		return $analyzeResponse;
127		}

techork / amadeus-ws-client

Code Duplication Length = 9-10 lines in 6 locations

src/Amadeus/Client/ResponseHandler/PNR/HandlerDisplayHistory.php 1 location

src/Amadeus/Client/ResponseHandler/PNR/HandlerRetrieve.php 5 locations