FlightInfo::__construct()   B
last analyzed

Complexity

Conditions 9
Paths 128

Size

Total Lines 39

Duplication

Lines 3
Ratio 7.69 %

Importance

Changes 0
Metric Value
dl 3
loc 39
rs 7.5537
c 0
b 0
f 0
cc 9
nc 128
nop 8

How to fix   Many Parameters   

Many Parameters

Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.

There are several approaches to avoid long parameter lists:

1
<?php
2
/**
3
 * amadeus-ws-client
4
 *
5
 * Copyright 2015 Amadeus Benelux NV
6
 *
7
 * Licensed under the Apache License, Version 2.0 (the "License");
8
 * you may not use this file except in compliance with the License.
9
 * You may obtain a copy of the License at
10
 *
11
 * http://www.apache.org/licenses/LICENSE-2.0
12
 *
13
 * Unless required by applicable law or agreed to in writing, software
14
 * distributed under the License is distributed on an "AS IS" BASIS,
15
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16
 * See the License for the specific language governing permissions and
17
 * limitations under the License.
18
 *
19
 * @package Amadeus
20
 * @license https://opensource.org/licenses/Apache-2.0 Apache 2.0
21
 */
22
23
namespace Amadeus\Client\Struct\Fare\MasterPricer;
24
25
/**
26
 * FlightInfo
27
 *
28
 * @package Amadeus\Client\Struct\Fare\MasterPricer
29
 * @author Dieter Devlieghere <[email protected]>
30
 */
31
class FlightInfo
32
{
33
    /**
34
     * @var CabinId
35
     */
36
    public $cabinId;
37
38
    /**
39
     * @var CompanyIdentity[]
40
     */
41
    public $companyIdentity = [];
42
43
    /**
44
     * @var FlightDetail
45
     */
46
    public $flightDetail;
47
48
    /**
49
     * @var InclusionDetail[]
50
     */
51
    public $inclusionDetail = [];
52
53
    /**
54
     * @var ExclusionDetail[]
55
     */
56
    public $exclusionDetail = [];
57
58
    /**
59
     * @var UnitNumberDetail[]
60
     */
61
    public $unitNumberDetail = [];
62
63
    /**
64
     * FlightInfo constructor.
65
     *
66
     * @param array $airlineOptions
67
     * @param array $flightTypes
68
     * @param array $includedConnections
69
     * @param array $excludedConnections
70
     * @param int|null $connections
71
     * @param bool $noAirportChange
72
     * @param string|null $cabinCode CabinId::CABIN_*
73
     * @param string|null $cabinOption CabinId::CABINOPT_*
74
     */
75
    public function __construct(
76
        array $airlineOptions,
77
        array $flightTypes,
78
        array $includedConnections = [],
79
        array $excludedConnections = [],
80
        $connections = null,
81
        $noAirportChange = false,
82
        $cabinCode = null,
83
        $cabinOption = null
84
    ) {
85
        foreach ($airlineOptions as $qualifier => $airlines) {
86
            $this->companyIdentity[] = new CompanyIdentity(
87
                $qualifier,
88
                $airlines
89
            );
90
        }
91
92
        if (!empty($flightTypes)) {
93
            $this->flightDetail = new FlightDetail($flightTypes);
94
        }
95
96
        foreach ($includedConnections as $includedConnection) {
97
            $this->inclusionDetail[] = new InclusionDetail($includedConnection);
98
        }
99
        foreach ($excludedConnections as $excludedConnection) {
100
            $this->exclusionDetail[] = new ExclusionDetail($excludedConnection);
101
        }
102
103
        if (!is_null($connections)) {
104
            $this->unitNumberDetail[] = new UnitNumberDetail($connections, UnitNumberDetail::TYPE_NUM_OF_CONNECTIONS_ALLOWED);
105
        }
106
107
        if ($noAirportChange === true) {
108
            $this->unitNumberDetail[] = new UnitNumberDetail(1, UnitNumberDetail::TYPE_NO_AIRPORT_CHANGE);
109
        }
110 View Code Duplication
        if (!is_null($cabinCode) || !is_null($cabinOption)) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
111
            $this->cabinId = new CabinId($cabinCode, $cabinOption);
112
        }
113
    }
114
}
115