Issues in BooleanValidatorCallback.php - All Issues - Inspection of "Changelog.md" - techdivision/import - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d07a45...da6ba5 )

unknown

created 2021-04-29 05:44 UTC

src/Callbacks/BooleanValidatorCallback.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * TechDivision\Import\Callbacks\BooleanValidatorCallback
 *
 * NOTICE OF LICENSE
 *
 * This source file is subject to the Open Software License (OSL 3.0)
 * that is available through the world-wide-web at this URL:
 * http://opensource.org/licenses/osl-3.0.php
 *
 * PHP version 5
 *
 * @author    Tim Wagner <[email protected]>
 * @copyright 2019 TechDivision GmbH <[email protected]>
 * @license   http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
 * @link      https://github.com/techdivision/import-product
 * @link      http://www.techdivision.com
 */

namespace TechDivision\Import\Callbacks;

/**
 * A callback implementation that validates the option values of EAV boolean attributes.
 *
 * @author    Tim Wagner <[email protected]>
 * @copyright 2019 TechDivision GmbH <[email protected]>
 * @license   http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
 * @link      https://github.com/techdivision/import-product
 * @link      http://www.techdivision.com
 */
class BooleanValidatorCallback extends ArrayValidatorCallback

{

    /**
     * Will be invoked by the observer it has been registered for.
     *
     * @param string|null $attributeCode  The code of the attribute that has to be validated
     * @param string|null $attributeValue The attribute value to be validated
     *
     * @return mixed The modified value
     */
    public function handle($attributeCode = null, $attributeValue = null)
    {

        // load the subject instance
        $subject = $this->getSubject();

        // explode the additional attributes
        if ($this->isNullable($optionValues = $subject->explode($attributeValue, '='))) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            return;
        }

        // load the validations
        $validations = $this->getValidations($attributeCode);

        // iterate over the attributes and append them to the row
        foreach ($optionValues as $optionValue) {
            // query whether or not a boolean value has been specified
            if (in_array(strtolower($optionValue), $validations)) {
                continue;
            }

            // throw an exception if the value is NOT in the array
            throw new \InvalidArgumentException(
                sprintf('Found invalid boolean value "%s" for attribute with code "%s"', $optionValue, $attributeCode)
            );
        }
    }
}


1		<?php
2
3		/**
4		* TechDivision\Import\Callbacks\BooleanValidatorCallback
5		*
6		* NOTICE OF LICENSE
7		*
8		* This source file is subject to the Open Software License (OSL 3.0)
9		* that is available through the world-wide-web at this URL:
10		* http://opensource.org/licenses/osl-3.0.php
11		*
12		* PHP version 5
13		*
14		* @author Tim Wagner <[email protected]>
15		* @copyright 2019 TechDivision GmbH <[email protected]>
16		* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
17		* @link https://github.com/techdivision/import-product
18		* @link http://www.techdivision.com
19		*/
20
21		namespace TechDivision\Import\Callbacks;
22
23		/**
24		* A callback implementation that validates the option values of EAV boolean attributes.
25		*
26		* @author Tim Wagner <[email protected]>
27		* @copyright 2019 TechDivision GmbH <[email protected]>
28		* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
29		* @link https://github.com/techdivision/import-product
30		* @link http://www.techdivision.com
31		*/
32	View Code Duplication	class BooleanValidatorCallback extends ArrayValidatorCallback
		0 ignored issues – show Duplication introduced 2019-10-28 10:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
33		{
34
35		/**
36		* Will be invoked by the observer it has been registered for.
37		*
38		* @param string\|null $attributeCode The code of the attribute that has to be validated
39		* @param string\|null $attributeValue The attribute value to be validated
40		*
41		* @return mixed The modified value
42		*/
43		public function handle($attributeCode = null, $attributeValue = null)
44		{
45
46		// load the subject instance
47		$subject = $this->getSubject();
48
49		// explode the additional attributes
50		if ($this->isNullable($optionValues = $subject->explode($attributeValue, '='))) {
		0 ignored issues – show Documentation introduced 2019-10-28 10:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$optionValues = $subject...e($attributeValue, '=')` is of type `array`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
51		return;
52		}
53
54		// load the validations
55		$validations = $this->getValidations($attributeCode);
56
57		// iterate over the attributes and append them to the row
58		foreach ($optionValues as $optionValue) {
59		// query whether or not a boolean value has been specified
60		if (in_array(strtolower($optionValue), $validations)) {
61		continue;
62		}
63
64		// throw an exception if the value is NOT in the array
65		throw new \InvalidArgumentException(
66		sprintf('Found invalid boolean value "%s" for attribute with code "%s"', $optionValue, $attributeCode)
67		);
68		}
69		}
70		}
71

techdivision / import

Push — master ( d07a45...da6ba5 )

src/Callbacks/BooleanValidatorCallback.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like