SelectValidatorCallback - Code Metrics - Inspection of "Add functionality to render recommendations for pe..." - techdivision/import - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 15.x ( 1a3897...0b1d63 )

by Tim

created 2019-10-28 10:07 UTC

SelectValidatorCallback A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	38
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	4
lcom	1
cbo	2
dl	38
loc	38
ccs	0
cts	16
cp	0
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	handle()	26	26	4

How to fix Duplicated Code

<?php

/**
 * TechDivision\Import\Callbacks\SelectValidatorCallback
 *
 * NOTICE OF LICENSE
 *
 * This source file is subject to the Open Software License (OSL 3.0)
 * that is available through the world-wide-web at this URL:
 * http://opensource.org/licenses/osl-3.0.php
 *
 * PHP version 5
 *
 * @author    Tim Wagner <[email protected]>
 * @copyright 2019 TechDivision GmbH <[email protected]>
 * @license   http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
 * @link      https://github.com/techdivision/import-product
 * @link      http://www.techdivision.com
 */

namespace TechDivision\Import\Callbacks;

/**
 * A callback implementation that validates the option values of EAV select attributes.
 *
 * @author    Tim Wagner <[email protected]>
 * @copyright 2019 TechDivision GmbH <[email protected]>
 * @license   http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
 * @link      https://github.com/techdivision/import-product
 * @link      http://www.techdivision.com
 */
class SelectValidatorCallback extends IndexedArrayValidatorCallback

{

    /**
     * Will be invoked by the observer it has been registered for.
     *
     * @param string|null $attributeCode  The code of the attribute that has to be validated
     * @param string|null $attributeValue The attribute value to be validated
     *
     * @return mixed The modified value
     */
    public function handle($attributeCode = null, $attributeValue = null)
    {

        // load the subject instance
        $subject = $this->getSubject();

        // explode the additional attributes
        if ($this->isNullable($optionValues = $subject->explode($attributeValue, '='))) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            return;
        }

        $validations = $this->getValidations($attributeCode);

        // iterate over the attributes and append them to the row
        foreach ($optionValues as $optionValue) {

            if (in_array($optionValue, $validations)) {
                continue;
            }

            // throw an exception if the value is NOT in the array
            throw new \InvalidArgumentException(
                sprintf('Found invalid option value "%s" for attribute with code "%s"', $optionValue, $attributeCode)
            );
        }
    }
}


1		<?php
2
3		/**
4		* TechDivision\Import\Callbacks\SelectValidatorCallback
5		*
6		* NOTICE OF LICENSE
7		*
8		* This source file is subject to the Open Software License (OSL 3.0)
9		* that is available through the world-wide-web at this URL:
10		* http://opensource.org/licenses/osl-3.0.php
11		*
12		* PHP version 5
13		*
14		* @author Tim Wagner <[email protected]>
15		* @copyright 2019 TechDivision GmbH <[email protected]>
16		* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
17		* @link https://github.com/techdivision/import-product
18		* @link http://www.techdivision.com
19		*/
20
21		namespace TechDivision\Import\Callbacks;
22
23		/**
24		* A callback implementation that validates the option values of EAV select attributes.
25		*
26		* @author Tim Wagner <[email protected]>
27		* @copyright 2019 TechDivision GmbH <[email protected]>
28		* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
29		* @link https://github.com/techdivision/import-product
30		* @link http://www.techdivision.com
31		*/
32	View Code Duplication	class SelectValidatorCallback extends IndexedArrayValidatorCallback
		0 ignored issues – show Duplication introduced 2019-10-28 10:10 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
33		{
34
35		/**
36		* Will be invoked by the observer it has been registered for.
37		*
38		* @param string\|null $attributeCode The code of the attribute that has to be validated
39		* @param string\|null $attributeValue The attribute value to be validated
40		*
41		* @return mixed The modified value
42		*/
43		public function handle($attributeCode = null, $attributeValue = null)
44		{
45
46		// load the subject instance
47		$subject = $this->getSubject();
48
49		// explode the additional attributes
50		if ($this->isNullable($optionValues = $subject->explode($attributeValue, '='))) {
		0 ignored issues – show Documentation introduced 2019-10-28 10:10 UTC by Report Bug Copy Issue Report `$optionValues = $subject...e($attributeValue, '=')` is of type `array`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
51		return;
52		}
53
54		$validations = $this->getValidations($attributeCode);
55
56		// iterate over the attributes and append them to the row
57		foreach ($optionValues as $optionValue) {
58
59		if (in_array($optionValue, $validations)) {
60		continue;
61		}
62
63		// throw an exception if the value is NOT in the array
64		throw new \InvalidArgumentException(
65		sprintf('Found invalid option value "%s" for attribute with code "%s"', $optionValue, $attributeCode)
66		);
67		}
68		}
69		}
70

techdivision / import

Push — 15.x ( 1a3897...0b1d63 )

SelectValidatorCallback A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like