CategoryAssembler::getCategoriesWithResolvedPathByStoreView()

Complexity

Conditions	6
Paths	5

Size

Total Lines

37

Duplication

Lines	37
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	42

Importance

Changes

0

<?php
    public function getCategoriesWithResolvedPathByStoreView($storeViewId)

This method seems to be duplicated in your project.

    {
        // prepare the categories
        $categories = array();

        // load the categories from the database
        $availableCategories = $this->categoryRepository->findAllByStoreView($storeViewId);

        // create the array with the resolved category path as keys
        foreach ($availableCategories as $category) {
            // expload the entity IDs from the category path
            $entityIds = explode('/', $category[MemberNames::PATH]);

            // cut-off the root category
            array_shift($entityIds);

            // continue with the next category if no entity IDs are available
            if (sizeof($entityIds) === 0) {
                continue;
            }

            // initialize the array for the path elements
            $path = array();
            foreach ($entityIds as $entityId) {
                $cat = $this->categoryVarcharRepository->findByEntityId($entityId);
                if ($cat && $cat[MemberNames::VALUE]) {

The expression $cat of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                    $path[] = $cat[MemberNames::VALUE];
                }
            }

            // append the catogory with the string path as key
            $categories[implode('/', $path)] = $category;
        }

        // return array with the categories
        return $categories;
    }
}