TechDivision\Import\Handlers\OkFileHandlerFactory

Complexity

Total Complexity

5

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	getContainer()	0	4	1
A	getLoaderFactory()	0	4	1
A	createHandler()	0	23	2

<?php

/**
 * TechDivision\Import\Handlers\OkFileHandlerFactory
 *
 * NOTICE OF LICENSE
 *
 * This source file is subject to the Open Software License (OSL 3.0)
 * that is available through the world-wide-web at this URL:
 * http://opensource.org/licenses/osl-3.0.php
 *
 * PHP version 5
 *
 * @author    Tim Wagner <t.wagner@techdivision.com>
 * @copyright 2020 TechDivision GmbH <info@techdivision.com>
 * @license   http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
 * @link      https://github.com/techdivision/import
 * @link      http://www.techdivision.com
 */

namespace TechDivision\Import\Handlers;

use TechDivision\Import\Loaders\LoaderFactoryInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;
use TechDivision\Import\Adapter\FilesystemAdapterFactoryInterface;
use TechDivision\Import\Configuration\SubjectConfigurationInterface;

/**
 * A .OK file handler factory implementation.
 *
 * @author    Tim Wagner <t.wagner@techdivision.com>
 * @copyright 2020 TechDivision GmbH <info@techdivision.com>
 * @license   http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
 * @link      https://github.com/techdivision/import
 * @link      http://www.techdivision.com
 */
class OkFileHandlerFactory implements HandlerFactoryInterface
{

    /**
     * The DI container instance.
     *
     * @var \Symfony\Component\DependencyInjection\ContainerInterface
     */
    private $container;

    /**
     * The loader factory instance used to create the loader for the proposed .OK filenames.
     *
     * @var \TechDivision\Import\Loaders\LoaderFactoryInterface
     */
    private $loaderFactory;

    /**
     * Initialize the factory with the DI container instance.
     *
     * @param \Symfony\Component\DependencyInjection\ContainerInterface $container     The DI container instance
     * @param \TechDivision\Import\Loaders\LoaderFactoryInterface       $loaderFactory The loader factory instance used to create the loader for the proposed .OK filenames
     */
    public function __construct(
        ContainerInterface $container,
        LoaderFactoryInterface $loaderFactory
    ) {
        $this->container = $container;
        $this->loaderFactory = $loaderFactory;
    }

    /**
     * Return's the container instance.
     *
     * @return \Symfony\Component\DependencyInjection\ContainerInterface The container instance
     */
    protected function getContainer() : ContainerInterface
    {
        return $this->container;
    }

    /**
     * Return's the loader factory instance.
     *
     * @return  \TechDivision\Import\Loaders\LoaderFactoryInterface The loader factory instance
     */
    protected function getLoaderFactory() : LoaderFactoryInterface
    {
        return $this->loaderFactory;
    }

    /**
     * Create's and return's a new handler instance.
     *
     * @return \TechDivision\Import\Handlers\HandlerInterface|null The new handler instance
     */
    public function createHandler(SubjectConfigurationInterface $subject = null) : HandlerInterface
    {

        // load the proposed .OK file loader
        $proposedOkFileLoader = $this->getLoaderFactory()->createLoader($subject);

The call to LoaderFactoryInterface::createLoader() has too many arguments starting with $subject.

        // load the filesystem adapter instance
        $filesystemAdapter = $this->getContainer()->get($subject->getFilesystemAdapter()->getId());

It seems like $subject is not always an object, but can also be of type null. Maybe add an additional type check?

        // query whether or not we've a factory instance
        if ($filesystemAdapter instanceof FilesystemAdapterFactoryInterface) {
            $filesystemAdapter = $filesystemAdapter->createFilesystemAdapter($subject);

It seems like $subject defined by parameter $subject on line 93 can be null; however, TechDivision\Import\Adapter\FilesystemAdapterFactoryInterface::createFilesystemAdapter() does not accept null, maybe add an additional type check?

        }

        // create a new .OK file handler instance
        $handler = new OkFileHandler();
        $handler->setLoader($proposedOkFileLoader);

$proposedOkFileLoader of type object<TechDivision\Import\Loaders\LoaderInterface> is not a sub-type of object<TechDivision\Import\Loaders\FilteredLoaderInterface>. It seems like you assume a child interface of the interface TechDivision\Import\Loaders\LoaderInterface to be always present.

        $handler->setFilesystemAdapter($filesystemAdapter);

$filesystemAdapter is of type object|null, but the function expects a object<TechDivision\Import\Adapter\FilesystemAdapterInterface>.

        $handler->setFileResolverConfiguration($subject->getFileResolver());

        // return the new .OK file handler instance
        return $handler;
    }
}