Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
39 | View Code Duplication | class CustomerGroupRepository extends AbstractRepository implements CustomerGroupRepositoryInterface |
|
|
|||
40 | { |
||
41 | |||
42 | /** |
||
43 | * The prepared statement to load the customer groups. |
||
44 | * |
||
45 | * @var \PDOStatement |
||
46 | */ |
||
47 | protected $customerGroupsStmt; |
||
48 | |||
49 | /** |
||
50 | * Initializes the repository's prepared statements. |
||
51 | * |
||
52 | * @return void |
||
53 | */ |
||
54 | public function init() |
||
60 | |||
61 | /** |
||
62 | * Returns an array with the available customer groups and their code as keys. |
||
63 | * |
||
64 | * @return array The array with the customer groups |
||
65 | */ |
||
66 | public function findAll() |
||
83 | } |
||
84 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.