Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
35 | View Code Duplication | class StockItemRepository extends AbstractRepository |
|
|
|||
36 | { |
||
37 | |||
38 | /** |
||
39 | * The prepared statement to load the existing stock items. |
||
40 | * |
||
41 | * @var \PDOStatement |
||
42 | */ |
||
43 | protected $stockItemStmt; |
||
44 | |||
45 | /** |
||
46 | * Initializes the repository's prepared statements. |
||
47 | * |
||
48 | * @return void |
||
49 | */ |
||
50 | public function init() |
||
59 | |||
60 | /** |
||
61 | * Load's and return's the stock item with the passed product/website/stock ID. |
||
62 | * |
||
63 | * @param integer $productId The product ID of the stock item to load |
||
64 | * @param integer $websiteId The website ID of the stock item to load |
||
65 | * @param integer $stockId The stock ID of the stock item to load |
||
66 | * |
||
67 | * @return array The stock item |
||
68 | */ |
||
69 | public function findOneByProductIdAndWebsiteIdAndStockId($productId, $websiteId, $stockId) |
||
83 | } |
||
84 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.