Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
35 | View Code Duplication | class ProductVarcharRepository extends AbstractRepository |
|
|
|||
36 | { |
||
37 | |||
38 | /** |
||
39 | * The prepared statement to load the existing product varchar attribute. |
||
40 | * |
||
41 | * @var \PDOStatement |
||
42 | */ |
||
43 | protected $productVarcharStmt; |
||
44 | |||
45 | /** |
||
46 | * Initializes the repository's prepared statements. |
||
47 | * |
||
48 | * @return void |
||
49 | */ |
||
50 | public function init() |
||
59 | |||
60 | /** |
||
61 | * Load's and return's the varchar attribute with the passed entity/attribute/store ID. |
||
62 | * |
||
63 | * @param integer $entityId The entity ID of the attribute |
||
64 | * @param integer $attributeId The attribute ID of the attribute |
||
65 | * @param integer $storeId The store ID of the attribute |
||
66 | * |
||
67 | * @return array|null The varchar attribute |
||
68 | */ |
||
69 | public function findOneByEntityIdAndAttributeIdAndStoreId($entityId, $attributeId, $storeId) |
||
83 | } |
||
84 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.