Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
49 | class BunchSubject extends AbstractProductSubject implements ExportableSubjectInterface, FileUploadSubjectInterface, UrlKeyAwareSubjectInterface, CleanUpColumnsSubjectInterface |
||
50 | { |
||
51 | |||
52 | /** |
||
53 | * The trait that implements the export functionality. |
||
54 | * |
||
55 | * @var \TechDivision\Import\Subjects\ExportableTrait |
||
56 | */ |
||
57 | use ExportableTrait; |
||
58 | |||
59 | /** |
||
60 | * The trait that provides file upload functionality. |
||
61 | * |
||
62 | * @var \TechDivision\Import\Subjects\FileUploadTrait |
||
63 | */ |
||
64 | use FileUploadTrait; |
||
65 | |||
66 | /** |
||
67 | * The array with the pre-loaded entity IDs. |
||
68 | * |
||
69 | * @var array |
||
70 | */ |
||
71 | protected $preLoadedEntityIds = array(); |
||
72 | |||
73 | /** |
||
74 | * Mappings for the table column => CSV column header. |
||
75 | * |
||
76 | * @var array |
||
77 | */ |
||
78 | protected $headerStockMappings = array( |
||
79 | 'qty' => array('qty', 'float'), |
||
80 | 'min_qty' => array('out_of_stock_qty', 'float'), |
||
81 | 'use_config_min_qty' => array('use_config_min_qty', 'int'), |
||
82 | 'is_qty_decimal' => array('is_qty_decimal', 'int'), |
||
83 | 'backorders' => array('allow_backorders', 'int'), |
||
84 | 'use_config_backorders' => array('use_config_backorders', 'int'), |
||
85 | 'min_sale_qty' => array('min_cart_qty', 'float'), |
||
86 | 'use_config_min_sale_qty' => array('use_config_min_sale_qty', 'int'), |
||
87 | 'max_sale_qty' => array('max_cart_qty', 'float'), |
||
88 | 'use_config_max_sale_qty' => array('use_config_max_sale_qty', 'int'), |
||
89 | 'is_in_stock' => array('is_in_stock', 'int'), |
||
90 | 'notify_stock_qty' => array('notify_on_stock_below', 'float'), |
||
91 | 'use_config_notify_stock_qty' => array('use_config_notify_stock_qty', 'int'), |
||
92 | 'manage_stock' => array('manage_stock', 'int'), |
||
93 | 'use_config_manage_stock' => array('use_config_manage_stock', 'int'), |
||
94 | 'use_config_qty_increments' => array('use_config_qty_increments', 'int'), |
||
95 | 'qty_increments' => array('qty_increments', 'float'), |
||
96 | 'use_config_enable_qty_inc' => array('use_config_enable_qty_inc', 'int'), |
||
97 | 'enable_qty_increments' => array('enable_qty_increments', 'int'), |
||
98 | 'is_decimal_divided' => array('is_decimal_divided', 'int'), |
||
99 | ); |
||
100 | |||
101 | /** |
||
102 | * The array with the available visibility keys. |
||
103 | * |
||
104 | * @var array |
||
105 | */ |
||
106 | protected $availableVisibilities = array( |
||
107 | 'Not Visible Individually' => VisibilityKeys::VISIBILITY_NOT_VISIBLE, |
||
108 | 'Catalog' => VisibilityKeys::VISIBILITY_IN_CATALOG, |
||
109 | 'Search' => VisibilityKeys::VISIBILITY_IN_SEARCH, |
||
110 | 'Catalog, Search' => VisibilityKeys::VISIBILITY_BOTH |
||
111 | ); |
||
112 | |||
113 | /** |
||
114 | * The default callback mappings for the Magento standard product attributes. |
||
115 | * |
||
116 | * @var array |
||
117 | */ |
||
118 | protected $defaultCallbackMappings = array( |
||
119 | 'visibility' => array('import_product.callback.visibility'), |
||
120 | 'tax_class_id' => array('import_product.callback.tax.class'), |
||
121 | 'bundle_price_type' => array('import_product_bundle.callback.bundle.type'), |
||
122 | 'bundle_sku_type' => array('import_product_bundle.callback.bundle.type'), |
||
123 | 'bundle_weight_type' => array('import_product_bundle.callback.bundle.type'), |
||
124 | 'bundle_price_view' => array('import_product_bundle.callback.bundle.price.view'), |
||
125 | 'bundle_shipment_type' => array('import_product_bundle.callback.bundle.shipment.type') |
||
126 | ); |
||
127 | |||
128 | /** |
||
129 | * The available entity types. |
||
130 | * |
||
131 | * @var array |
||
132 | */ |
||
133 | protected $entityTypes = array(); |
||
134 | |||
135 | /** |
||
136 | * The media roles loader instance. |
||
137 | * |
||
138 | * @var \TechDivision\Import\Loaders\LoaderInterface |
||
139 | */ |
||
140 | protected $mediaRolesLoader; |
||
141 | |||
142 | /** |
||
143 | * BunchSubject constructor |
||
144 | * |
||
145 | * @param RegistryProcessorInterface $registryProcessor The registry processor instance |
||
146 | * @param GeneratorInterface $coreConfigDataUidGenerator The generator instance |
||
147 | * @param Collection $systemLoggers The system logger collection |
||
148 | * @param EmitterInterface $emitter The emitter instance |
||
149 | * @param LoaderInterface $loader The media type loader instance |
||
150 | */ |
||
151 | 18 | public function __construct( |
|
165 | |||
166 | /** |
||
167 | * Intializes the previously loaded global data for exactly one bunch. |
||
168 | * |
||
169 | * @param string $serial The serial of the actual import |
||
170 | * |
||
171 | * @return void |
||
172 | */ |
||
173 | 18 | public function setUp($serial) |
|
214 | |||
215 | /** |
||
216 | * Clean up the global data after importing the bunch. |
||
217 | * |
||
218 | * @param string $serial The serial of the actual import |
||
219 | * |
||
220 | * @return void |
||
221 | */ |
||
222 | public function tearDown($serial) |
||
239 | |||
240 | /** |
||
241 | * Return's the default callback mappings. |
||
242 | * |
||
243 | * @return array The default callback mappings |
||
244 | */ |
||
245 | public function getDefaultCallbackMappings() |
||
249 | |||
250 | /** |
||
251 | * Return's the mappings for the table column => CSV column header. |
||
252 | * |
||
253 | * @return array The header stock mappings |
||
254 | */ |
||
255 | 1 | public function getHeaderStockMappings() |
|
259 | |||
260 | /** |
||
261 | * Return's the visibility key for the passed visibility string. |
||
262 | * |
||
263 | * @param string $visibility The visibility string to return the key for |
||
264 | * |
||
265 | * @return integer The requested visibility key |
||
266 | * @throws \Exception Is thrown, if the requested visibility is not available |
||
267 | */ |
||
268 | public function getVisibilityIdByValue($visibility) |
||
284 | |||
285 | /** |
||
286 | * Pre-load the entity ID for the passed product. |
||
287 | * |
||
288 | * @param array $product The product to be pre-loaded |
||
289 | * |
||
290 | * @return void |
||
291 | */ |
||
292 | public function preLoadEntityId(array $product) |
||
296 | |||
297 | /** |
||
298 | * Return's the entity type for the configured entity type code. |
||
299 | * |
||
300 | * @return array The requested entity type |
||
301 | * @throws \Exception Is thrown, if the requested entity type is not available |
||
302 | */ |
||
303 | 1 | View Code Duplication | public function getEntityType() |
318 | |||
319 | /** |
||
320 | * Return's TRUE, if the passed URL key varchar value IS related with the actual PK. |
||
321 | * |
||
322 | * @param array $productVarcharAttribute The varchar value to check |
||
323 | * |
||
324 | * @return boolean TRUE if the URL key is related, else FALSE |
||
325 | */ |
||
326 | public function isUrlKeyOf(array $productVarcharAttribute) |
||
331 | |||
332 | /** |
||
333 | * Loads and returns the media roles. |
||
334 | * |
||
335 | * @return array The array with the media roles |
||
336 | */ |
||
337 | public function getMediaRoles(): array |
||
341 | |||
342 | /** |
||
343 | * Merge the columns from the configuration with all image type columns to define which |
||
344 | * columns should be cleaned-up. |
||
345 | * |
||
346 | * @return array The columns that has to be cleaned-up |
||
347 | */ |
||
348 | 1 | public function getCleanUpColumns() |
|
362 | } |
||
363 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.