TechDivision\Import\Product\Observers\UrlRewriteObserver::process()

Complexity

Conditions	10
Paths	26

Size

Total Lines	87
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	22
CRAP Score	15.8818

Importance

Changes

0

<?php
    protected function process()
    {

        // initialize the store view code
        $this->getSubject()->prepareStoreViewCode();

        // load the SKU
        $sku = $this->getValue($this->getPrimaryKeyColumnName());

        // load the store view - if no store view has been set we use the admin store view as default
        $storeViewCode = $this->getSubject()->getStoreViewCode(StoreViewCodes::ADMIN);

It seems like you code against a concrete implementation and not the interface TechDivision\Import\Subjects\SubjectInterface as the method getStoreViewCode() does only exist in the following implementations of said interface: TechDivision\Import\Product\Subjects\AbstractProductSubject, TechDivision\Import\Product\Subjects\BunchSubject, TechDivision\Import\Subjects\AbstractEavSubject, TechDivision\Import\Subjects\AbstractSubject, TechDivision\Import\Subjects\MoveFilesSubject.

        // only map the visibility of the product with the default store view
        if (!$this->hasBeenProcessed($sku)) {
            $this->addEntityIdVisibilityIdMapping($this->getValue(ColumnKeys::VISIBILITY));
        }

        // query whether or not we're in the admin store view
        if ($storeViewCode === StoreViewCodes::ADMIN) {
            // stop processing as we don't want to create URL rewrites for the admin store view
            return;
        }

        // query whether or not the row has already been processed
        if ($this->storeViewHasBeenProcessed($sku, $storeViewCode)) {
            // log a message
            $this->getSubject()
                 ->getSystemLogger()
                 ->warning(
                     sprintf(
                         'URL rewrites for SKU "%s" + store view code "%s" has already been processed',
                         $sku,
                         $storeViewCode
                     )
                 );

            // return immediately
            return;
        };

        // try to load the URL key, return immediately if not possible
        if ($this->hasValue(ColumnKeys::URL_KEY)) {
            $this->urlKey = $this->getValue(ColumnKeys::URL_KEY);
        } else {
            return;
        }

        // prepare the URL rewrites
        $this->prepareUrlRewrites();

        // do NOT create new URL rewrites, if the product is NOT visible (any more), BUT
        // handle existing URL rewrites, e. g. to remove and clean up the URL rewrites
        if ($this->isNotVisible()) {
            return;
        }

        // iterate over the categories and create the URL rewrites
        foreach ($this->urlRewrites as $categoryId => $urlRewrite) {
            // initialize and persist the URL rewrite
            if ($urlRewrite = $this->initializeUrlRewrite($urlRewrite)) {
                // initialize URL rewrite and entity ID
                $this->categoryId = $categoryId;

It seems like $categoryId can also be of type string. However, the property $categoryId is declared as type integer. Maybe add an additional type check?

                $this->entityId = $urlRewrite[MemberNames::ENTITY_ID];

                try {
                    // persist the URL rewrite
                    $this->urlRewriteId = $this->persistUrlRewrite($urlRewrite);

The property $urlRewriteId was declared of type integer, but $this->persistUrlRewrite($urlRewrite) is of type string. Maybe add a type cast?

                    // initialize and persist the URL rewrite product => category relation
                    $urlRewriteProductCategory = $this->initializeUrlRewriteProductCategory(
                        $this->prepareUrlRewriteProductCategoryAttributes()
                    );

                    // persist the URL rewrite product category relation
                    $this->persistUrlRewriteProductCategory($urlRewriteProductCategory);

Blank line found at end of control structure

                } catch (\Exception $e) {
                    // query whether or not debug mode has been enabled
                    if ($this->getSubject()->isDebugMode()) {
                        $this->getSubject()->getSystemLogger()->warning($this->getSubject()->appendExceptionSuffix($e->getMessage()));

It seems like you code against a concrete implementation and not the interface TechDivision\Import\Subjects\SubjectInterface as the method appendExceptionSuffix() does only exist in the following implementations of said interface: TechDivision\Import\Product\Subjects\AbstractProductSubject, TechDivision\Import\Product\Subjects\BunchSubject, TechDivision\Import\Subjects\AbstractEavSubject, TechDivision\Import\Subjects\AbstractSubject, TechDivision\Import\Subjects\MoveFilesSubject.

                    } else {
                        throw $e;
                    }
                }
            }
        }
    }