TechDivision\Import\Product\UrlRewrite\Observers\UrlRewriteObserver::process()

Complexity

Conditions	14
Paths	49

Size

Total Lines	148
Code Lines	75

Duplication

Lines	29
Ratio	19.59 %

Code Coverage

Tests	24
CRAP Score	68.3747

Importance

Changes

0

<?php
    protected function process()
    {

        // try to load the entity ID for the product with the passed SKU
        if ($product = $this->loadProduct($sku = $this->getValue(ColumnKeys::SKU))) {
            $this->setLastEntityId($this->entityId = $product[MemberNames::ENTITY_ID]);
        } else {

This code seems to be duplicated across your project.

            // prepare a log message
            $message = sprintf('Product with SKU "%s" can\'t be loaded to create URL rewrites', $sku);
            // query whether or not we're in debug mode
            if ($this->getSubject()->isDebugMode()) {
                $this->getSubject()->getSystemLogger()->warning($message);
                return;
            } else {
                throw new \Exception($message);
            }
        }

        // try to load the URL key
        if ($this->hasValue(ColumnKeys::URL_KEY)) {
            $this->urlKey = $this->getValue(ColumnKeys::URL_KEY);
        } else {

This code seems to be duplicated across your project.

            // prepare a log message
            $message = sprintf('Can\'t find a value in column "url_key" for product with SKU "%s"', $sku);
            // query whether or not we're in debug mode
            if ($this->getSubject()->isDebugMode()) {
                $this->getSubject()->getSystemLogger()->warning($message);
            } else {
                return;
                throw new \Exception($message);

throw new \Exception($message); does not seem to be reachable.

            }
        }

        // initialize the store view code
        $this->getSubject()->prepareStoreViewCode();

        // load the store view - if no store view has been set we use the admin store view as default
        $storeViewCode = $this->getSubject()->getStoreViewCode(StoreViewCodes::ADMIN);

        // query whether or not the row has already been processed
        if ($this->storeViewHasBeenProcessed($sku, $storeViewCode)) {
            // log a message
            $this->getSubject()
                ->getSystemLogger()
                ->debug(
                    sprintf(
                        'URL rewrites for SKU "%s" + store view code "%s" has already been processed',
                        $sku,
                        $storeViewCode
                    )
                );

            // return without creating any rewrites
            return;
        };

        // stop processing as we don't want to create URL rewrites for the admin store view
        if ($storeViewCode === StoreViewCodes::ADMIN) {
            // log a message and return
            $this->getSubject()
                ->getSystemLogger()
                ->debug(
                    sprintf(
                        'Store with code "%s" is not active, no URL rewrites will be created for product with SKU "%s"',
                        $storeViewCode,
                        $sku
                    )
                );

            // return without creating any rewrites
            return;
        }

        // stop processing if the store is NOT active
        $this->isStoreViewActive = $this->getSubject()->storeIsActive($storeViewCode);

It seems like you code against a concrete implementation and not the interface TechDivision\Import\Subjects\SubjectInterface as the method storeIsActive() does only exist in the following implementations of said interface: TechDivision\Import\Product\UrlRewrite\Subjects\UrlRewriteSubject.

        if (!$this->isStoreViewActive) {
            // log a message and return
            $this->getSubject()
                ->getSystemLogger()
                ->debug(
                    sprintf(
                        'Store with code "%s" is not active, no URL rewrites will be created for product with SKU "%s"',
                        $storeViewCode,
                        $sku
                    )
                );

            // return without creating any rewrites
            return;
        }

        // only map the visibility for the product row related to the default store view
        if (!$this->hasBeenProcessed($sku)) {
            $this->addEntityIdVisibilityIdMapping($this->getValue(ColumnKeys::VISIBILITY));
        }

        // do NOT create new URL rewrites, if the product is NOT visible (any more), BUT
        // handle existing URL rewrites, e. g. to remove and clean up the URL rewrites
        if (!$this->isVisible()) {
            // log a message
            $this->getSubject()
                ->getSystemLogger()
                ->debug(
                    sprintf(
                        'Product with SKU "%s" is not visible, so no URL rewrites will be created',
                        $sku
                    )
                );

            // return without creating any rewrites
            return;
        }

        // prepare the URL rewrites
        $this->prepareUrlRewrites();

        // iterate over the categories and create the URL rewrites
        foreach ($this->urlRewrites as $categoryId => $urlRewrite) {
            // initialize and persist the URL rewrite
            if ($urlRewrite = $this->initializeUrlRewrite($urlRewrite)) {
                // initialize URL rewrite and catagory ID
                $this->categoryId = $categoryId;

It seems like $categoryId can also be of type string. However, the property $categoryId is declared as type integer. Maybe add an additional type check?

                try {
                    // persist the URL rewrite
                    $this->urlRewriteId = $this->persistUrlRewrite($urlRewrite);

The property $urlRewriteId was declared of type integer, but $this->persistUrlRewrite($urlRewrite) is of type string. Maybe add a type cast?

                    // initialize and persist the URL rewrite product => category relation
                    $urlRewriteProductCategory = $this->initializeUrlRewriteProductCategory(
                        $this->prepareUrlRewriteProductCategoryAttributes()
                    );

                    // persist the URL rewrite product category relation
                    $this->persistUrlRewriteProductCategory($urlRewriteProductCategory);

                } catch (\Exception $e) {
                    // query whether or not debug mode has been enabled
                    if ($this->getSubject()->isDebugMode()) {

This code seems to be duplicated across your project.

                        $this->getSubject()
                            ->getSystemLogger()
                            ->warning($this->getSubject()->appendExceptionSuffix($e->getMessage()));
                    } else {
                        throw $e;
                    }
                }
            }
        }
    }