Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
35 | View Code Duplication | class ProductMediaGalleryValueToEntityRepository extends AbstractRepository |
|
|
|||
36 | { |
||
37 | |||
38 | /** |
||
39 | * The prepared statement to load an existing product media gallery value to entity entity. |
||
40 | * |
||
41 | * @var \PDOStatement |
||
42 | */ |
||
43 | protected $productMediaGalleryValueToEntityStmt; |
||
44 | |||
45 | /** |
||
46 | * Initializes the repository's prepared statements. |
||
47 | * |
||
48 | * @return void |
||
49 | */ |
||
50 | public function init() |
||
59 | |||
60 | /** |
||
61 | * Load's the product media gallery with the passed value/entity ID. |
||
62 | * |
||
63 | * @param integer $valueId The value ID of the product media gallery value to entity to load |
||
64 | * @param integer $entityId The entity ID of the product media gallery value to entity to load |
||
65 | * |
||
66 | * @return array The product media gallery |
||
67 | */ |
||
68 | public function findOneByValueIdAndEntityId($valueId, $entityId) |
||
81 | } |
||
82 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.