EeProductMediaProcessor::loadProductMediaGalleryValueToEntityByValueIdAndRowId() - Code Metrics - Inspection of "Refactoring for DI integration" - techdivision/import-product-media-ee - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3)

by Tim

created 2017-03-29 15:12 UTC

loadProductMediaGalleryValueToEntityByValueIdAndRowId() A

↳ Parent: EeProductMediaProcessor

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	4
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	2
crap	2

<?php

/**
 * TechDivision\Import\Product\Media\Ee\Services\EeProductMediaProcessor
 *
 * NOTICE OF LICENSE
 *
 * This source file is subject to the Open Software License (OSL 3.0)
 * that is available through the world-wide-web at this URL:
 * http://opensource.org/licenses/osl-3.0.php
 *
 * PHP version 5
 *
 * @author    Tim Wagner <[email protected]>
 * @copyright 2016 TechDivision GmbH <[email protected]>
 * @license   http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
 * @link      https://github.com/techdivision/import-product-media
 * @link      http://www.techdivision.com
 */

namespace TechDivision\Import\Product\Media\Ee\Services;

use TechDivision\Import\Product\Media\Services\ProductMediaProcessor;
use TechDivision\Import\Product\Media\Repositories\ProductMediaGalleryRepository;
use TechDivision\Import\Product\Media\Actions\ProductMediaGalleryValueToEntityAction;
use TechDivision\Import\Product\Media\Actions\ProductMediaGalleryValueVideoAction;
use TechDivision\Import\Product\Media\Actions\ProductMediaGalleryAction;
use TechDivision\Import\Product\Media\Actions\ProductMediaGalleryValueAction;
use TechDivision\Import\Product\Media\Ee\Repositories\ProductMediaGalleryValueRepository;
use TechDivision\Import\Product\Media\Ee\Repositories\ProductMediaGalleryValueToEntityRepository;

/**
 * A processor implementation that provides media import functionality for the Magento 2 EE.
 *
 * @author    Tim Wagner <[email protected]>
 * @copyright 2016 TechDivision GmbH <[email protected]>
 * @license   http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
 * @link      https://github.com/techdivision/import-product-media
 * @link      http://www.techdivision.com
 */
class EeProductMediaProcessor extends ProductMediaProcessor implements EeProductMediaProcessorInterface
{

    /**
     * Initialize the processor with the necessary assembler and repository instances.
     *
     * @param \PDO                                                                                          $connection                                 The PDO connection to use
     * @param \TechDivision\Import\Product\Media\Repositories\ProductMediaGalleryRepository                 $productMediaGalleryRepository              The product media gallery repository to use
     * @param \TechDivision\Import\Product\Media\Ee\Repositories\ProductMediaGalleryValueRepository         $productMediaGalleryValueRepository         The product media gallery value repository to use
     * @param \TechDivision\Import\Product\Media\Ee\Repositories\ProductMediaGalleryValueToEntityRepository $productMediaGalleryValueToEntityRepository The product media gallery value to entity repository to use
     * @param \TechDivision\Import\Product\Media\Actions\ProductMediaGalleryAction                          $productMediaGalleryAction                  The product media gallery action to use
     * @param \TechDivision\Import\Product\Media\Actions\ProductMediaGalleryValueAction                     $productMediaGalleryValueAction             The product media gallery value action to use
     * @param \TechDivision\Import\Product\Media\Actions\ProductMediaGalleryValueToEntityAction             $productMediaGalleryValueToEntityAction     The product media gallery value to entity action to use
     * @param \TechDivision\Import\Product\Media\Actions\ProductMediaGalleryVideoAction                     $productMediaGalleryValueVideoAction        The product media gallery value video action to use
     */
    public function __construct(
        \PDO $connection,
        ProductMediaGalleryRepository $productMediaGalleryRepository,
        ProductMediaGalleryValueRepository $productMediaGalleryValueRepository,
        ProductMediaGalleryValueToEntityRepository $productMediaGalleryValueToEntityRepository,
        ProductMediaGalleryAction $productMediaGalleryAction,
        ProductMediaGalleryValueAction $productMediaGalleryValueAction,
        ProductMediaGalleryValueToEntityAction $productMediaGalleryValueToEntityAction,
        ProductMediaGalleryValueVideoAction $productMediaGalleryValueVideoAction
    ) {
        $this->setConnection($connection);
        $this->setProductMediaGalleryRepository($productMediaGalleryRepository);
        $this->setProductMediaGalleryValueRepository($productMediaGalleryValueRepository);
        $this->setProductMediaGalleryValueToEntityRepository($productMediaGalleryValueToEntityRepository);
        $this->setProductMediaGalleryAction($productMediaGalleryAction);
        $this->setProductMediaGalleryValueAction($productMediaGalleryValueAction);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->setProductMediaGalleryValueToEntityAction($productMediaGalleryValueToEntityAction);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->setProductMediaGalleryValueVideoAction($productMediaGalleryValueVideoAction);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Load's the product media gallery with the passed value/row ID.
     *
     * @param integer $valueId The value ID of the product media gallery value to entity to load
     * @param integer $rowId   The row ID of the product media gallery value to entity to load
     *
     * @return array The product media gallery
     */
    public function loadProductMediaGalleryValueToEntityByValueIdAndRowId($valueId, $rowId)
    {
        return $this->getProductMediaGalleryValueToEntityRepository()->findOneByValueIdAndEntityId($valueId, $rowId);
    }

    /**
     * Load's the product media gallery value with the passed value/store/row ID.
     *
     * @param integer $valueId The value ID of the product media gallery value to load
     * @param string  $storeId The store ID of the product media gallery value to load
     * @param string  $rowId   The row ID of the parent product of the product media gallery value to load
     *
     * @return array The product media gallery value
     */
    public function loadProductMediaGalleryValueByValueIdAndStoreIdAndRowId($valueId, $storeId, $rowId)
    {
        return $this->getProductMediaGalleryValueRepository()->findOneByValueIdAndStoreIdAndEntityId($valueId, $storeId, $rowId);
    }
}


1			<?php
2
3			/**
4			* TechDivision\Import\Product\Media\Ee\Services\EeProductMediaProcessor
5			*
6			* NOTICE OF LICENSE
7			*
8			* This source file is subject to the Open Software License (OSL 3.0)
9			* that is available through the world-wide-web at this URL:
10			* http://opensource.org/licenses/osl-3.0.php
11			*
12			* PHP version 5
13			*
14			* @author Tim Wagner <[email protected]>
15			* @copyright 2016 TechDivision GmbH <[email protected]>
16			* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
17			* @link https://github.com/techdivision/import-product-media
18			* @link http://www.techdivision.com
19			*/
20
21			namespace TechDivision\Import\Product\Media\Ee\Services;
22
23			use TechDivision\Import\Product\Media\Services\ProductMediaProcessor;
24			use TechDivision\Import\Product\Media\Repositories\ProductMediaGalleryRepository;
25			use TechDivision\Import\Product\Media\Actions\ProductMediaGalleryValueToEntityAction;
26			use TechDivision\Import\Product\Media\Actions\ProductMediaGalleryValueVideoAction;
27			use TechDivision\Import\Product\Media\Actions\ProductMediaGalleryAction;
28			use TechDivision\Import\Product\Media\Actions\ProductMediaGalleryValueAction;
29			use TechDivision\Import\Product\Media\Ee\Repositories\ProductMediaGalleryValueRepository;
30			use TechDivision\Import\Product\Media\Ee\Repositories\ProductMediaGalleryValueToEntityRepository;
31
32			/**
33			* A processor implementation that provides media import functionality for the Magento 2 EE.
34			*
35			* @author Tim Wagner <[email protected]>
36			* @copyright 2016 TechDivision GmbH <[email protected]>
37			* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
38			* @link https://github.com/techdivision/import-product-media
39			* @link http://www.techdivision.com
40			*/
41			class EeProductMediaProcessor extends ProductMediaProcessor implements EeProductMediaProcessorInterface
42			{
43
44			/**
45			* Initialize the processor with the necessary assembler and repository instances.
46			*
47			* @param \PDO $connection The PDO connection to use
48			* @param \TechDivision\Import\Product\Media\Repositories\ProductMediaGalleryRepository $productMediaGalleryRepository The product media gallery repository to use
49			* @param \TechDivision\Import\Product\Media\Ee\Repositories\ProductMediaGalleryValueRepository $productMediaGalleryValueRepository The product media gallery value repository to use
50			* @param \TechDivision\Import\Product\Media\Ee\Repositories\ProductMediaGalleryValueToEntityRepository $productMediaGalleryValueToEntityRepository The product media gallery value to entity repository to use
51			* @param \TechDivision\Import\Product\Media\Actions\ProductMediaGalleryAction $productMediaGalleryAction The product media gallery action to use
52			* @param \TechDivision\Import\Product\Media\Actions\ProductMediaGalleryValueAction $productMediaGalleryValueAction The product media gallery value action to use
53			* @param \TechDivision\Import\Product\Media\Actions\ProductMediaGalleryValueToEntityAction $productMediaGalleryValueToEntityAction The product media gallery value to entity action to use
54			* @param \TechDivision\Import\Product\Media\Actions\ProductMediaGalleryVideoAction $productMediaGalleryValueVideoAction The product media gallery value video action to use
55			*/
56			public function __construct(
57			\PDO $connection,
58			ProductMediaGalleryRepository $productMediaGalleryRepository,
59			ProductMediaGalleryValueRepository $productMediaGalleryValueRepository,
60			ProductMediaGalleryValueToEntityRepository $productMediaGalleryValueToEntityRepository,
61			ProductMediaGalleryAction $productMediaGalleryAction,
62			ProductMediaGalleryValueAction $productMediaGalleryValueAction,
63			ProductMediaGalleryValueToEntityAction $productMediaGalleryValueToEntityAction,
64			ProductMediaGalleryValueVideoAction $productMediaGalleryValueVideoAction
65			) {
66			$this->setConnection($connection);
67			$this->setProductMediaGalleryRepository($productMediaGalleryRepository);
68			$this->setProductMediaGalleryValueRepository($productMediaGalleryValueRepository);
69			$this->setProductMediaGalleryValueToEntityRepository($productMediaGalleryValueToEntityRepository);
70			$this->setProductMediaGalleryAction($productMediaGalleryAction);
71			$this->setProductMediaGalleryValueAction($productMediaGalleryValueAction);
			0 ignored issues – show Documentation introduced 2017-03-29 15:18 UTC by Report Bug Copy Issue Report `$productMediaGalleryValueAction` is of type `object<TechDivision\Impo...ediaGalleryValueAction>`, but the function expects a `object<TechDivision\Impo...ductMediaGalleryAction>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
72			$this->setProductMediaGalleryValueToEntityAction($productMediaGalleryValueToEntityAction);
			0 ignored issues – show Documentation introduced 2017-03-29 15:18 UTC by Report Bug Copy Issue Report `$productMediaGalleryValueToEntityAction` is of type `object<TechDivision\Impo...eryValueToEntityAction>`, but the function expects a `object<TechDivision\Impo...ductMediaGalleryAction>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
73			$this->setProductMediaGalleryValueVideoAction($productMediaGalleryValueVideoAction);
			0 ignored issues – show Documentation introduced 2017-03-29 15:18 UTC by Report Bug Copy Issue Report `$productMediaGalleryValueVideoAction` is of type `object<TechDivision\Impo...alleryValueVideoAction>`, but the function expects a `object<TechDivision\Impo...ductMediaGalleryAction>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
74			}
75
76			/**
77			* Load's the product media gallery with the passed value/row ID.
78			*
79			* @param integer $valueId The value ID of the product media gallery value to entity to load
80			* @param integer $rowId The row ID of the product media gallery value to entity to load
81			*
82			* @return array The product media gallery
83			*/
84			public function loadProductMediaGalleryValueToEntityByValueIdAndRowId($valueId, $rowId)
85			{
86			return $this->getProductMediaGalleryValueToEntityRepository()->findOneByValueIdAndEntityId($valueId, $rowId);
87			}
88
89			/**
90			* Load's the product media gallery value with the passed value/store/row ID.
91			*
92			* @param integer $valueId The value ID of the product media gallery value to load
93			* @param string $storeId The store ID of the product media gallery value to load
94			* @param string $rowId The row ID of the parent product of the product media gallery value to load
95			*
96			* @return array The product media gallery value
97			*/
98			public function loadProductMediaGalleryValueByValueIdAndStoreIdAndRowId($valueId, $storeId, $rowId)
99			{
100			return $this->getProductMediaGalleryValueRepository()->findOneByValueIdAndStoreIdAndEntityId($valueId, $storeId, $rowId);
101			}
102			}
103

techdivision / import-product-media-ee

Pull Request — master (#3)

loadProductMediaGalleryValueToEntityByValueIdAndRowId() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like