Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
35 | View Code Duplication | class ProductMediaGalleryValueRepository extends \TechDivision\Import\Product\Media\Repositories\ProductMediaGalleryValueRepository implements ProductMediaGalleryValueRepositoryInterface |
|
|
|||
36 | { |
||
37 | |||
38 | /** |
||
39 | * The prepared statement to load an existing product media gallery value entity. |
||
40 | * |
||
41 | * @var \PDOStatement |
||
42 | */ |
||
43 | protected $productMediaGalleryStmt; |
||
44 | |||
45 | /** |
||
46 | * Initializes the repository's prepared statements. |
||
47 | * |
||
48 | * @return void |
||
49 | */ |
||
50 | public function init() |
||
57 | |||
58 | /** |
||
59 | * Load's the product media gallery value with the passed value/store/row ID. |
||
60 | * |
||
61 | * @param integer $valueId The value ID of the product media gallery value to load |
||
62 | * @param string $storeId The store ID of the product media gallery value to load |
||
63 | * @param string $rowId The row ID of the parent product of the product media gallery value to load |
||
64 | * |
||
65 | * @return array The product media gallery value |
||
66 | */ |
||
67 | public function findOneByValueIdAndStoreIdAndRowId($valueId, $storeId, $rowId) |
||
81 | } |
||
82 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.