EeProductAttributeObserverTrait::getLastRowId() - Code Metrics - Inspection of "Implement add-update operation" - techdivision/import-product-ee - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#5)

by Tim

created 2017-01-02 16:43 UTC

EeProductAttributeObserverTrait::getLastRowId() A

↳ Parent: EeProductAttributeObserverTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	4
ccs	0
cts	4
cp	0
rs	10
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php

/**
 * TechDivision\Import\Product\Ee\Observers\EeProductAttributeObserverTrait
 *
 * NOTICE OF LICENSE
 *
 * This source file is subject to the Open Software License (OSL 3.0)
 * that is available through the world-wide-web at this URL:
 * http://opensource.org/licenses/osl-3.0.php
 *
 * PHP version 5
 *
 * @author    Tim Wagner <[email protected]>
 * @copyright 2016 TechDivision GmbH <[email protected]>
 * @license   http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
 * @link      https://github.com/techdivision/import-product-ee
 * @link      http://www.techdivision.com
 */

namespace TechDivision\Import\Product\Ee\Observers;

use TechDivision\Import\Utils\StoreViewCodes;
use TechDivision\Import\Product\Ee\Utils\MemberNames;

/**
 * Trait that provides basic product attribute functionality.
 *
 * @author    Tim Wagner <[email protected]>
 * @copyright 2016 TechDivision GmbH <[email protected]>
 * @license   http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
 * @link      https://github.com/techdivision/import-product-ee
 * @link      http://www.techdivision.com
 */
trait EeProductAttributeObserverTrait
{

    /**
     * Prepare the attributes of the entity that has to be persisted.
     *
     * @return array The prepared attributes
     */
    public function prepareAttributes()
    {

        // load the attribute value
        $attributeValue = $this->getAttributeValue();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        // laod the callbacks for the actual attribute code
        $callbacks = $this->getCallbacksByType($this->getAttributeCode());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        // invoke the pre-cast callbacks
        foreach ($callbacks as $callback) {
            $attributeValue = $callback->handle($attributeValue);
        }

        // load the ID of the product that has been created recently
        $lastEntityId = $this->getPrimaryKey();

        // load the ID of the attribute to create the values for
        $attributeId = $this->getAttributeId();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        // load the store ID
        $storeId = $this->getRowStoreId(StoreViewCodes::ADMIN);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        // load the backend type of the actual attribute
        $backendType = $this->getBackendType();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        // cast the value based on the backend type
        $castedValue = $this->castValueByBackendType($backendType, $attributeValue);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        // prepare the attribute values
        return $this->initializeEntity(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            array(
                MemberNames::ROW_ID       => $lastEntityId,
                MemberNames::ATTRIBUTE_ID => $attributeId,
                MemberNames::STORE_ID     => $storeId,
                MemberNames::VALUE        => $castedValue
            )
        );
    }

    /**
     * Return's the PK to create the product => attribute relation.
     *
     * @return integer The PK to create the relation with
     */
    public function getPrimaryKey()
    {
        return $this->getLastRowId();
    }

    /**
     * Return's the row ID of the product that has been created recently.
     *
     * @return string The row Id
     */
    public function getLastRowId()
    {
        return $this->getSubject()->getLastRowId();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			/**
4			* TechDivision\Import\Product\Ee\Observers\EeProductAttributeObserverTrait
5			*
6			* NOTICE OF LICENSE
7			*
8			* This source file is subject to the Open Software License (OSL 3.0)
9			* that is available through the world-wide-web at this URL:
10			* http://opensource.org/licenses/osl-3.0.php
11			*
12			* PHP version 5
13			*
14			* @author Tim Wagner <[email protected]>
15			* @copyright 2016 TechDivision GmbH <[email protected]>
16			* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
17			* @link https://github.com/techdivision/import-product-ee
18			* @link http://www.techdivision.com
19			*/
20
21			namespace TechDivision\Import\Product\Ee\Observers;
22
23			use TechDivision\Import\Utils\StoreViewCodes;
24			use TechDivision\Import\Product\Ee\Utils\MemberNames;
25
26			/**
27			* Trait that provides basic product attribute functionality.
28			*
29			* @author Tim Wagner <[email protected]>
30			* @copyright 2016 TechDivision GmbH <[email protected]>
31			* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
32			* @link https://github.com/techdivision/import-product-ee
33			* @link http://www.techdivision.com
34			*/
35			trait EeProductAttributeObserverTrait
36			{
37
38			/**
39			* Prepare the attributes of the entity that has to be persisted.
40			*
41			* @return array The prepared attributes
42			*/
43			public function prepareAttributes()
44			{
45
46			// load the attribute value
47			$attributeValue = $this->getAttributeValue();
			0 ignored issues – show Bug introduced 2017-01-02 16:46 UTC by Report Bug Copy Issue Report It seems like `getAttributeValue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
48
49			// laod the callbacks for the actual attribute code
50			$callbacks = $this->getCallbacksByType($this->getAttributeCode());
			0 ignored issues – show Bug introduced 2017-01-02 16:46 UTC by Report Bug Copy Issue Report It seems like `getAttributeCode()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2017-01-02 16:46 UTC by Report Bug Copy Issue Report It seems like `getCallbacksByType()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
51
52			// invoke the pre-cast callbacks
53			foreach ($callbacks as $callback) {
54			$attributeValue = $callback->handle($attributeValue);
55			}
56
57			// load the ID of the product that has been created recently
58			$lastEntityId = $this->getPrimaryKey();
59
60			// load the ID of the attribute to create the values for
61			$attributeId = $this->getAttributeId();
			0 ignored issues – show Bug introduced 2017-01-02 16:46 UTC by Report Bug Copy Issue Report It seems like `getAttributeId()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
62
63			// load the store ID
64			$storeId = $this->getRowStoreId(StoreViewCodes::ADMIN);
			0 ignored issues – show Bug introduced 2017-01-02 16:46 UTC by Report Bug Copy Issue Report It seems like `getRowStoreId()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
65
66			// load the backend type of the actual attribute
67			$backendType = $this->getBackendType();
			0 ignored issues – show Bug introduced 2017-01-02 16:46 UTC by Report Bug Copy Issue Report It seems like `getBackendType()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
68
69			// cast the value based on the backend type
70			$castedValue = $this->castValueByBackendType($backendType, $attributeValue);
			0 ignored issues – show Bug introduced 2017-01-02 16:46 UTC by Report Bug Copy Issue Report It seems like `castValueByBackendType()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
71
72			// prepare the attribute values
73			return $this->initializeEntity(
			0 ignored issues – show Bug introduced 2017-01-02 16:46 UTC by Report Bug Copy Issue Report It seems like `initializeEntity()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
74			array(
75			MemberNames::ROW_ID => $lastEntityId,
76			MemberNames::ATTRIBUTE_ID => $attributeId,
77			MemberNames::STORE_ID => $storeId,
78			MemberNames::VALUE => $castedValue
79			)
80			);
81			}
82
83			/**
84			* Return's the PK to create the product => attribute relation.
85			*
86			* @return integer The PK to create the relation with
87			*/
88			public function getPrimaryKey()
89			{
90			return $this->getLastRowId();
91			}
92
93			/**
94			* Return's the row ID of the product that has been created recently.
95			*
96			* @return string The row Id
97			*/
98			public function getLastRowId()
99			{
100			return $this->getSubject()->getLastRowId();
			0 ignored issues – show Bug introduced 2017-01-02 16:46 UTC by Report Bug Copy Issue Report It seems like `getSubject()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
101			}
102			}
103

techdivision / import-product-ee

Pull Request — master (#5)

EeProductAttributeObserverTrait::getLastRowId() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like