Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
35 | View Code Duplication | class BundleSelectionRepository extends AbstractRepository |
|
|
|||
36 | { |
||
37 | |||
38 | /** |
||
39 | * The prepared statement to load a existing bundle selection. |
||
40 | * |
||
41 | * @var \PDOStatement |
||
42 | */ |
||
43 | protected $bundleSelectionStmt; |
||
44 | |||
45 | /** |
||
46 | * Initializes the repository's prepared statements. |
||
47 | * |
||
48 | * @return void |
||
49 | */ |
||
50 | public function init() |
||
59 | |||
60 | /** |
||
61 | * Load's the bundle selection value with the passed option/product/parent product ID. |
||
62 | * |
||
63 | * @param integer $optionId The option ID of the bundle selection to be returned |
||
64 | * @param integer $productId The product ID of the bundle selection to be returned |
||
65 | * @param integer $parentProductId The parent product ID of the bundle selection to be returned |
||
66 | * |
||
67 | * @return array The bundle selection |
||
68 | */ |
||
69 | public function findOneByOptionIdAndProductIdAndParentProductId($optionId, $productId, $parentProductId) |
||
83 | } |
||
84 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.