Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
35 | View Code Duplication | class BundleOptionRepository extends AbstractRepository |
|
|
|||
36 | { |
||
37 | |||
38 | /** |
||
39 | * The prepared statement to load a existing bundle option. |
||
40 | * |
||
41 | * @var \PDOStatement |
||
42 | */ |
||
43 | protected $bundleOptionStmt; |
||
44 | |||
45 | /** |
||
46 | * Initializes the repository's prepared statements. |
||
47 | * |
||
48 | * @return void |
||
49 | */ |
||
50 | public function init() |
||
59 | |||
60 | /** |
||
61 | * Load's the bundle option with the passed name, store + parent ID. |
||
62 | * |
||
63 | * @param string $title The title of the bundle option to be returned |
||
64 | * @param integer $storeId The store ID of the bundle option to be returned |
||
65 | * @param integer $parentId The entity of the product the bundle option is related with |
||
66 | * |
||
67 | * @return array The bundle option |
||
68 | */ |
||
69 | public function findOneByNameAndStoreIdAndParentId($title, $storeId, $parentId) |
||
83 | } |
||
84 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.