Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
36 | View Code Duplication | class BundleOptionUpdateObserver extends BundleOptionObserver |
|
|
|||
37 | { |
||
38 | |||
39 | /** |
||
40 | * Initialize the bundle option with the passed attributes and returns an instance. |
||
41 | * |
||
42 | * @param array $attr The bundle option attributes |
||
43 | * |
||
44 | * @return array The initialized bundle option |
||
45 | */ |
||
46 | protected function initializeBundleOption(array $attr) |
||
62 | |||
63 | /** |
||
64 | * Load's the bundle option with the passed name, store + parent ID. |
||
65 | * |
||
66 | * @param string $title The title of the bundle option to be returned |
||
67 | * @param integer $storeId The store ID of the bundle option to be returned |
||
68 | * @param integer $parentId The entity of the product the bundle option is related with |
||
69 | * |
||
70 | * @return array The bundle option |
||
71 | */ |
||
72 | protected function loadBundleOption($title, $storeId, $parentId) |
||
76 | |||
77 | /** |
||
78 | * Return's the store ID of the actual row, or of the default store |
||
79 | * if no store view code is set in the CSV file. |
||
80 | * |
||
81 | * @param string|null $default The default store view code to use, if no store view code is set in the CSV file |
||
82 | * |
||
83 | * @return integer The ID of the actual store |
||
84 | * @throws \Exception Is thrown, if the store with the actual code is not available |
||
85 | */ |
||
86 | protected function getRowStoreId($default = null) |
||
90 | } |
||
91 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.