ProductBundleProcessor::__construct() - Code Metrics - Inspection of "Merge pull request #10 from wagnert/master" - techdivision/import-product-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 0c2dcd...3f964a )

by Tim
created 2017-03-29 14:11 UTC
ProductBundleProcessor::__construct() A

↳ Parent: ProductBundleProcessor
Complexity

Conditions	1
Paths	1
Size

Total Lines	21
Code Lines	19
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	0
CRAP Score	2
Importance

Changes
Metric	Value
dl	0
loc	21
ccs	0
cts	21
cp	0
rs	9.3142
c	0
b	0
f	0
cc	1
eloc	19
nc	1
nop	9
crap	2
How to fix Many Parameters

<?php

/**
 * TechDivision\Import\Product\Bundle\Services\ProductProcessor
 *
 * NOTICE OF LICENSE
 *
 * This source file is subject to the Open Software License (OSL 3.0)
 * that is available through the world-wide-web at this URL:
 * http://opensource.org/licenses/osl-3.0.php
 *
 * PHP version 5
 *
 * @author    Tim Wagner <[email protected]>
 * @copyright 2016 TechDivision GmbH <[email protected]>
 * @license   http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
 * @link      https://github.com/techdivision/import-product-bundle
 * @link      http://www.techdivision.com
 */

namespace TechDivision\Import\Product\Bundle\Services;

use TechDivision\Import\Product\Bundle\Repositories\BundleOptionRepository;
use TechDivision\Import\Product\Bundle\Repositories\BundleOptionValueRepository;
use TechDivision\Import\Product\Bundle\Repositories\BundleSelectionRepository;
use TechDivision\Import\Product\Bundle\Repositories\BundleSelectionPriceRepository;
use TechDivision\Import\Product\Bundle\Actions\ProductBundleOptionAction;
use TechDivision\Import\Product\Bundle\Actions\ProductBundleOptionValueAction;
use TechDivision\Import\Product\Bundle\Actions\ProductBundleSelectionAction;
use TechDivision\Import\Product\Bundle\Actions\ProductBundleSelectionPriceAction;

/**
 * A SLSB providing methods to load product data using a PDO connection.
 *
 * @author    Tim Wagner <[email protected]>
 * @copyright 2016 TechDivision GmbH <[email protected]>
 * @license   http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
 * @link      https://github.com/techdivision/import-product-bundle
 * @link      http://www.techdivision.com
 */
class ProductBundleProcessor implements ProductBundleProcessorInterface
{

    /**
     * A PDO connection initialized with the values from the Doctrine EntityManager.
     *
     * @var \PDO
     */
    protected $connection;

    /**
     * The action for product bundle option CRUD methods.
     *
     * @var \TechDivision\Import\Product\Bundle\Actions\ProductBundleOptionAction
     */
    protected $productBundleOptionAction;

    /**
     * The action for product bundle option value CRUD methods.
     *
     * @var \TechDivision\Import\Product\Bundle\Actions\ProductBundleOptionValueAction
     */
    protected $productBundleOptionValueAction;

    /**
     * The action for product bundle selection CRUD methods.
     *
     * @var \TechDivision\Import\Product\Bundle\Actions\ProductBundleSelectionAction
     */
    protected $productBundleSelectionAction;

    /**
     * The action for product bundle selection price CRUD methods.
     *
     * @var \TechDivision\Import\Product\Bundle\Actions\ProductBundleSelectionPriceAction
     */
    protected $productBundleSelectionPriceAction;

    /**
     * The repository to load bundle option data.
     *
     * @var \TechDivision\Import\Product\Bundle\Respository\BundleOptionRepository
     */
    protected $bundleOptionRespository;

    /**
     * The repository to load bundle option value data.
     *
     * @var \TechDivision\Import\Product\Bundle\Respository\BundleOptionValueRepository
     */
    protected $bundleOptionValueRespository;

    /**
     * The repository to load bundle selection data.
     *
     * @var \TechDivision\Import\Product\Bundle\Respository\BundleSelectionRepository
     */
    protected $bundleSelectionRespository;

    /**
     * The repository to load bundle selection price data.
     *
     * @var \TechDivision\Import\Product\Bundle\Respository\BundleSelectionPriceRepository
     */
    protected $bundleSelectionPriceRespository;

    /**
     * Initialize the processor with the necessary assembler and repository instances.
     *
     * @param \PDO                                                                           $connection                        The PDO connection to use
     * @param \TechDivision\Import\Product\Bundle\Respository\BundleOptionRepository         $bundleOptionRepository            The bundle option repository to use
     * @param \TechDivision\Import\Product\Bundle\Respository\BundleOptionValueRepository    $bundleOptionValueRepository       The bundle option value repository to use
     * @param \TechDivision\Import\Product\Bundle\Respository\BundleSelectionRepository      $bundleSelectionRepository         The bundle selection repository to use
     * @param \TechDivision\Import\Product\Bundle\Respository\BundleSelectionPriceRepository $bundleSelectionPriceRepository    The bundle selection price repository to use
     * @param \TechDivision\Import\Product\Bundle\Actions\ProductBundleOptionAction          $productBundleOptionAction         The product bundle option action to use
     * @param \TechDivision\Import\Product\Bundle\Actions\ProductBundleOptionValueAction     $productBundleOptionValueAction    The product bundle option value action to use
     * @param \TechDivision\Import\Product\Bundle\Actions\ProductBundleSelectionAction       $productBundleSelectionAction      The product bundle selection action to use
     * @param \TechDivision\Import\Product\Bundle\Actions\ProductBundleSelectionPriceAction  $productBundleSelectionPriceAction The product bundle selection price action to use
     */
    public function __construct(
        \PDO $connection,
        BundleOptionRepository $bundleOptionRepository,
        BundleOptionValueRepository $bundleOptionValueRepository,
        BundleSelectionRepository $bundleSelectionRepository,
        BundleSelectionPriceRepository $bundleSelectionPriceRepository,
        ProductBundleOptionAction $productBundleOptionAction,
        ProductBundleOptionValueAction $productBundleOptionValueAction,
        ProductBundleSelectionAction $productBundleSelectionAction,
        ProductBundleSelectionPriceAction $productBundleSelectionPriceAction
    ) {
        $this->setConnection($connection);
        $this->setBundleOptionRepository($bundleOptionRepository);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->setBundleOptionValueRepository($bundleOptionValueRepository);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->setBundleSelectionRepository($bundleSelectionRepository);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->setBundleSelectionPriceRepository($bundleSelectionPriceRepository);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->setProductBundleOptionAction($productBundleOptionAction);
        $this->setProductBundleOptionValueAction($productBundleOptionValueAction);
        $this->setProductBundleSelectionAction($productBundleSelectionAction);
        $this->setProductBundleSelectionPriceAction($productBundleSelectionPriceAction);
    }

    /**
     * Set's the passed connection.
     *
     * @param \PDO $connection The connection to set
     *
     * @return void
     */
    public function setConnection(\PDO $connection)
    {
        $this->connection = $connection;
    }

    /**
     * Return's the connection.
     *
     * @return \PDO The connection instance
     */
    public function getConnection()
    {
        return $this->connection;
    }

    /**
     * Turns off autocommit mode. While autocommit mode is turned off, changes made to the database via the PDO
     * object instance are not committed until you end the transaction by calling ProductProcessor::commit().
     * Calling ProductProcessor::rollBack() will roll back all changes to the database and return the connection
     * to autocommit mode.
     *
     * @return boolean Returns TRUE on success or FALSE on failure
     * @link http://php.net/manual/en/pdo.begintransaction.php
     */
    public function beginTransaction()
    {
        return $this->connection->beginTransaction();
    }

    /**
     * Commits a transaction, returning the database connection to autocommit mode until the next call to
     * ProductProcessor::beginTransaction() starts a new transaction.
     *
     * @return boolean Returns TRUE on success or FALSE on failure
     * @link http://php.net/manual/en/pdo.commit.php
     */
    public function commit()
    {
        return $this->connection->commit();
    }

    /**
     * Rolls back the current transaction, as initiated by ProductProcessor::beginTransaction().
     *
     * If the database was set to autocommit mode, this function will restore autocommit mode after it has
     * rolled back the transaction.
     *
     * Some databases, including MySQL, automatically issue an implicit COMMIT when a database definition
     * language (DDL) statement such as DROP TABLE or CREATE TABLE is issued within a transaction. The implicit
     * COMMIT will prevent you from rolling back any other changes within the transaction boundary.
     *
     * @return boolean Returns TRUE on success or FALSE on failure
     * @link http://php.net/manual/en/pdo.rollback.php
     */
    public function rollBack()
    {
        return $this->connection->rollBack();
    }

    /**
     * Set's the action with the product bundle option CRUD methods.
     *
     * @param \TechDivision\Import\Product\Bundle\Actions\ProductBundleOptionAction $productBundleOptionAction The action with the product bundle option CRUD methods
     *
     * @return void
     */
    public function setProductBundleOptionAction($productBundleOptionAction)
    {
        $this->productBundleOptionAction = $productBundleOptionAction;
    }

    /**
     * Return's the action with the product bundle option CRUD methods.
     *
     * @return \TechDivision\Import\Product\Bundle\Actions\ProductBundleOptionAction The action instance
     */
    public function getProductBundleOptionAction()
    {
        return $this->productBundleOptionAction;
    }

    /**
     * Set's the action with the product bundle option value CRUD methods.
     *
     * @param \TechDivision\Import\Product\Bundle\Actions\ProductBundleOptionValueAction $productBundleOptionValueAction The action with the product bundle option value CRUD methods
     *
     * @return void
     */
    public function setProductBundleOptionValueAction($productBundleOptionValueAction)
    {
        $this->productBundleOptionValueAction = $productBundleOptionValueAction;
    }

    /**
     * Return's the action with the product bundle option value CRUD methods.
     *
     * @return \TechDivision\Import\Product\Bundle\Actions\ProductBundleOptionValueAction The action instance
     */
    public function getProductBundleOptionValueAction()
    {
        return $this->productBundleOptionValueAction;
    }

    /**
     * Set's the action with the product bundle selection CRUD methods.
     *
     * @param \TechDivision\Import\Product\Bundle\Actions\ProductBundleSelectionAction $productBundleSelectionAction The action with the product bundle selection CRUD methods
     *
     * @return void
     */
    public function setProductBundleSelectionAction($productBundleSelectionAction)
    {
        $this->productBundleSelectionAction = $productBundleSelectionAction;
    }

    /**
     * Return's the action with the product bundle selection CRUD methods.
     *
     * @return \TechDivision\Import\Product\Bundle\Actions\ProductBundleSelectionAction The action instance
     */
    public function getProductBundleSelectionAction()
    {
        return $this->productBundleSelectionAction;
    }

    /**
     * Set's the action with the product bundle selection price CRUD methods.
     *
     * @param \TechDivision\Import\Product\Bundle\Actions\ProductBundleSelectionPriceAction $productBundleSelectionPriceAction The action with the product bundle selection price CRUD methods
     *
     * @return void
     */
    public function setProductBundleSelectionPriceAction($productBundleSelectionPriceAction)
    {
        $this->productBundleSelectionPriceAction = $productBundleSelectionPriceAction;
    }

    /**
     * Return's the action with the product bundle selection price CRUD methods.
     *
     * @return \TechDivision\Import\Product\Bundle\Actions\ProductBundleSelectionPriceAction The action instance
     */
    public function getProductBundleSelectionPriceAction()
    {
        return $this->productBundleSelectionPriceAction;
    }

    /**
     * Set's the repository to load bundle option data.
     *
     * @param \TechDivision\Import\Product\Bundle\Repository\BundleOptionRespository $bundleOptionRespository The repository instance
     *
     * @return void
     */
    public function setBundleOptionRepository($bundleOptionRespository)
    {
        $this->bundleOptionRespository = $bundleOptionRespository;

    }

    /**
     * Return's the respository to load bundle option data.
     *
     * @return \TechDivision\Import\Product\Bundle\Repository\BundleOptionRespository The repository instance
     */
    public function getBundleOptionRepository()
    {
        return $this->bundleOptionRespository;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Set's the repository to load bundle option value data.
     *
     * @param \TechDivision\Import\Product\Bundle\Repository\BundleOptionValueRespository $bundleOptionValueRespository The repository instance
     *
     * @return void
     */
    public function setBundleOptionValueRepository($bundleOptionValueRespository)
    {
        $this->bundleOptionValueRespository = $bundleOptionValueRespository;

    }

    /**
     * Return's the respository to load bundle option value data.
     *
     * @return \TechDivision\Import\Product\Bundle\Repository\BundleOptionValueRespository The repository instance
     */
    public function getBundleOptionValueRepository()
    {
        return $this->bundleOptionValueRespository;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Set's the repository to load bundle selection data.
     *
     * @param \TechDivision\Import\Product\Bundle\Repository\BundleSelectionRespository $bundleSelectionRespository The repository instance
     *
     * @return void
     */
    public function setBundleSelectionRepository($bundleSelectionRespository)
    {
        $this->bundleSelectionRespository = $bundleSelectionRespository;

    }

    /**
     * Return's the respository to load bundle selection data.
     *
     * @return \TechDivision\Import\Product\Bundle\Repository\BundleSelectionRespository The repository instance
     */
    public function getBundleSelectionRepository()
    {
        return $this->bundleSelectionRespository;
    }

    /**
     * Set's the repository to load bundle selection price data.
     *
     * @param \TechDivision\Import\Product\Bundle\Repository\BundleSelectionPriceRespository $bundleSelectionPriceRespository The repository instance
     *
     * @return void
     */
    public function setBundleSelectionPriceRepository($bundleSelectionPriceRespository)
    {
        $this->bundleSelectionPriceRespository = $bundleSelectionPriceRespository;

    }

    /**
     * Return's the respository to load bundle selection price data.
     *
     * @return \TechDivision\Import\Product\Bundle\Repository\BundleSelectionPriceRespository The repository instance
     */
    public function getBundleSelectionPriceRepository()
    {
        return $this->bundleSelectionPriceRespository;
    }

    /**
     * Load's the bundle option with the passed name, store + parent ID.
     *
     * @param string  $title    The title of the bundle option to be returned
     * @param integer $storeId  The store ID of the bundle option to be returned
     * @param integer $parentId The entity of the product the bundle option is related with
     *
     * @return array The bundle option
     */
    public function loadBundleOption($title, $storeId, $parentId)
    {
        return $this->getBundleOptionRepository()->findOneByNameAndStoreIdAndParentId($title, $storeId, $parentId);
    }

    /**
     * Load's the bundle option value with the passed name, store + parent ID.
     *
     * @param string  $title    The title of the bundle option value to be returned
     * @param integer $storeId  The store ID of the bundle option value to be returned
     * @param integer $parentId The entity of the product the bundle option value is related with
     *
     * @return array The bundle option
     */
    public function loadBundleOptionValue($title, $storeId, $parentId)
    {
        return $this->getBundleOptionValueRepository()->findOneByNameAndStoreIdAndParentId($title, $storeId, $parentId);
    }

    /**
     * Load's the bundle selection value with the passed option/product/parent product ID.
     *
     * @param integer $optionId        The option ID of the bundle selection to be returned
     * @param integer $productId       The product ID of the bundle selection to be returned
     * @param integer $parentProductId The parent product ID of the bundle selection to be returned
     *
     * @return array The bundle selection
     */
    public function loadBundleSelection($optionId, $productId, $parentProductId)
    {
        return $this->getBundleSelectionRepository()->findOneByOptionIdAndProductIdAndParentProductId($optionId, $productId, $parentProductId);
    }

    /**
     * Load's the bundle selection price with the passed selection/website ID.
     *
     * @param integer $selectionId The selection ID of the bundle selection price to be returned
     * @param integer $websiteId   The website ID of the bundle selection price to be returned
     *
     * @return array The bundle selection price
     */
    public function loadBundleSelectionPrice($selectionId, $websiteId)
    {
        return $this->getBundleSelectionPriceRepository()->findOneByOptionIdAndProductIdAndParentProductId($selectionId, $websiteId);
    }

    /**
     * Persist's the passed product bundle option data and return's the ID.
     *
     * @param array $productBundleOption The product bundle option data to persist
     *
     * @return string The ID of the persisted entity
     */
    public function persistProductBundleOption($productBundleOption)
    {
        return $this->getProductBundleOptionAction()->persist($productBundleOption);
    }

    /**
     * Persist's the passed product bundle option value data.
     *
     * @param array $productBundleOptionValue The product bundle option value data to persist
     *
     * @return void
     */
    public function persistProductBundleOptionValue($productBundleOptionValue)
    {
        $this->getProductBundleOptionValueAction()->persist($productBundleOptionValue);
    }

    /**
     * Persist's the passed product bundle selection data and return's the ID.
     *
     * @param array $productBundleSelection The product bundle selection data to persist
     *
     * @return string The ID of the persisted entity
     */
    public function persistProductBundleSelection($productBundleSelection)
    {
        return $this->getProductBundleSelectionAction()->persist($productBundleSelection);
    }

    /**
     * Persist's the passed product bundle selection price data and return's the ID.
     *
     * @param array $productBundleSelectionPrice The product bundle selection price data to persist
     *
     * @return void
     */
    public function persistProductBundleSelectionPrice($productBundleSelectionPrice)
    {
        return $this->getProductBundleSelectionPriceAction()->persist($productBundleSelectionPrice);
    }
}

techdivision / import-product-bundle

Push — master ( 0c2dcd...3f964a )

ProductBundleProcessor::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like
