CustomerAddressExportObserver::process() - Code Metrics - Inspection of "Refactoring empty customer address" - techdivision/import-customer-address - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — customer-address-fix ( e21864...21ab4b )

unknown

created 2022-08-05 13:05 UTC

CustomerAddressExportObserver::process() B

↳ Parent: CustomerAddressExportObserver

Complexity

Conditions	6
Paths	2

Size

Total Lines	77
Code Lines	61

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
eloc	61
c	2
b	0
f	0
dl	0
loc	77
rs	8.2286
cc	6
nc	2
nop	0

How to fix Long Method

<?php

/**
 * TechDivision\Import\Customer\Address\Observers\CustomerAddressExportObserver
 *
 * PHP version 7
 *
 * @author    Tim Wagner <[email protected]>
 * @copyright 2018 TechDivision GmbH <[email protected]>
 * @license   https://opensource.org/licenses/MIT
 * @link      https://github.com/techdivision/import-customer-address
 * @link      http://www.techdivision.com
 */

namespace TechDivision\Import\Customer\Address\Observers;

use TechDivision\Import\Customer\Address\Utils\ColumnKeys;
use TechDivision\Import\Customer\Address\Services\CustomerAddressBunchProcessorInterface;

/**
 * Prepares the artefacts for the customer address export.
 *
 * @author    Tim Wagner <[email protected]>
 * @copyright 2018 TechDivision GmbH <[email protected]>
 * @license   https://opensource.org/licenses/MIT
 * @link      https://github.com/techdivision/import-customer-address
 * @link      http://www.techdivision.com
 */
class CustomerAddressExportObserver extends AbstractCustomerAddressImportObserver
{

    /**
     * The artefact type.
     *
     * @var string
     */
    const ARTEFACT_TYPE = 'customer-import-address';

    /**
     * The customer address bunch processor instance.
     *
     * @var \TechDivision\Import\Customer\Address\Services\CustomerAddressBunchProcessorInterface
     */
    protected $customerAddressBunchProcessor;

    /**
     * Initialize the observer with the passed customer bunch processor instance.
     *
     * @param \TechDivision\Import\Customer\Address\Services\CustomerAddressBunchProcessorInterface $customerAddressBunchProcessor The customer address bunch processor instance
     */
    public function __construct(CustomerAddressBunchProcessorInterface $customerAddressBunchProcessor)
    {
        $this->customerAddressBunchProcessor = $customerAddressBunchProcessor;
    }

    /**
     * Return's the customer address bunch processor instance.
     *
     * @return \TechDivision\Import\Customer\Address\Services\CustomerAddressBunchProcessorInterface The customer address bunch processor instance
     */
    protected function getCustomerAddressBunchProcessor()
    {
        return $this->customerAddressBunchProcessor;
    }

    /**
     * Process the observer's business logic.
     *
     * @return void
     * @throws \Exception
     */
    protected function process()
    {
        // load the email with the column keys of the customer-address CSV file
        $email = $this->getValue(\TechDivision\Import\Customer\Utils\ColumnKeys::EMAIL);

        $firstName = $this->getValue(ColumnKeys::ADDRESS_FIRSTNAME, '');
        $lastName = $this->getValue(ColumnKeys::ADDRESS_LASTNAME, '');
        $addressStreet = $this->getValue(ColumnKeys::ADDRESS_STREET, '');
        $addressCity = $this->getValue(ColumnKeys::ADDRESS_CITY, '');
        $countryId = $this->getValue(ColumnKeys::ADDRESS_COUNTRY_ID, '');

        if (empty($addressCity)
            && empty($addressStreet)
            && empty($firstName)
            && empty($lastName)
            && empty($countryId)
        ) {
            $this->getSystemLogger()->warning(
                sprintf(
                    'The customer address was not initialized, no address data specified for the email "%s"',
                    $email
                )
            );
            return;
        }
        // initialize the array for the links
        $artefacts = array();
        
        $artefacts[] = $this->newArtefact(
            array(
                ColumnKeys::ENTITY_ID                => $this->getValue(ColumnKeys::ENTITY_ID),
                ColumnKeys::INCREMENT_ID             => $this->getValue(ColumnKeys::ADDRESS_INCREMENT_ID),
                ColumnKeys::EMAIL                    => $email,
                ColumnKeys::WEBSITE                  => $this->getValue(ColumnKeys::WEBSITE),
                ColumnKeys::CITY                     => $addressCity,
                ColumnKeys::COMPANY                  => $this->getValue(ColumnKeys::ADDRESS_COMPANY),
                ColumnKeys::COUNTRY_ID               => $countryId,
                ColumnKeys::FAX                      => $this->getValue(ColumnKeys::ADDRESS_FAX),
                ColumnKeys::FIRSTNAME                => $firstName,
                ColumnKeys::LASTNAME                 => $lastName,
                ColumnKeys::MIDDLENAME               => $this->getValue(ColumnKeys::ADDRESS_MIDDLENAME),
                ColumnKeys::POSTCODE                 => $this->getValue(ColumnKeys::ADDRESS_POSTCODE),
                ColumnKeys::PREFIX                   => $this->getValue(ColumnKeys::ADDRESS_PREFIX),
                ColumnKeys::REGION                   => $this->getValue(ColumnKeys::ADDRESS_REGION),
                ColumnKeys::STREET                   => $addressStreet,
                ColumnKeys::SUFFIX                   => $this->getValue(ColumnKeys::ADDRESS_SUFFIX),
                ColumnKeys::TELEPHONE                => $this->getValue(ColumnKeys::ADDRESS_TELEPHONE),
                ColumnKeys::VAT_ID                   => $this->getValue(ColumnKeys::ADDRESS_VAT_ID),
                ColumnKeys::ADDRESS_DEFAULT_BILLING  => $this->getValue(ColumnKeys::ADDRESS_DEFAULT_BILLING),
                ColumnKeys::ADDRESS_DEFAULT_SHIPPING => $this->getValue(ColumnKeys::ADDRESS_DEFAULT_SHIPPING)
            ),
            array(
                ColumnKeys::ENTITY_ID                => ColumnKeys::ENTITY_ID,
                ColumnKeys::INCREMENT_ID             => ColumnKeys::INCREMENT_ID,
                ColumnKeys::WEBSITE                  => ColumnKeys::WEBSITE,
                ColumnKeys::EMAIL                    => ColumnKeys::EMAIL,
                ColumnKeys::CITY                     => ColumnKeys::ADDRESS_CITY,
                ColumnKeys::COMPANY                  => ColumnKeys::ADDRESS_COMPANY,
                ColumnKeys::COUNTRY_ID               => ColumnKeys::ADDRESS_COUNTRY_ID,
                ColumnKeys::FAX                      => ColumnKeys::ADDRESS_FAX,
                ColumnKeys::FIRSTNAME                => ColumnKeys::ADDRESS_FIRSTNAME,
                ColumnKeys::LASTNAME                 => ColumnKeys::ADDRESS_LASTNAME,
                ColumnKeys::MIDDLENAME               => ColumnKeys::ADDRESS_MIDDLENAME,
                ColumnKeys::POSTCODE                 => ColumnKeys::ADDRESS_POSTCODE,
                ColumnKeys::PREFIX                   => ColumnKeys::ADDRESS_PREFIX,
                ColumnKeys::REGION                   => ColumnKeys::ADDRESS_REGION,
                ColumnKeys::STREET                   => ColumnKeys::ADDRESS_STREET,
                ColumnKeys::SUFFIX                   => ColumnKeys::ADDRESS_SUFFIX,
                ColumnKeys::TELEPHONE                => ColumnKeys::ADDRESS_TELEPHONE,
                ColumnKeys::VAT_ID                   => ColumnKeys::ADDRESS_VAT_ID,
                ColumnKeys::ADDRESS_DEFAULT_BILLING  => ColumnKeys::ADDRESS_DEFAULT_BILLING,
                ColumnKeys::ADDRESS_DEFAULT_SHIPPING => ColumnKeys::ADDRESS_DEFAULT_SHIPPING
            )
        );

        // append the links to the subject
        $this->addArtefacts($artefacts);
    }

    /**
     * Create's and return's a new empty artefact entity.
     *
     * @param array $columns             The array with the column data
     * @param array $originalColumnNames The array with a mapping from the old to the new column names
     *
     * @return array The new artefact entity
     */
    protected function newArtefact(array $columns, array $originalColumnNames)
    {
        return $this->getSubject()->newArtefact($columns, $originalColumnNames);
    }

    /**
     * Add the passed product type artefacts to the product with the
     * last entity ID.
     *
     * @param array $artefacts The product type artefacts
     *
     * @return void
     * @uses \TechDivision\Import\Product\Media\Subjects\MediaSubject::getLastEntityId()
     */
    protected function addArtefacts(array $artefacts)
    {
        $this->getSubject()->addArtefacts(CustomerAddressExportObserver::ARTEFACT_TYPE, $artefacts, false);
    }
}


1			<?php
2
3			/**
4			* TechDivision\Import\Customer\Address\Observers\CustomerAddressExportObserver
5			*
6			* PHP version 7
7			*
8			* @author Tim Wagner <[email protected]>
9			* @copyright 2018 TechDivision GmbH <[email protected]>
10			* @license https://opensource.org/licenses/MIT
11			* @link https://github.com/techdivision/import-customer-address
12			* @link http://www.techdivision.com
13			*/
14
15			namespace TechDivision\Import\Customer\Address\Observers;
16
17			use TechDivision\Import\Customer\Address\Utils\ColumnKeys;
18			use TechDivision\Import\Customer\Address\Services\CustomerAddressBunchProcessorInterface;
19
20			/**
21			* Prepares the artefacts for the customer address export.
22			*
23			* @author Tim Wagner <[email protected]>
24			* @copyright 2018 TechDivision GmbH <[email protected]>
25			* @license https://opensource.org/licenses/MIT
26			* @link https://github.com/techdivision/import-customer-address
27			* @link http://www.techdivision.com
28			*/
29			class CustomerAddressExportObserver extends AbstractCustomerAddressImportObserver
30			{
31
32			/**
33			* The artefact type.
34			*
35			* @var string
36			*/
37			const ARTEFACT_TYPE = 'customer-import-address';
38
39			/**
40			* The customer address bunch processor instance.
41			*
42			* @var \TechDivision\Import\Customer\Address\Services\CustomerAddressBunchProcessorInterface
43			*/
44			protected $customerAddressBunchProcessor;
45
46			/**
47			* Initialize the observer with the passed customer bunch processor instance.
48			*
49			* @param \TechDivision\Import\Customer\Address\Services\CustomerAddressBunchProcessorInterface $customerAddressBunchProcessor The customer address bunch processor instance
50			*/
51			public function __construct(CustomerAddressBunchProcessorInterface $customerAddressBunchProcessor)
52			{
53			$this->customerAddressBunchProcessor = $customerAddressBunchProcessor;
54			}
55
56			/**
57			* Return's the customer address bunch processor instance.
58			*
59			* @return \TechDivision\Import\Customer\Address\Services\CustomerAddressBunchProcessorInterface The customer address bunch processor instance
60			*/
61			protected function getCustomerAddressBunchProcessor()
62			{
63			return $this->customerAddressBunchProcessor;
64			}
65
66			/**
67			* Process the observer's business logic.
68			*
69			* @return void
70			* @throws \Exception
71			*/
72			protected function process()
73			{
74			// load the email with the column keys of the customer-address CSV file
75			$email = $this->getValue(\TechDivision\Import\Customer\Utils\ColumnKeys::EMAIL);
76
77			$firstName = $this->getValue(ColumnKeys::ADDRESS_FIRSTNAME, '');
78			$lastName = $this->getValue(ColumnKeys::ADDRESS_LASTNAME, '');
79			$addressStreet = $this->getValue(ColumnKeys::ADDRESS_STREET, '');
80			$addressCity = $this->getValue(ColumnKeys::ADDRESS_CITY, '');
81			$countryId = $this->getValue(ColumnKeys::ADDRESS_COUNTRY_ID, '');
82
83			if (empty($addressCity)
84			&& empty($addressStreet)
85			&& empty($firstName)
86			&& empty($lastName)
87			&& empty($countryId)
88			) {
89			$this->getSystemLogger()->warning(
90			sprintf(
91			'The customer address was not initialized, no address data specified for the email "%s"',
92			$email
93			)
94			);
95			return;
96			}
97			// initialize the array for the links
98			$artefacts = array();
99
100			$artefacts[] = $this->newArtefact(
101			array(
102			ColumnKeys::ENTITY_ID => $this->getValue(ColumnKeys::ENTITY_ID),
103			ColumnKeys::INCREMENT_ID => $this->getValue(ColumnKeys::ADDRESS_INCREMENT_ID),
104			ColumnKeys::EMAIL => $email,
105			ColumnKeys::WEBSITE => $this->getValue(ColumnKeys::WEBSITE),
106			ColumnKeys::CITY => $addressCity,
107			ColumnKeys::COMPANY => $this->getValue(ColumnKeys::ADDRESS_COMPANY),
108			ColumnKeys::COUNTRY_ID => $countryId,
109			ColumnKeys::FAX => $this->getValue(ColumnKeys::ADDRESS_FAX),
110			ColumnKeys::FIRSTNAME => $firstName,
111			ColumnKeys::LASTNAME => $lastName,
112			ColumnKeys::MIDDLENAME => $this->getValue(ColumnKeys::ADDRESS_MIDDLENAME),
113			ColumnKeys::POSTCODE => $this->getValue(ColumnKeys::ADDRESS_POSTCODE),
114			ColumnKeys::PREFIX => $this->getValue(ColumnKeys::ADDRESS_PREFIX),
115			ColumnKeys::REGION => $this->getValue(ColumnKeys::ADDRESS_REGION),
116			ColumnKeys::STREET => $addressStreet,
117			ColumnKeys::SUFFIX => $this->getValue(ColumnKeys::ADDRESS_SUFFIX),
118			ColumnKeys::TELEPHONE => $this->getValue(ColumnKeys::ADDRESS_TELEPHONE),
119			ColumnKeys::VAT_ID => $this->getValue(ColumnKeys::ADDRESS_VAT_ID),
120			ColumnKeys::ADDRESS_DEFAULT_BILLING => $this->getValue(ColumnKeys::ADDRESS_DEFAULT_BILLING),
121			ColumnKeys::ADDRESS_DEFAULT_SHIPPING => $this->getValue(ColumnKeys::ADDRESS_DEFAULT_SHIPPING)
122			),
123			array(
124			ColumnKeys::ENTITY_ID => ColumnKeys::ENTITY_ID,
125			ColumnKeys::INCREMENT_ID => ColumnKeys::INCREMENT_ID,
126			ColumnKeys::WEBSITE => ColumnKeys::WEBSITE,
127			ColumnKeys::EMAIL => ColumnKeys::EMAIL,
128			ColumnKeys::CITY => ColumnKeys::ADDRESS_CITY,
129			ColumnKeys::COMPANY => ColumnKeys::ADDRESS_COMPANY,
130			ColumnKeys::COUNTRY_ID => ColumnKeys::ADDRESS_COUNTRY_ID,
131			ColumnKeys::FAX => ColumnKeys::ADDRESS_FAX,
132			ColumnKeys::FIRSTNAME => ColumnKeys::ADDRESS_FIRSTNAME,
133			ColumnKeys::LASTNAME => ColumnKeys::ADDRESS_LASTNAME,
134			ColumnKeys::MIDDLENAME => ColumnKeys::ADDRESS_MIDDLENAME,
135			ColumnKeys::POSTCODE => ColumnKeys::ADDRESS_POSTCODE,
136			ColumnKeys::PREFIX => ColumnKeys::ADDRESS_PREFIX,
137			ColumnKeys::REGION => ColumnKeys::ADDRESS_REGION,
138			ColumnKeys::STREET => ColumnKeys::ADDRESS_STREET,
139			ColumnKeys::SUFFIX => ColumnKeys::ADDRESS_SUFFIX,
140			ColumnKeys::TELEPHONE => ColumnKeys::ADDRESS_TELEPHONE,
141			ColumnKeys::VAT_ID => ColumnKeys::ADDRESS_VAT_ID,
142			ColumnKeys::ADDRESS_DEFAULT_BILLING => ColumnKeys::ADDRESS_DEFAULT_BILLING,
143			ColumnKeys::ADDRESS_DEFAULT_SHIPPING => ColumnKeys::ADDRESS_DEFAULT_SHIPPING
144			)
145			);
146
147			// append the links to the subject
148			$this->addArtefacts($artefacts);
149			}
150
151			/**
152			* Create's and return's a new empty artefact entity.
153			*
154			* @param array $columns The array with the column data
155			* @param array $originalColumnNames The array with a mapping from the old to the new column names
156			*
157			* @return array The new artefact entity
158			*/
159			protected function newArtefact(array $columns, array $originalColumnNames)
160			{
161			return $this->getSubject()->newArtefact($columns, $originalColumnNames);
162			}
163
164			/**
165			* Add the passed product type artefacts to the product with the
166			* last entity ID.
167			*
168			* @param array $artefacts The product type artefacts
169			*
170			* @return void
171			* @uses \TechDivision\Import\Product\Media\Subjects\MediaSubject::getLastEntityId()
172			*/
173			protected function addArtefacts(array $artefacts)
174			{
175			$this->getSubject()->addArtefacts(CustomerAddressExportObserver::ARTEFACT_TYPE, $artefacts, false);
176			}
177			}
178

techdivision / import-customer-address

Push — customer-address-fix ( e21864...21ab4b )

CustomerAddressExportObserver::process() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like