TechDivision\Import\Cli\SimpleConfigurationLoader::createConfiguration()

Complexity

Conditions	11
Paths	52

Size

Total Lines	78
Code Lines	32

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	132

Importance

Changes	5
Bugs	0	Features	0

<?php
    protected function createConfiguration($filename = null)
    {

        // initialize the params specified with the --params parameter
        $params = null;

        // try to load the params from the commandline
        if ($this->input->hasOptionSpecified(InputOptionKeysInterface::PARAMS) && $this->input->getOption(InputOptionKeysInterface::PARAMS)) {

The method hasOptionSpecified() does not exist on Symfony\Component\Console\Input\InputInterface. Did you maybe mean hasOption()?

            $params = $this->input->getOption(InputOptionKeysInterface::PARAMS);
        }

        // initialize the params file specified with the --params-file parameter
        $paramsFile = null;

        // try to load the path of the params file from the commandline
        if ($this->input->hasOptionSpecified(InputOptionKeysInterface::PARAMS_FILE) && $this->input->getOption(InputOptionKeysInterface::PARAMS_FILE)) {
            $paramsFile = $this->input->getOption(InputOptionKeysInterface::PARAMS_FILE);
        }

        // if a filename has been passed, try to load the configuration from the file
        if (is_file($filename)) {

It seems like $filename can also be of type null; however, parameter $filename of is_file() does only seem to accept string, maybe add an additional type check?

            return $this->configurationFactory->factory($filename, pathinfo($filename, PATHINFO_EXTENSION), $params, $paramsFile);

The call to TechDivision\Import\Configuration\ConfigurationFactoryInterface::factory() has too many arguments starting with $params.

It seems like pathinfo($filename, TechDivision\Import\Cli\PATHINFO_EXTENSION) can also be of type array; however, parameter $type of TechDivision\Import\Configuration\ConfigurationFactoryInterface::factory() does only seem to accept string, maybe add an additional type check?

It seems like $filename can also be of type null; however, parameter $path of pathinfo() does only seem to accept string, maybe add an additional type check?

        }

        // initialize the array for the directories
        $directories = array();

        // set the default file format
        $format = 'json';

        // load the actual vendor directory and entity type code
        $vendorDir = $this->getVendorDir();

        // load the default configuration directory from the DI configuration
        $defaultConfigurationDir = $this->getContainer()->getParameter(DependencyInjectionKeys::APPLICATION_DEFAULT_CONFIGURATION_DIR);

        // load the directories that has to be parsed for configuration files1
        foreach ($this->getDefaultLibraries() as $defaultLibrary) {
            // initialize the directory name
            $directory = implode(
                DIRECTORY_SEPARATOR,
                array_merge(
                    array($vendorDir),
                    explode('/', $defaultLibrary),
                    explode('/', $defaultConfigurationDir)
                )
            );

            // query whether or not the directory is available1
            if (is_dir($directory)) {
                $directories[] = $directory;
            }
        }

        // load the assumed installation directory
        $installationDir = $this->input->getOption(InputOptionKeysInterface::INSTALLATION_DIR);

        // initialize the default custom configuration directory
        $customConfigurationDir = implode(
            DIRECTORY_SEPARATOR,
            array_merge(
                array($installationDir),
                explode('/', $this->getContainer()->getParameter(DependencyInjectionKeys::APPLICATION_CUSTOM_CONFIGURATION_DIR))
            )
        );

        // query whether or not a custom configuration directory has been speified, if yes override the default one
        if ($this->input->hasOptionSpecified(InputOptionKeysInterface::CUSTOM_CONFIGURATION_DIR) && $this->input->getOption(InputOptionKeysInterface::CUSTOM_CONFIGURATION_DIR)) {
            $customConfigurationDir = $this->input->getOption(InputOptionKeysInterface::CUSTOM_CONFIGURATION_DIR);
        }

        // specify the default directory for custom configuration files
        if (is_dir($customConfigurationDir)) {
            $directories[] = $customConfigurationDir;
        }

        // load and return the configuration from the files found in the passed directories
        return $this->configurationFactory->factoryFromDirectories($installationDir, $defaultConfigurationDir, $directories, $format, $params, $paramsFile);

It seems like $params can also be of type string[]; however, parameter $params of TechDivision\Import\Configuration\ConfigurationFactoryInterface::factoryFromDirectories() does only seem to accept string, maybe add an additional type check?

It seems like $paramsFile can also be of type string[]; however, parameter $paramsFile of TechDivision\Import\Configuration\ConfigurationFactoryInterface::factoryFromDirectories() does only seem to accept string, maybe add an additional type check?

It seems like $installationDir can also be of type string[]; however, parameter $installationDir of TechDivision\Import\Configuration\ConfigurationFactoryInterface::factoryFromDirectories() does only seem to accept string, maybe add an additional type check?

Are you sure the usage of $this->configurationFactory->factoryFromDirectories($installationDir, $defaultConfigurationDir, $directories, $format, $params, $paramsFile) targeting TechDivision\Import\Configuration\ConfigurationFactoryInterface::factoryFromDirectories() seems to always return null.

The expression return $this->configurationFactory->factoryFromDirectories($installationDir, $defaultConfigurationDir, $directories, $format, $params, $paramsFile) returns the type void which is incompatible with the documented return type TechDivision\Import\Configuration\ConfigurationInterface.

It seems like $defaultConfigurationDir can also be of type array; however, parameter $defaultConfigurationDir of TechDivision\Import\Configuration\ConfigurationFactoryInterface::factoryFromDirectories() does only seem to accept string, maybe add an additional type check?

    }