ImportCreateConfigurationFileCommand::executeSimpleCommand()

Complexity

Conditions	7
Paths	18

Size

Total Lines	58
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	56

Importance

Changes	1
Bugs	0	Features	0

<?php
    protected function executeSimpleCommand(
        ConfigurationInterface $configuration,
        InputInterface $input,
        OutputInterface $output
    ) {

        // initialize the configuration filename
        $configurationFilename = $input->getOption(InputOptionKeys::DEST);
        if ($configurationFilename === null) {
            $configurationFilename = sprintf('%s/app/etc/techdivision-import.json', $configuration->getCustom());

The method getCustom() does not exist on TechDivision\Import\ConfigurationInterface.

        }

        // extract the format from the configuration file suffix
        $format = pathinfo($configurationFilename, PATHINFO_EXTENSION);

It seems like $configurationFilename can also be of type string[]; however, parameter $path of pathinfo() does only seem to accept string, maybe add an additional type check?

        // initialize the serializer
        $builder = SerializerBuilder::create();
        $builder->addDefaultSerializationVisitors();

        // initialize the naming strategy
        $namingStrategy = new SerializedNameAnnotationStrategy(new IdenticalPropertyNamingStrategy());

        // create the configuration based on the given configuration file suffix
        switch ($format) {
            // initialize the JSON visitor
            case 'json':
                // initialize the visitor because we want to set JSON options
                $visitor = new JsonSerializationVisitor($namingStrategy);
                $visitor->setOptions(JSON_PRETTY_PRINT);
                break;

            // initialize the XML visitor
            case 'xml':
                $visitor = new XmlSerializationVisitor($namingStrategy);
                break;

            // initialize the YAML visitor
            case 'yml':
            case 'yaml':
                $visitor = new YamlSerializationVisitor($namingStrategy);
                break;

            // throw an execption in all other cases
            default:
               throw new \Exception(sprintf('Found invalid configuration format "%s"', $format));
        }

        // register the visitor in the builder instance
        $builder->setSerializationVisitor($format, $visitor);

        // finally create the serializer instance
        $serializer = $builder->build();

        // try to write the configuration file to the actual working directory
        if (file_put_contents($configurationFilename, $serializer->serialize($configuration, $format))) {

It seems like $configurationFilename can also be of type string[]; however, parameter $filename of file_put_contents() does only seem to accept string, maybe add an additional type check?

            $output->writeln(sprintf('<info>Successfully written configuration file %s</info>', $configurationFilename));

It seems like $configurationFilename can also be of type string[]; however, parameter $args of sprintf() does only seem to accept string, maybe add an additional type check?

        } else {
            $output->writeln(sprintf('<error>Can\'t write configuration file %s</error>', $configurationFilename));
        }