TechDivision\Import\Cli\SimpleConfigurationLoader::createConfiguration()

Complexity

Conditions	14
Paths	244

Size

Total Lines	90
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	210

Importance

Changes	2
Bugs	0	Features	0

<?php
    protected function createConfiguration($filename = null)
    {

        // initialize the params specified with the --params parameter
        $params = null;

        // try to load the params from the commandline
        if ($this->input->hasOptionSpecified(InputOptionKeys::PARAMS) && $this->input->getOption(InputOptionKeys::PARAMS)) {

The method hasOptionSpecified() does not exist on Symfony\Component\Console\Input\InputInterface. Did you maybe mean hasOption()?

            $params = $this->input->getOption(InputOptionKeys::PARAMS);
        }

        // initialize the params file specified with the --params-file parameter
        $paramsFile = null;

        // try to load the path of the params file from the commandline
        if ($this->input->hasOptionSpecified(InputOptionKeys::PARAMS_FILE) && $this->input->getOption(InputOptionKeys::PARAMS_FILE)) {
            $paramsFile = $this->input->getOption(InputOptionKeys::PARAMS_FILE);
        }

        // if a filename has been passed, try to load the configuration from the file
        if (is_file($filename)) {
            return $this->configurationFactory->factory($filename, pathinfo($filename, PATHINFO_EXTENSION), $params, $paramsFile);

The call to TechDivision\Import\ConfigurationFactoryInterface::factory() has too many arguments starting with $params.

        }

        // initialize the array for the directories
        $directories = array();

        // set the default file format
        $format = 'json';

        // load the actual vendor directory and entity type code
        $vendorDir = $this->getVendorDir();

        // load the default configuration directory from the DI configuration
        $defaultConfigurationDirectory = $this->getContainer()->getParameter(DependencyInjectionKeys::APPLICATION_DEFAULT_CONFIGURATION_DIR);

        // load the directories that has to be parsed for configuration files1
        foreach ($this->getDefaultLibraries() as $defaultLibrary) {
            // initialize the directory name
            $directory = implode(
                DIRECTORY_SEPARATOR,
                array_merge(
                    array($vendorDir),
                    explode('/', $defaultLibrary),
                    explode('/', $defaultConfigurationDirectory)
                )
            );

            // query whether or not the directory is available1
            if (is_dir($directory)) {
                $directories[] = $directory;
            }
        }

        // initialize the default custom configuration directory
        $customConfigurationDirectory = implode(
            DIRECTORY_SEPARATOR,
            array_merge(
                array(getcwd()),
                explode('/', $this->getContainer()->getParameter(DependencyInjectionKeys::APPLICATION_CUSTOM_CONFIGURATION_DIR))
            )
        );

        // query whether or not a custom configuration directory has been speified, if yes override the default one
        if ($this->input->hasOptionSpecified(InputOptionKeys::CUSTOM_CONFIGURATION_DIR) && $this->input->getOption(InputOptionKeys::CUSTOM_CONFIGURATION_DIR)) {
            $customConfigurationDirectory = $this->input->getOption(InputOptionKeys::CUSTOM_CONFIGURATION_DIR);
        }

        // specify the default directory for custom configuration files
        if (is_dir($customConfigurationDirectory)) {

It seems like $customConfigurationDirectory can also be of type string[]; however, parameter $filename of is_dir() does only seem to accept string, maybe add an additional type check?

            $directories[] = $customConfigurationDirectory;
        }

        // load and return the configuration from the files found in the passed directories
        $instance = $this->configurationFactory->factoryFromDirectories($directories, $format, $params, $paramsFile);

It seems like $paramsFile can also be of type string[]; however, parameter $paramsFile of TechDivision\Import\ConfigurationFactoryInterface::factoryFromDirectories() does only seem to accept string, maybe add an additional type check?

It seems like $params can also be of type string[]; however, parameter $params of TechDivision\Import\ConfigurationFactoryInterface::factoryFromDirectories() does only seem to accept string, maybe add an additional type check?

Are you sure the assignment to $instance is correct as $this->configurationFactory->factoryFromDirectories($directories, $format, $params, $paramsFile) targeting TechDivision\Import\ConfigurationFactoryInterface::factoryFromDirectories() seems to always return null.

        // query whether or not we've an valid Magento root directory specified
        if ($this->isMagentoRootDir($installationDir = $this->input->getOption(InputOptionKeys::INSTALLATION_DIR))) {

It seems like $installationDir = $this->input->getOption(TechDivision\Import\Cli\Command\InputOptionKeys::INSTALLATION_DIR) can also be of type string[]; however, parameter $dir of TechDivision\Import\Cli\SimpleConfigurationLoader::isMagentoRootDir() does only seem to accept string, maybe add an additional type check?

            // add the source directory if NOT specified in the configuration file
            if (($sourceDir = $instance->getSourceDir()) === null) {
                $instance->setSourceDir($sourceDir = sprintf('%s/var/importexport', $installationDir));

It seems like $installationDir can also be of type string[]; however, parameter $args of sprintf() does only seem to accept string, maybe add an additional type check?

            }

            // add the target directory if NOT specified in the configuration file
            if ($instance->getTargetDir() === null) {
                $instance->setTargetDir($sourceDir);
            }
        }

        return $instance;

The expression return $instance returns the type void which is incompatible with the documented return type TechDivision\Import\ConfigurationInterface.

    }