TechDivision\Import\Cli\Command\ImportConvertValueCommand::executeSimpleCommand()

Complexity

Conditions	5
Paths	3

Size

Total Lines	55
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    protected function executeSimpleCommand(
        ConfigurationInterface $configuration,
        InputInterface $input,
        OutputInterface $output
    ) {

        // initialize the default CSV serializer
        $serializer = new ValueCsvSerializer();
        $serializer->init($configuration);

        // initialize the array for the values that has to be serialized
        $serialize = array();

        // load the values that has to be serialized
        $values = $input->getArgument(InputArgumentKeys::VALUES);

        // simulate custom column handling
        switch ($input->getArgument(InputArgumentKeys::COLUMN)) {

            case 'categories':
                // serialize the categories and use the default delimiter
                $serialize[] = $serializer->serialize($values);

It seems like $values can also be of type string; however, parameter $unserialized of TechDivision\Import\Serializers\ValueCsvSerializer::serialize() does only seem to accept array|null, maybe add an additional type check?

                break;

            case 'path':
                // categories use a slash (/) as delimiter for the first level of serialization
                $delimiter = '/';
                // load the enclosure from the configuration
                $enclosure = $configuration->getEnclosure();
                // iterate over the values and serialize them
                for ($i = 0; $i < sizeof($values); $i++) {

It seems like $values can also be of type string; however, parameter $var of sizeof() does only seem to accept Countable|array, maybe add an additional type check?

It seems like you are calling the size function sizeof() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

                    // serialize the value and use a slash (/) as delimiter
                    $val = $serializer->serialize(array($values[$i]), $delimiter);

                    // clean-up (means to remove surrounding + double quotes)
                    // because we've no delimiter within the value
                    if (strstr($val, $delimiter) === false) {
                        $val = preg_replace("/^(\'(.*)\'|${enclosure}(.*)${enclosure})$/", '$2$3', $val);
                        $val = str_replace('""', '"', $val);
                    }

                    // append the cleaned value
                    $values[$i] = $val;
                }

                // implode the category's to get the complete path
                $serialize[] = implode($delimiter, $values);

It seems like $values can also be of type null and string; however, parameter $pieces of implode() does only seem to accept array, maybe add an additional type check?

                break;

            default:
                break;
        }

        // second serialization that simulates the framework parsing the CSV file
        $output->write($serializer->serialize($serialize));
    }