Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
35 | View Code Duplication | class AttributeRepository extends AbstractRepository |
|
|
|||
36 | { |
||
37 | |||
38 | /** |
||
39 | * The prepared statement to load an existing EAV attribute by its attribute code. |
||
40 | * |
||
41 | * @var \PDOStatement |
||
42 | */ |
||
43 | protected $attributeByAttributeCodeStmt; |
||
44 | |||
45 | /** |
||
46 | * Initializes the repository's prepared statements. |
||
47 | * |
||
48 | * @return void |
||
49 | */ |
||
50 | public function init() |
||
59 | |||
60 | /** |
||
61 | * Return's the EAV attribute with the passed code. |
||
62 | * |
||
63 | * @param string $attributeCode The code of the EAV attribute to return |
||
64 | * |
||
65 | * @return array The EAV attribute |
||
66 | */ |
||
67 | public function findOneByAttributeCode($attributeCode) |
||
73 | } |
||
74 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.