Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
35 | View Code Duplication | class EntityAttributeRepository extends AbstractRepository |
|
|
|||
36 | { |
||
37 | |||
38 | /** |
||
39 | * The prepared statement to load an existing EAV entity attribute by its attribute, attribut set and attribute group ID. |
||
40 | * |
||
41 | * @var \PDOStatement |
||
42 | */ |
||
43 | protected $entityAttributeByAttributeIdAndAttributeSetIdAndAttributeGroupIdStmt; |
||
44 | |||
45 | /** |
||
46 | * Initializes the repository's prepared statements. |
||
47 | * |
||
48 | * @return void |
||
49 | */ |
||
50 | public function init() |
||
59 | |||
60 | /** |
||
61 | * Return's the EAV entity attribute with the passed entity type, attribute, attribute set and attribute group ID. |
||
62 | * |
||
63 | * @param integer $entityTypeId The ID of the EAV entity attribute's entity type to return |
||
64 | * @param integer $attributeId The ID of the EAV entity attribute's attribute to return |
||
65 | * @param integer $attributeSetId The ID of the EAV entity attribute's attribute set to return |
||
66 | * @param integer $attributeGroupId The ID of the EAV entity attribute's attribute group to return |
||
67 | * |
||
68 | * @return array The EAV entity attribute |
||
69 | */ |
||
70 | public function findOneByEntityTypeAndAttributeIdAndAttributeSetIdAndAttributeGroupId($entityTypeId, $attributeId, $attributeSetId, $attributeGroupId) |
||
85 | } |
||
86 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.