Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
35 | View Code Duplication | class AttributeOptionSwatchRepository extends AbstractRepository |
|
|
|||
36 | { |
||
37 | |||
38 | /** |
||
39 | * The prepared statement to load an existing EAV attribute option swatch by its attribute code, store ID. value and type. |
||
40 | * |
||
41 | * @var \PDOStatement |
||
42 | */ |
||
43 | protected $attributeOptionSwatchByAttributeCodeAndStoreIdAndValueAndTypeStmt; |
||
44 | |||
45 | /** |
||
46 | * Initializes the repository's prepared statements. |
||
47 | * |
||
48 | * @return void |
||
49 | */ |
||
50 | public function init() |
||
59 | |||
60 | /** |
||
61 | * Load's and return's the EAV attribute option swatch with the passed code, store ID, value and type. |
||
62 | * |
||
63 | * @param string $attributeCode The code of the EAV attribute option swatch to load |
||
64 | * @param integer $storeId The store ID of the attribute option swatch to load |
||
65 | * @param string $value The value of the attribute option swatch to load |
||
66 | * @param string $type The type of the attribute option swatch to load |
||
67 | * |
||
68 | * @return array The EAV attribute option swatch |
||
69 | */ |
||
70 | public function findOneByAttributeCodeAndStoreIdAndValue($attributeCode, $storeId, $value, $type) |
||
85 | } |
||
86 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.