Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
35 | View Code Duplication | class CatalogAttributeRepository extends AbstractRepository |
|
|
|||
36 | { |
||
37 | |||
38 | /** |
||
39 | * The prepared statement to load an existing EAV catalog attribute by its ID. |
||
40 | * |
||
41 | * @var \PDOStatement |
||
42 | */ |
||
43 | protected $catalogAttributeStmt; |
||
44 | |||
45 | /** |
||
46 | * Initializes the repository's prepared statements. |
||
47 | * |
||
48 | * @return void |
||
49 | */ |
||
50 | public function init() |
||
59 | |||
60 | /** |
||
61 | * Return's the EAV catalog attribute with the passed ID. |
||
62 | * |
||
63 | * @param string $attributeId The ID of the EAV catalog attribute to return |
||
64 | * |
||
65 | * @return array The EAV catalog attribute |
||
66 | */ |
||
67 | public function load($attributeId) |
||
73 | } |
||
74 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.